[PATCH v2 0/7] Fix some memleaks caused by ptimer_init

Gan Qixin posted 7 patches 3 years, 3 months ago
Only 0 patches received!
hw/arm/musicpal.c            | 12 ++++++++++++
hw/rtc/exynos4210_rtc.c      |  9 +++++++++
hw/timer/allwinner-a10-pit.c | 11 +++++++++++
hw/timer/digic-timer.c       |  8 ++++++++
hw/timer/exynos4210_mct.c    | 14 ++++++++++++++
hw/timer/exynos4210_pwm.c    | 11 +++++++++++
hw/timer/mss-timer.c         | 13 +++++++++++++
7 files changed, 78 insertions(+)
[PATCH v2 0/7] Fix some memleaks caused by ptimer_init
Posted by Gan Qixin 3 years, 3 months ago
v1->v2:
Changes suggested by Peter Maydell:
    Delete the modification of unrelated whitespace.

Gan Qixin (7):
  allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid
    memleaks
  digic-timer: Use ptimer_free() in the finalize function to avoid
    memleaks
  exynos4210_mct: Use ptimer_free() in the finalize function to avoid
    memleaks
  exynos4210_pwm: Use ptimer_free() in the finalize function to avoid
    memleaks
  exynos4210_rtc: Use ptimer_free() in the finalize function to avoid
    memleaks
  mss-timer: Use ptimer_free() in the finalize function to avoid
    memleaks
  musicpal: Use ptimer_free() in the finalize function to avoid memleaks

 hw/arm/musicpal.c            | 12 ++++++++++++
 hw/rtc/exynos4210_rtc.c      |  9 +++++++++
 hw/timer/allwinner-a10-pit.c | 11 +++++++++++
 hw/timer/digic-timer.c       |  8 ++++++++
 hw/timer/exynos4210_mct.c    | 14 ++++++++++++++
 hw/timer/exynos4210_pwm.c    | 11 +++++++++++
 hw/timer/mss-timer.c         | 13 +++++++++++++
 7 files changed, 78 insertions(+)

-- 
2.23.0


Re: [PATCH v2 0/7] Fix some memleaks caused by ptimer_init
Posted by Peter Maydell 3 years, 2 months ago
On Thu, 17 Dec 2020 at 11:32, Gan Qixin <ganqixin@huawei.com> wrote:
>
> v1->v2:
> Changes suggested by Peter Maydell:
>     Delete the modification of unrelated whitespace.
>
> Gan Qixin (7):
>   allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   digic-timer: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   exynos4210_mct: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   exynos4210_pwm: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   exynos4210_rtc: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   mss-timer: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   musicpal: Use ptimer_free() in the finalize function to avoid memleaks

Applied to target-arm.next, thanks.

PS: something odd happened with the threading of this series --
the patch emails weren't follow-ups to the cover letter --
so the automated tools like patchew got confused and thought
the series was empty:
https://patchew.org/QEMU/20201217113137.121607-1-ganqixin@huawei.com/

You might want to look into fixing that for next time you send
a patchset.

thanks
-- PMM

RE: [PATCH v2 0/7] Fix some memleaks caused by ptimer_init
Posted by ganqixin 3 years, 2 months ago
> -----Original Message-----
> From: Peter Maydell [mailto:peter.maydell@linaro.org]
> Sent: Friday, January 8, 2021 7:43 PM
> To: ganqixin <ganqixin@huawei.com>
> Cc: QEMU Developers <qemu-devel@nongnu.org>; QEMU Trivial
> <qemu-trivial@nongnu.org>; Beniamino Galvani <b.galvani@gmail.com>;
> Antony Pavlov <antonynpavlov@gmail.com>; Igor Mitsyanko
> <i.mitsyanko@gmail.com>; sundeep subbaraya <sundeep.lkml@gmail.com>;
> Jan Kiszka <jan.kiszka@web.de>; Chenqun (kuhn)
> <kuhn.chenqun@huawei.com>; Zhanghailiang
> <zhang.zhanghailiang@huawei.com>
> Subject: Re: [PATCH v2 0/7] Fix some memleaks caused by ptimer_init
> 
> On Thu, 17 Dec 2020 at 11:32, Gan Qixin <ganqixin@huawei.com> wrote:
> >
> > v1->v2:
> > Changes suggested by Peter Maydell:
> >     Delete the modification of unrelated whitespace.
> >
> > Gan Qixin (7):
> >   allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid
> >     memleaks
> >   digic-timer: Use ptimer_free() in the finalize function to avoid
> >     memleaks
> >   exynos4210_mct: Use ptimer_free() in the finalize function to avoid
> >     memleaks
> >   exynos4210_pwm: Use ptimer_free() in the finalize function to avoid
> >     memleaks
> >   exynos4210_rtc: Use ptimer_free() in the finalize function to avoid
> >     memleaks
> >   mss-timer: Use ptimer_free() in the finalize function to avoid
> >     memleaks
> >   musicpal: Use ptimer_free() in the finalize function to avoid
> > memleaks
> 
> Applied to target-arm.next, thanks.
> 
> PS: something odd happened with the threading of this series -- the patch
> emails weren't follow-ups to the cover letter -- so the automated tools like
> patchew got confused and thought the series was empty:
> https://patchew.org/QEMU/20201217113137.121607-1-ganqixin@huawei.co
> m/
> 
> You might want to look into fixing that for next time you send a patchset.
> 

Thanks for telling me the error that occurred when receiving this patch email. I will fix it.