From nobody Sun May 5 04:26:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1606461658; cv=none; d=zohomail.com; s=zohoarc; b=bNkliPWv7q06ECAsrvcUZK/jjyVtsC0WpVw/KMaoOYM8CAijKmAOX9a18yPSJoRcLOoLX7GuZu9XoTdXp4Ui2LaKS0YehXGTWqVgRhYPG+BJvONy8pnbhKjs4qrhWkBRjVfO98kuz/wOi9YXPHuPH3ctlCRMZ0VehnkbMAjqbLQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606461658; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FWOannr2iuTDZ0ZncVsxJfUm9KuOYTu+vWazTc7O7SA=; b=T66Ivvv5HECEYZi41aCgosDiKFgXg4bTVPL1+o/2NyhdEYWOBeHvZnH3Y2g7n55nS2zpYrBNXo3ZAhgAll9krNpZjLdkYDphHhuZvoiXPItC4FFZ5NYOCfph5eN0IHGmyiQ70sJPMkvVUpPynUFOAGJQaWam33nIYJnjxOvP2Y8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606461658310434.59035274565986; Thu, 26 Nov 2020 23:20:58 -0800 (PST) Received: from localhost ([::1]:57970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiY3q-0003da-W9 for importer@patchew.org; Fri, 27 Nov 2020 02:20:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1m-0002Aq-6q; Fri, 27 Nov 2020 02:18:46 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1k-0007gu-2Z; Fri, 27 Nov 2020 02:18:45 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Cj5ZB4vSkzkZmR; Fri, 27 Nov 2020 15:18:10 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 27 Nov 2020 15:18:31 +0800 From: Gan Qixin To: , Subject: [PATCH 1/7] allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid memleaks Date: Fri, 27 Nov 2020 15:17:57 +0800 Message-ID: <20201127071803.2479462-2-ganqixin@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201127071803.2479462-1-ganqixin@huawei.com> References: <20201127071803.2479462-1-ganqixin@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=ganqixin@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Beniamino Galvani , Gan Qixin , Euler Robot , kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When running device-introspect-test, a memory leak occurred in the a10_pit_= init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 288 byte(s) in 6 object(s) allocated from: #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0) #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800) #2 0xaaabf555db84 in timer_new_full /qemu/include/qemu/timer.h:523 #3 0xaaabf555db84 in timer_new /qemu/include/qemu/timer.h:544 #4 0xaaabf555db84 in timer_new_ns /qemu/include/qemu/timer.h:562 #5 0xaaabf555db84 in ptimer_init /qemu/hw/core/ptimer.c:433 #6 0xaaabf57415e8 in a10_pit_init /qemu/hw/timer/allwinner-a10-pit.c:278 #7 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #8 0xaaabf633ca04 in object_initialize_child_with_propsv /qemu/qom/obje= ct.c:564 #9 0xaaabf633cc08 in object_initialize_child_with_props /qemu/qom/objec= t.c:547 #10 0xaaabf5b94680 in aw_a10_init /qemu/hw/arm/allwinner-a10.c:49 #11 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #12 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729 Reported-by: Euler Robot Signed-off-by: Gan Qixin --- Cc: Beniamino Galvani --- hw/timer/allwinner-a10-pit.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/hw/timer/allwinner-a10-pit.c b/hw/timer/allwinner-a10-pit.c index f84fc0ea25..be211983b0 100644 --- a/hw/timer/allwinner-a10-pit.c +++ b/hw/timer/allwinner-a10-pit.c @@ -279,6 +279,16 @@ static void a10_pit_init(Object *obj) } } =20 +static void a10_pit_finalize(Object *obj) +{ + AwA10PITState *s =3D AW_A10_PIT(obj); + int i; + + for (i =3D 0; i < AW_A10_PIT_TIMER_NR; i++) { + ptimer_free(s->timer[i]); + } +} + static void a10_pit_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -290,11 +300,12 @@ static void a10_pit_class_init(ObjectClass *klass, vo= id *data) } =20 static const TypeInfo a10_pit_info =3D { - .name =3D TYPE_AW_A10_PIT, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_size =3D sizeof(AwA10PITState), - .instance_init =3D a10_pit_init, - .class_init =3D a10_pit_class_init, + .name =3D TYPE_AW_A10_PIT, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(AwA10PITState), + .instance_init =3D a10_pit_init, + .instance_finalize =3D a10_pit_finalize, + .class_init =3D a10_pit_class_init, }; =20 static void a10_register_types(void) --=20 2.23.0 From nobody Sun May 5 04:26:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1606461908; cv=none; d=zohomail.com; s=zohoarc; b=AdwR0JqNBp3UDkd6JRAYU7kk+oip4GmxN+RjsNZQtQfDLRckhCtQ4kgblMPl1xdMhqAi1w8fVzJG0rr++MlJ+AVATCsmsclwpi3mLE3RAF0lIRRaOMwzVh2H1CnadQCopg2Id6g1bupC6KDN+y0EBIJUKRvA61ADstUrys6aYIg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606461908; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sVKMEmthZd6PabCHyp6gqRgfddDRO+KJhcuJYvRLUWU=; b=mIWbXGzUoCg3M5aCbrNMwiTf40zM/hHfesBA8itT0d2sMyu+Wsm10EVbu1wLxvGSovBzRX5oCsAljcC7/Y5l+6KCRI+Xfd6p1vpxcp3m5urtjevBZoDFqyhs+603EVlvFaibDJqVvS2I74Ut7wNtuCD6xeYRD7azZtzAp+XjwGo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606461908628692.157847970536; Thu, 26 Nov 2020 23:25:08 -0800 (PST) Received: from localhost ([::1]:39258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiY7v-0007rW-Gb for importer@patchew.org; Fri, 27 Nov 2020 02:25:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1p-0002Eu-RE; Fri, 27 Nov 2020 02:18:49 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1n-0007gv-Uc; Fri, 27 Nov 2020 02:18:49 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Cj5ZB4jvbzkZVH; Fri, 27 Nov 2020 15:18:10 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 27 Nov 2020 15:18:33 +0800 From: Gan Qixin To: , Subject: [PATCH 2/7] digic-timer: Use ptimer_free() in the finalize function to avoid memleaks Date: Fri, 27 Nov 2020 15:17:58 +0800 Message-ID: <20201127071803.2479462-3-ganqixin@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201127071803.2479462-1-ganqixin@huawei.com> References: <20201127071803.2479462-1-ganqixin@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=ganqixin@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Antony Pavlov , Gan Qixin , Euler Robot , kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When running device-introspect-test, a memory leak occurred in the digic_ti= mer_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 288 byte(s) in 3 object(s) allocated from: #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0) #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800) #2 0xaaabf555db78 in ptimer_init /qemu/hw/core/ptimer.c:432 #3 0xaaabf5b04084 in digic_timer_init /qemu/hw/timer/digic-timer.c:142 #4 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #5 0xaaabf633ca04 in object_initialize_child_with_propsv /qemu/qom/obje= ct.c:564 #6 0xaaabf633cc08 in object_initialize_child_with_props /qemu/qom/objec= t.c:547 #7 0xaaabf5b40e84 in digic_init /qemu/hw/arm/digic.c:46 #8 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #9 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729 #10 0xaaabf6375e40 in qmp_device_list_properties /qemu/qom/qom-qmp-cmds= .c:153 #11 0xaaabf653d8ec in qmp_marshal_device_list_properties /qemu/qapi/qap= i-commands-qdev.c:59 #12 0xaaabf6587d08 in do_qmp_dispatch_bh /qemu/qapi/qmp-dispatch.c:110 Reported-by: Euler Robot Signed-off-by: Gan Qixin --- Cc: Antony Pavlov --- hw/timer/digic-timer.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/timer/digic-timer.c b/hw/timer/digic-timer.c index 32612228da..86075987fb 100644 --- a/hw/timer/digic-timer.c +++ b/hw/timer/digic-timer.c @@ -154,6 +154,13 @@ static void digic_timer_init(Object *obj) sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->iomem); } =20 +static void digic_timer_finalize(Object *obj) +{ + DigicTimerState *s =3D DIGIC_TIMER(obj); + + ptimer_free(s->ptimer); +} + static void digic_timer_class_init(ObjectClass *klass, void *class_data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -163,11 +170,12 @@ static void digic_timer_class_init(ObjectClass *klass= , void *class_data) } =20 static const TypeInfo digic_timer_info =3D { - .name =3D TYPE_DIGIC_TIMER, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_size =3D sizeof(DigicTimerState), - .instance_init =3D digic_timer_init, - .class_init =3D digic_timer_class_init, + .name =3D TYPE_DIGIC_TIMER, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(DigicTimerState), + .instance_init =3D digic_timer_init, + .instance_finalize =3D digic_timer_finalize, + .class_init =3D digic_timer_class_init, }; =20 static void digic_timer_register_type(void) --=20 2.23.0 From nobody Sun May 5 04:26:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1606461798; cv=none; d=zohomail.com; s=zohoarc; b=NBwmRanoOF5YV0Y48WPUr/MIqBe0sDoKQPBmszdgP/SKIPwuswIhsHCa+l6bYSk6SDP2oSZU/l8tztPjvgsACLKsGuevtkaya4M8kgAMeYPbBgQbFTBm+317m9y/4Ff7VdZxGaRbNUuG+XanZ0dOJpWoc+9jRiPR3MKVgT7/788= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606461798; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JS8MOc1rf+4P2zlIabWVkzhUcRU1goOtpCHDVqIl/Ok=; b=CyseEWLmBIUFv+ycgiZ0UweiL0D3qRCoYyXCCLV6r+W5Z2XDsAPqONB64oNHtcbRVtcyv/hkVINwPvZaO5pIhxnFdSSZ2SXNGgR4nZImCZUpdtUdcWnGWQF4qI6H3ceeLbfsyIJvVvwiyjVP++Zr00jYMQuBXHl0zZyI7jsbzR4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160646179862992.24461706440957; Thu, 26 Nov 2020 23:23:18 -0800 (PST) Received: from localhost ([::1]:34072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiY69-0005dI-By for importer@patchew.org; Fri, 27 Nov 2020 02:23:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1u-0002No-I8; Fri, 27 Nov 2020 02:18:54 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1r-0007jn-Ka; Fri, 27 Nov 2020 02:18:54 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Cj5ZQ1BXFz15TLJ; Fri, 27 Nov 2020 15:18:22 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 27 Nov 2020 15:18:37 +0800 From: Gan Qixin To: , Subject: [PATCH 3/7] exynos4210_mct: Use ptimer_free() in the finalize function to avoid memleaks Date: Fri, 27 Nov 2020 15:17:59 +0800 Message-ID: <20201127071803.2479462-4-ganqixin@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201127071803.2479462-1-ganqixin@huawei.com> References: <20201127071803.2479462-1-ganqixin@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=ganqixin@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Igor Mitsyanko , Gan Qixin , Euler Robot , kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When running device-introspect-test, a memory leak occurred in the exynos42= 10_mct_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 96 byte(s) in 1 object(s) allocated from: #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0) #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800) #2 0xaaabf555db78 in ptimer_init /qemu/hw/core/ptimer.c:432 #3 0xaaabf56b01a0 in exynos4210_mct_init /qemu/hw/timer/exynos4210_mct.= c:1505 #4 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #5 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729 #6 0xaaabf6375e40 in qmp_device_list_properties /qemu/qom/qom-qmp-cmds.= c:153 #7 0xaaabf653d8ec in qmp_marshal_device_list_properties /qemu/qapi/qapi= -commands-qdev.c:59 #8 0xaaabf6587d08 in do_qmp_dispatch_bh /qemu/qapi/qmp-dispatch.c:110 #9 0xaaabf6552708 in aio_bh_call /qemu/util/async.c:136 #10 0xaaabf6552708 in aio_bh_poll /qemu/util/async.c:164 #11 0xaaabf655f19c in aio_dispatch /qemu/util/aio-posix.c:381 #12 0xaaabf65523f4 in aio_ctx_dispatch /qemu/util/async.c:306 Reported-by: Euler Robot Signed-off-by: Gan Qixin --- Cc: Igor Mitsyanko --- hw/timer/exynos4210_mct.c | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index 439053acd2..7172ec425d 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -1530,6 +1530,19 @@ static void exynos4210_mct_init(Object *obj) sysbus_init_mmio(dev, &s->iomem); } =20 +static void exynos4210_mct_finalize(Object *obj) +{ + int i; + Exynos4210MCTState *s =3D EXYNOS4210_MCT(obj); + + ptimer_free(s->g_timer.ptimer_frc); + + for (i =3D 0; i < 2; i++) { + ptimer_free(s->l_timer[i].tick_timer.ptimer_tick); + ptimer_free(s->l_timer[i].ptimer_frc); + } +} + static void exynos4210_mct_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -1539,11 +1552,12 @@ static void exynos4210_mct_class_init(ObjectClass *= klass, void *data) } =20 static const TypeInfo exynos4210_mct_info =3D { - .name =3D TYPE_EXYNOS4210_MCT, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_size =3D sizeof(Exynos4210MCTState), - .instance_init =3D exynos4210_mct_init, - .class_init =3D exynos4210_mct_class_init, + .name =3D TYPE_EXYNOS4210_MCT, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(Exynos4210MCTState), + .instance_init =3D exynos4210_mct_init, + .instance_finalize =3D exynos4210_mct_finalize, + .class_init =3D exynos4210_mct_class_init, }; =20 static void exynos4210_mct_register_types(void) --=20 2.23.0 From nobody Sun May 5 04:26:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1606462070; cv=none; d=zohomail.com; s=zohoarc; b=dqJedjRBPJxCzOKIcBGOKBoYfjzlG/p56fznAi12tjeQa/TIrmPR1YRE9TZfNQpw33rFAug5WCGaziaoP8U4hv9ruz8H+W7G7W8v2kxWjRUZacKSEXcSi1M6WQWSb6N1uh9xuODII8jScqcHQmiuumIWCqm1HvZd6IR9ecDO1OM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606462070; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CaSuv5I/61M8cgPDwhjJqKeRvl65P8lS5Taff7h45/Q=; b=dAaYzgORbc839mBsHyRU2LqR7ELVAwaXtEAcRBraXIeACBkL1UnLEHlZ29CcaueolJ2MVFQUwVIkLnqBDVr4Xj9WDgAV7CsN5tH/Wt9gq9ULszA6xNWmamNvhKQVAURu9ragLfxqYtOL50OzlqGsfjjIcU4lcxFvFEobEg9OV3Y= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606462070307895.6426189175827; Thu, 26 Nov 2020 23:27:50 -0800 (PST) Received: from localhost ([::1]:45038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiYAX-0001xa-4H for importer@patchew.org; Fri, 27 Nov 2020 02:27:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1y-0002U3-6Z; Fri, 27 Nov 2020 02:18:58 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2979) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1u-0007jv-C5; Fri, 27 Nov 2020 02:18:57 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cj5ZW2SFNzhjDc; Fri, 27 Nov 2020 15:18:27 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 27 Nov 2020 15:18:39 +0800 From: Gan Qixin To: , Subject: [PATCH 4/7] exynos4210_pwm: Use ptimer_free() in the finalize function to avoid memleaks Date: Fri, 27 Nov 2020 15:18:00 +0800 Message-ID: <20201127071803.2479462-5-ganqixin@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201127071803.2479462-1-ganqixin@huawei.com> References: <20201127071803.2479462-1-ganqixin@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=ganqixin@huawei.com; helo=szxga05-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Igor Mitsyanko , Gan Qixin , Euler Robot , kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When running device-introspect-test, a memory leak occurred in the exynos42= 10_pwm_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 240 byte(s) in 5 object(s) allocated from: #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0) #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800) #2 0xaaabf555db84 in timer_new_full /qemu/include/qemu/timer.h:523 #3 0xaaabf555db84 in timer_new /qemu/include/qemu/timer.h:544 #4 0xaaabf555db84 in timer_new_ns /qemu/include/qemu/timer.h:562 #5 0xaaabf555db84 in ptimer_init /qemu/hw/core/ptimer.c:433 #6 0xaaabf56a36cc in exynos4210_pwm_init /qemu/hw/timer/exynos4210_pwm.= c:401 #7 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #8 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729 #9 0xaaabf6375e40 in qmp_device_list_properties /qemu/qom/qom-qmp-cmds.= c:153 #10 0xaaabf653d8ec in qmp_marshal_device_list_properties /qemu/qapi/qap= i-commands-qdev.c:59 #11 0xaaabf6587d08 in do_qmp_dispatch_bh /qemu/qapi/qmp-dispatch.c:110 #12 0xaaabf6552708 in aio_bh_call /qemu/util/async.c:136 Reported-by: Euler Robot Signed-off-by: Gan Qixin --- Cc: Igor Mitsyanko --- hw/timer/exynos4210_pwm.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/hw/timer/exynos4210_pwm.c b/hw/timer/exynos4210_pwm.c index de181428b4..4764164d5e 100644 --- a/hw/timer/exynos4210_pwm.c +++ b/hw/timer/exynos4210_pwm.c @@ -410,6 +410,16 @@ static void exynos4210_pwm_init(Object *obj) sysbus_init_mmio(dev, &s->iomem); } =20 +static void exynos4210_pwm_finalize(Object *obj) +{ + Exynos4210PWMState *s =3D EXYNOS4210_PWM(obj); + int i; + + for (i =3D 0; i < EXYNOS4210_PWM_TIMERS_NUM; i++) { + ptimer_free(s->timer[i].ptimer); + } +} + static void exynos4210_pwm_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -419,11 +429,12 @@ static void exynos4210_pwm_class_init(ObjectClass *kl= ass, void *data) } =20 static const TypeInfo exynos4210_pwm_info =3D { - .name =3D TYPE_EXYNOS4210_PWM, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_size =3D sizeof(Exynos4210PWMState), - .instance_init =3D exynos4210_pwm_init, - .class_init =3D exynos4210_pwm_class_init, + .name =3D TYPE_EXYNOS4210_PWM, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(Exynos4210PWMState), + .instance_init =3D exynos4210_pwm_init, + .instance_finalize =3D exynos4210_pwm_finalize, + .class_init =3D exynos4210_pwm_class_init, }; =20 static void exynos4210_pwm_register_types(void) --=20 2.23.0 From nobody Sun May 5 04:26:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1606462132; cv=none; d=zohomail.com; s=zohoarc; b=HnSkYMZ8hPc4gdixnha50GGHu1y1Oj62UYPrQGtUNdLk8FmCFcHJ2DGQ0xnQKwT6LfOxzt73uXUaFxEcddIITBDTieGvUXj+va1CU/hibeL9dkpwpmlEPBe2r8VvddlYcsdML/h0dpprGugQydorNl1bUgALJtZk8tRjfuW9EQs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606462132; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1m72dkgmlwwSprrXoM1rcEMXSOc1nGiS3WUa1ywsO3A=; b=WrGQi3WA72EnBL8hZrEvPpJ+hyMav+FmcGBVedbAWUBg6VHaDBwYtmnu/RejqI8ik+B/HhGsxlZcrJs/DFwJ5E5bQ1DCs02GFKe8Z6I/tCVSvIiZOLJMss0gznSkhA08Ntl6k+ReysiCusLXSG/VbQyQXCFC1x+0TPe94/XRrYE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606462132117219.07106229310796; Thu, 26 Nov 2020 23:28:52 -0800 (PST) Received: from localhost ([::1]:47054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiYBX-0002n9-2K for importer@patchew.org; Fri, 27 Nov 2020 02:28:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1x-0002Ta-TY; Fri, 27 Nov 2020 02:18:57 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1v-0007ju-Tj; Fri, 27 Nov 2020 02:18:57 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cj5ZW2dByzhjDw; Fri, 27 Nov 2020 15:18:27 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 27 Nov 2020 15:18:40 +0800 From: Gan Qixin To: , Subject: [PATCH 5/7] exynos4210_rtc: Use ptimer_free() in the finalize function to avoid memleaks Date: Fri, 27 Nov 2020 15:18:01 +0800 Message-ID: <20201127071803.2479462-6-ganqixin@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201127071803.2479462-1-ganqixin@huawei.com> References: <20201127071803.2479462-1-ganqixin@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=ganqixin@huawei.com; helo=szxga05-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Igor Mitsyanko , Gan Qixin , Euler Robot , kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When running device-introspect-test, a memory leak occurred in the exynos42= 10_rtc_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 96 byte(s) in 1 object(s) allocated from: #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0) #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800) #2 0xaaabf555db78 in ptimer_init /qemu/hw/core/ptimer.c:432 #3 0xaaabf57b3934 in exynos4210_rtc_init /qemu/hw/rtc/exynos4210_rtc.c:= 567 #4 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #5 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729 #6 0xaaabf6375e40 in qmp_device_list_properties /qemu/qom/qom-qmp-cmds.= c:153 #7 0xaaabf653d8ec in qmp_marshal_device_list_properties /qemu/qapi/qapi= -commands-qdev.c:59 #8 0xaaabf6587d08 in do_qmp_dispatch_bh /qemu/qapi/qmp-dispatch.c:110 #9 0xaaabf6552708 in aio_bh_call /qemu/util/async.c:136 #10 0xaaabf6552708 in aio_bh_poll /qemu/util/async.c:164 #11 0xaaabf655f19c in aio_dispatch /qemu/util/aio-posix.c:381 #12 0xaaabf65523f4 in aio_ctx_dispatch /qemu/util/async.c:306 Reported-by: Euler Robot Signed-off-by: Gan Qixin --- Cc: Igor Mitsyanko --- hw/rtc/exynos4210_rtc.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/hw/rtc/exynos4210_rtc.c b/hw/rtc/exynos4210_rtc.c index 4c97624478..2f667fb010 100644 --- a/hw/rtc/exynos4210_rtc.c +++ b/hw/rtc/exynos4210_rtc.c @@ -584,6 +584,14 @@ static void exynos4210_rtc_init(Object *obj) sysbus_init_mmio(dev, &s->iomem); } =20 +static void exynos4210_rtc_finalize(Object *obj) +{ + Exynos4210RTCState *s =3D EXYNOS4210_RTC(obj); + + ptimer_free(s->ptimer); + ptimer_free(s->ptimer_1Hz); +} + static void exynos4210_rtc_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -593,11 +601,12 @@ static void exynos4210_rtc_class_init(ObjectClass *kl= ass, void *data) } =20 static const TypeInfo exynos4210_rtc_info =3D { - .name =3D TYPE_EXYNOS4210_RTC, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_size =3D sizeof(Exynos4210RTCState), - .instance_init =3D exynos4210_rtc_init, - .class_init =3D exynos4210_rtc_class_init, + .name =3D TYPE_EXYNOS4210_RTC, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(Exynos4210RTCState), + .instance_init =3D exynos4210_rtc_init, + .instance_finalize =3D exynos4210_rtc_finalize, + .class_init =3D exynos4210_rtc_class_init, }; =20 static void exynos4210_rtc_register_types(void) --=20 2.23.0 From nobody Sun May 5 04:26:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1606461960; cv=none; d=zohomail.com; s=zohoarc; b=ncbMw9ydAfTLk8YR6tPG44f/jzezKgHSvPSDZe7oAx0OYIirrgXn1/0eWGhfwOaDbGg4W0L00FnbBKt+PcmgmzmJWfzL4y3ySW2+BSuzM3pBdP3Bl8YjqnmgG7bYiznsqVXaI45rvebUJWbCtNE+tPu3MpIUoCRMft5765Q5l1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606461960; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DrSi14Pdqqg38zFZKOx/7mb2x7mu2Ws94sJjqeIONRo=; b=Oo9O2BMe3hdoDVYZWgMXCyfNE/l8GoyI6FMBusc9cB3fsvDt46Q8vKY3Ecn9cPnCwkClz8P1gOiIfGqgTgLAApxDUn6durkZVADToCD/RNwCFK1X/w118zRaGj/r1oXdLXu0ojXAfZr+bPYg50H9vUatI5QSLAP3wKyuwsR2hvA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606461960395889.4691939448015; Thu, 26 Nov 2020 23:26:00 -0800 (PST) Received: from localhost ([::1]:41846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiY8l-0000YR-9l for importer@patchew.org; Fri, 27 Nov 2020 02:25:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1w-0002Qy-Gr; Fri, 27 Nov 2020 02:18:56 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1t-0007jt-TL; Fri, 27 Nov 2020 02:18:56 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cj5ZW2GSLzhjDP; Fri, 27 Nov 2020 15:18:27 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 27 Nov 2020 15:18:42 +0800 From: Gan Qixin To: , Subject: [PATCH 6/7] mss-timer: Use ptimer_free() in the finalize function to avoid memleaks Date: Fri, 27 Nov 2020 15:18:02 +0800 Message-ID: <20201127071803.2479462-7-ganqixin@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201127071803.2479462-1-ganqixin@huawei.com> References: <20201127071803.2479462-1-ganqixin@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=ganqixin@huawei.com; helo=szxga05-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Subbaraya Sundeep , Gan Qixin , Euler Robot , kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When running device-introspect-test, a memory leak occurred in the mss_time= r_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 192 byte(s) in 2 object(s) allocated from: #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0) #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800) #2 0xaaabf555db78 in ptimer_init /qemu/hw/core/ptimer.c:432 #3 0xaaabf58a0010 in mss_timer_init /qemu/hw/timer/mss-timer.c:235 #4 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #5 0xaaabf633ca04 in object_initialize_child_with_propsv /qemu/qom/obje= ct.c:564 #6 0xaaabf633cc08 in object_initialize_child_with_props /qemu/qom/objec= t.c:547 #7 0xaaabf5b8316c in m2sxxx_soc_initfn /qemu/hw/arm/msf2-soc.c:70 #8 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #9 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729 #10 0xaaabf6375e40 in qmp_device_list_properties /qemu/qom/qom-qmp-cmds= .c:153 #11 0xaaabf653d8ec in qmp_marshal_device_list_properties /qemu/qapi/qap= i-commands-qdev.c:59 #12 0xaaabf6587d08 in do_qmp_dispatch_bh /qemu/qapi/qmp-dispatch.c:110 Reported-by: Euler Robot Signed-off-by: Gan Qixin --- Cc: Subbaraya Sundeep --- hw/timer/mss-timer.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/hw/timer/mss-timer.c b/hw/timer/mss-timer.c index 29943fd744..7c4f3a52da 100644 --- a/hw/timer/mss-timer.c +++ b/hw/timer/mss-timer.c @@ -244,6 +244,18 @@ static void mss_timer_init(Object *obj) sysbus_init_mmio(SYS_BUS_DEVICE(obj), &t->mmio); } =20 +static void mss_timer_finalize(Object *obj) +{ + MSSTimerState *t =3D MSS_TIMER(obj); + int i; + + for (i =3D 0; i < NUM_TIMERS; i++) { + struct Msf2Timer *st =3D &t->timers[i]; + + ptimer_free(st->ptimer); + } +} + static const VMStateDescription vmstate_timers =3D { .name =3D "mss-timer-block", .version_id =3D 1, @@ -283,11 +295,12 @@ static void mss_timer_class_init(ObjectClass *klass, = void *data) } =20 static const TypeInfo mss_timer_info =3D { - .name =3D TYPE_MSS_TIMER, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_size =3D sizeof(MSSTimerState), - .instance_init =3D mss_timer_init, - .class_init =3D mss_timer_class_init, + .name =3D TYPE_MSS_TIMER, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(MSSTimerState), + .instance_init =3D mss_timer_init, + .instance_finalize =3D mss_timer_finalize, + .class_init =3D mss_timer_class_init, }; =20 static void mss_timer_register_types(void) --=20 2.23.0 From nobody Sun May 5 04:26:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1606462197; cv=none; d=zohomail.com; s=zohoarc; b=LK+iPNtsD56a51FM9YQEnkR5Tgei5zBrUlTg6u/hy52J7OWxsZ1JIlRv/mFN01/vU6Mm+JiuvrReEAJKRqvVKafj40r1WXMPDCXZp4cnCRGYNFuKaOz7vfcz36oMHV9MfeJ7cyAhRYZ2VE+f0/NzL4mMfOBEjo+rK12w/LviEQE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606462197; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=r6iC2monBXCodiS8fpf3kZIGWxpjI8Vdywzh17ytiQI=; b=QESPF4D6lSbKeuGP12HtV4TZWQRz9BVhH3u5RPhkdbZ8stBQMQRj5yrAXThcuDF2zSH36ftVpRm3YmIAkzrRGjunLB20KQ7Iu3failtYvJh2kWGJHojPCk3sCkIOb35ilLDgI6sLG+un4FuvUZc4RZuzjF7mWzplK5TcW9MWN5E= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1606462197279995.6093016786538; Thu, 26 Nov 2020 23:29:57 -0800 (PST) Received: from localhost ([::1]:49422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiYCZ-0003ks-8D for importer@patchew.org; Fri, 27 Nov 2020 02:29:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1y-0002Uk-HQ; Fri, 27 Nov 2020 02:18:58 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2978) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiY1t-0007js-Ah; Fri, 27 Nov 2020 02:18:58 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cj5ZW2p5HzhjF1; Fri, 27 Nov 2020 15:18:27 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 27 Nov 2020 15:18:43 +0800 From: Gan Qixin To: , Subject: [PATCH 7/7] musicpal: Use ptimer_free() in the finalize function to avoid memleaks Date: Fri, 27 Nov 2020 15:18:03 +0800 Message-ID: <20201127071803.2479462-8-ganqixin@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20201127071803.2479462-1-ganqixin@huawei.com> References: <20201127071803.2479462-1-ganqixin@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=ganqixin@huawei.com; helo=szxga05-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Jan Kiszka , Gan Qixin , Euler Robot , kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When running device-introspect-test, a memory leak occurred in the mv88w861= 8_pit_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 192 byte(s) in 4 object(s) allocated from: #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0) #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800) #2 0xaaabf555db84 in timer_new_full /qemu/include/qemu/timer.h:523 #3 0xaaabf555db84 in timer_new /qemu/include/qemu/timer.h:544 #4 0xaaabf555db84 in timer_new_ns /qemu/include/qemu/timer.h:562 #5 0xaaabf555db84 in ptimer_init /qemu/hw/core/ptimer.c:433 #6 0xaaabf5bb2290 in mv88w8618_timer_init /qemu/hw/arm/musicpal.c:862 #7 0xaaabf5bb2290 in mv88w8618_pit_init /qemu/hw/arm/musicpal.c:954 #8 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #9 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729 #10 0xaaabf6375e40 in qmp_device_list_properties /qemu/qom/qom-qmp-cmds= .c:153 #11 0xaaabf5a95540 in qdev_device_help /qemu/softmmu/qdev-monitor.c:283 #12 0xaaabf5a96940 in qmp_device_add /qemu/softmmu/qdev-monitor.c:801 Reported-by: Euler Robot Signed-off-by: Gan Qixin --- Cc: Jan Kiszka --- hw/arm/musicpal.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index 458b1cbeb7..0e77082e52 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -959,6 +959,17 @@ static void mv88w8618_pit_init(Object *obj) sysbus_init_mmio(dev, &s->iomem); } =20 +static void mv88w8618_pit_finalize(Object *obj) +{ + SysBusDevice *dev =3D SYS_BUS_DEVICE(obj); + mv88w8618_pit_state *s =3D MV88W8618_PIT(dev); + int i; + + for (i =3D 0; i < 4; i++) { + ptimer_free(s->timer[i].ptimer); + } +} + static const VMStateDescription mv88w8618_timer_vmsd =3D { .name =3D "timer", .version_id =3D 1, @@ -990,11 +1001,12 @@ static void mv88w8618_pit_class_init(ObjectClass *kl= ass, void *data) } =20 static const TypeInfo mv88w8618_pit_info =3D { - .name =3D TYPE_MV88W8618_PIT, - .parent =3D TYPE_SYS_BUS_DEVICE, - .instance_size =3D sizeof(mv88w8618_pit_state), - .instance_init =3D mv88w8618_pit_init, - .class_init =3D mv88w8618_pit_class_init, + .name =3D TYPE_MV88W8618_PIT, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(mv88w8618_pit_state), + .instance_init =3D mv88w8618_pit_init, + .instance_finalize =3D mv88w8618_pit_finalize, + .class_init =3D mv88w8618_pit_class_init, }; =20 /* Flash config register offsets */ --=20 2.23.0