[PATCH mptcp-next v3 1/3] selftests: mptcp: connect: add local variable rndh

Geliang Tang posted 3 patches 1 year, 11 months ago
There is a newer version of this series
[PATCH mptcp-next v3 1/3] selftests: mptcp: connect: add local variable rndh
Posted by Geliang Tang 1 year, 11 months ago
From: Geliang Tang <tanggeliang@kylinos.cn>

This patch adds a local variable rndh in do_transfer(), setting it with
${connector_ns:4}, not the global variable rndh. The global one is hidden
in the next commit.

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
 tools/testing/selftests/net/mptcp/mptcp_connect.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
index ea52110c3fbc..b609649311f6 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
@@ -348,6 +348,7 @@ do_transfer()
 
 	if $capture; then
 		local capuser
+		local rndh="${connector_ns:4}"
 		if [ -z $SUDO_USER ] ; then
 			capuser=""
 		else
-- 
2.40.1
Re: [PATCH mptcp-next v3 1/3] selftests: mptcp: connect: add local variable rndh
Posted by Matthieu Baerts 1 year, 11 months ago
Hi Geliang,

On 21/02/2024 8:06 am, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> This patch adds a local variable rndh in do_transfer(), setting it with
> ${connector_ns:4}, not the global variable rndh. The global one is hidden
> in the next commit.

Do you not need to do the same in simult_flows.sh?

If it is just these two modifications, and because you have other
behaviour changes in patch 2/3, maybe easier to squash that in patch 2/3
and add another note in the commit message?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.