From: Geliang Tang <tanggeliang@kylinos.cn>

v4:
 - address Matt's comments in v3 except
 - keep #1, #3 as separate patches, not squash them into #2, to keep #2
   clean.

v3:
 - patch #2, drop this line in mptcp_lib_ns_exit():
        rm -f /tmp/"$netns".{nstat,out}

Geliang Tang (4):
  selftests: mptcp: add local variables rndh
  selftests: mptcp: add mptcp_lib_ns_init/exit helpers
  selftests: mptcp: more operations in ns_init/exit
  selftests: mptcp: add mptcp_lib_events helper

 tools/testing/selftests/net/mptcp/diag.sh     |  9 ++---
 .../selftests/net/mptcp/mptcp_connect.sh      | 28 +++++--------
 .../testing/selftests/net/mptcp/mptcp_join.sh | 26 ++----------
 .../testing/selftests/net/mptcp/mptcp_lib.sh  | 40 +++++++++++++++++++
 .../selftests/net/mptcp/mptcp_sockopt.sh      | 22 +++-------
 .../testing/selftests/net/mptcp/pm_netlink.sh | 10 ++---
 .../selftests/net/mptcp/simult_flows.sh       | 21 +++-------
 .../selftests/net/mptcp/userspace_pm.sh       | 29 +++-----------
 8 files changed, 77 insertions(+), 108 deletions(-)

-- 
2.40.1

Hi Geliang,

On 22/02/2024 4:40 am, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v4:
>  - address Matt's comments in v3 except
>  - keep #1, #3 as separate patches, not squash them into #2, to keep #2
>    clean.

Thank you for the v4, it looks better to me!

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

I have just one comment for patch 2/4, but it is fine, I think. (I will
also add {} around the new 'netns' variable in mptcp_lib.sh when
applying the patch.)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Geliang,

On 22/02/2024 11:30 am, Matthieu Baerts wrote:
> Hi Geliang,
> 
> On 22/02/2024 4:40 am, Geliang Tang wrote:
>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>
>> v4:
>>  - address Matt's comments in v3 except
>>  - keep #1, #3 as separate patches, not squash them into #2, to keep #2
>>    clean.
> 
> Thank you for the v4, it looks better to me!
> 
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> I have just one comment for patch 2/4, but it is fine, I think. (I will
> also add {} around the new 'netns' variable in mptcp_lib.sh when
> applying the patch.)

I just applied the new patches with the suggested modifications.

New patches for t/upstream:
- b19e35a9c85b: selftests: mptcp: add local variables rndh
- 1e458efc9900: selftests: mptcp: add mptcp_lib_ns_init/exit helpers
- dcb564917e5b: selftests: mptcp: more operations in ns_init/exit
- d734b17e00dd: selftests: mptcp: add mptcp_lib_events helper
- Results: a542d2d60003..80a8f9458231 (export)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.