[v3] add helpers and vars in mptcp_lib.sh, part 2

[PATCH mptcp-next v3 0/3] add helpers and vars in mptcp_lib.sh, part 2

Geliang Tang posted 3 patches 2 months, 1 week ago

Diff against v1 v2 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1708499011.git.tanggeliang@kylinos.cn

There is a newer version of this series

tools/testing/selftests/net/mptcp/diag.sh     |  9 +--
.../selftests/net/mptcp/mptcp_connect.sh      | 25 +++---
.../testing/selftests/net/mptcp/mptcp_join.sh | 27 ++-----
.../testing/selftests/net/mptcp/mptcp_lib.sh  | 78 +++++++++++++++++++
.../selftests/net/mptcp/mptcp_sockopt.sh      | 16 ++--
.../testing/selftests/net/mptcp/pm_netlink.sh |  9 +--
.../selftests/net/mptcp/simult_flows.sh       | 16 ++--
.../selftests/net/mptcp/userspace_pm.sh       | 42 +++-------
8 files changed, 122 insertions(+), 100 deletions(-)

Expand all Fold all

[PATCH mptcp-next v3 0/3] add helpers and vars in mptcp_lib.sh, part 2

Posted by Geliang Tang 2 months, 1 week ago

From: Geliang Tang <tanggeliang@kylinos.cn>

v3:
 - patch #2, drop this line in mptcp_lib_ns_exit():
	rm -f /tmp/"$netns".{nstat,out}

Depends on:
 - dump for userspace pm, v14

Geliang Tang (3):
  selftests: mptcp: connect: add local variable rndh
  selftests: mptcp: add mptcp_lib_ns_* helpers
  selftests: mptcp: add mptcp_lib_evts_* helpers

 tools/testing/selftests/net/mptcp/diag.sh     |  9 +--
 .../selftests/net/mptcp/mptcp_connect.sh      | 25 +++---
 .../testing/selftests/net/mptcp/mptcp_join.sh | 27 ++-----
 .../testing/selftests/net/mptcp/mptcp_lib.sh  | 78 +++++++++++++++++++
 .../selftests/net/mptcp/mptcp_sockopt.sh      | 16 ++--
 .../testing/selftests/net/mptcp/pm_netlink.sh |  9 +--
 .../selftests/net/mptcp/simult_flows.sh       | 16 ++--
 .../selftests/net/mptcp/userspace_pm.sh       | 42 +++-------
 8 files changed, 122 insertions(+), 100 deletions(-)

-- 
2.40.1

Re: [PATCH mptcp-next v3 0/3] add helpers and vars in mptcp_lib.sh, part 2

Posted by Matthieu Baerts 2 months, 1 week ago

Hi Geliang,

On 21/02/2024 8:06 am, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v3:
>  - patch #2, drop this line in mptcp_lib_ns_exit():
> 	rm -f /tmp/"$netns".{nstat,out}

Thank you for this new version. Please see my individual comments.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.