Hi Geliang,
On 04/05/2023 12:20, Geliang Tang wrote:
> v11:
> - #1-#5 part 1, address Matt's comments in v10.
> - #6-#9 part 2, update pm mptcp_info
> - #10-#12 part 3, some cleanups.
Thank you for the v11!
I just did a review of the 6 first patches that would land in -net. I
just have some last questions regarding the 4th patch (good you did the
squash, it was easier for me to see some issues) and the 6th one.
For the modifications on the selftests side, I didn't look into details
yet but it looks like the CI is complaining about that (maybe with a
debug kconfig, it is way slower, we do need to use 'wait_xxx()'
functions instead of 'sleep'?). I suggest to look at that when the first
6 patches are merged because this second part is for net-next anyway. WDYT?
Just briefly regarding this 2nd part: it is a good idea to get code out
of "do_transfer". It might be good to create helpers to keep stuff clear
when we declare the tests, with brief instructions, e.g.
set_userspace_pm $ns1
run_tests (...)
userspace_pm_send_add_addr (...)
wait_for_addr (...)
chk_add_nr (...)
userspace_pm_send_rm_addr (...)
wait_rm_addr (...)
chk_rm_nr (...)
kill_(...)
If you see the idea.
Also, I really should send all the modifications I have related to my
"selftests: mptcp: skip tests when features are not supported" as my
patches are for -net and they modify quite a bit mptcp_join.sh tests. I
will try to send them tomorrow.
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net