[PATCH mptcp-next v11 00/12] update userspace pm mptcp_info fields

Geliang Tang posted 12 patches 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1683195386.git.geliang.tang@suse.com
Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, Kishen Maloor <kishen.maloor@intel.com>, Geliang Tang <geliang.tang@suse.com>, Florian Westphal <fw@strlen.de>
There is a newer version of this series
net/mptcp/pm.c                                |  21 +-
net/mptcp/pm_netlink.c                        |  34 +-
net/mptcp/pm_userspace.c                      |  60 +-
net/mptcp/protocol.h                          |   5 +-
.../testing/selftests/net/mptcp/mptcp_join.sh | 629 ++++++++++--------
5 files changed, 473 insertions(+), 276 deletions(-)
[PATCH mptcp-next v11 00/12] update userspace pm mptcp_info fields
Posted by Geliang Tang 1 year, 1 month ago
v11:
 - #1-#5 part 1, address Matt's comments in v10.
 - #6-#9 part 2, update pm mptcp_info
 - #10-#12 part 3, some cleanups.

v10:
 - fix userspace_pm.sh errors reported by CI.
 - fix the bug in mptcp_pm_remove_addrs in patch 1.
 - drop msk->pm.subflow == 1 in mptcp_userspace_pm_delete_local_addr in
   patch 3.
 - exchange the order of "pm_nl_ctl rem" and "pm_nl_ctl dsf" in patch 2
   and 6.
 - update the commit logs.

v9:
 - address Matt's commets in v8.

v8:
 - address Matt's comments.
 - split into two series, pt 2 will send later.

v7:
 - fix userspace_pm.sh errors reported by CI.
 - only remove addrs in mptcp_nl_cmd_remove().

v6:
 - send a RM ADDR from userspace.

v5:
 - fix a memleak error reported by CI.
 - add more delay for userspace pm tests.

v4:
 - add more patches
 - add selftests

v3:
 - update local_addr_used and add_addr_signaled

v2:
 - hold pm locks

Geliang Tang (12):
  mptcp: only send RM_ADDR in nl_cmd_remove
  selftests: mptcp: update userspace pm addr tests
  mptcp: export remove_anno_list_by_saddr
  mptcp: add addr into userspace pm list
  selftests: mptcp: update userspace pm subflow tests
  mptcp: update userspace pm infos
  selftests: mptcp: do userspace tests out of transfer
  selftests: mptcp: check subflows infos
  selftests: mptcp: check add_addr infos
  mptcp: pass addr to mptcp_pm_alloc_anno_list
  selftests: mptcp: pass fastclose to sflags
  selftests: mptcp: do endpoint manipulation out of transfer

 net/mptcp/pm.c                                |  21 +-
 net/mptcp/pm_netlink.c                        |  34 +-
 net/mptcp/pm_userspace.c                      |  60 +-
 net/mptcp/protocol.h                          |   5 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 629 ++++++++++--------
 5 files changed, 473 insertions(+), 276 deletions(-)

-- 
2.35.3
Re: [PATCH mptcp-next v11 00/12] update userspace pm mptcp_info fields
Posted by Matthieu Baerts 1 year, 1 month ago
Hi Geliang,

On 04/05/2023 12:20, Geliang Tang wrote:
> v11:
>  - #1-#5 part 1, address Matt's comments in v10.
>  - #6-#9 part 2, update pm mptcp_info
>  - #10-#12 part 3, some cleanups.

Thank you for the v11!

I just did a review of the 6 first patches that would land in -net. I
just have some last questions regarding the 4th patch (good you did the
squash, it was easier for me to see some issues) and the 6th one.

For the modifications on the selftests side, I didn't look into details
yet but it looks like the CI is complaining about that (maybe with a
debug kconfig, it is way slower, we do need to use 'wait_xxx()'
functions instead of 'sleep'?). I suggest to look at that when the first
6 patches are merged because this second part is for net-next anyway. WDYT?

Just briefly regarding this 2nd part: it is a good idea to get code out
of "do_transfer". It might be good to create helpers to keep stuff clear
when we declare the tests, with brief instructions, e.g.

  set_userspace_pm $ns1
  run_tests (...)
  userspace_pm_send_add_addr (...)
  wait_for_addr (...)
  chk_add_nr (...)
  userspace_pm_send_rm_addr (...)
  wait_rm_addr (...)
  chk_rm_nr (...)
  kill_(...)

If you see the idea.

Also, I really should send all the modifications I have related to my
"selftests: mptcp: skip tests when features are not supported" as my
patches are for -net and they modify quite a bit mptcp_join.sh tests. I
will try to send them tomorrow.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net