[PATCH 07/48] qemu: Assume QEMU_CAPS_VSERPORT_CHANGE

Michal Privoznik posted 48 patches 3 years, 3 months ago
[PATCH 07/48] qemu: Assume QEMU_CAPS_VSERPORT_CHANGE
Posted by Michal Privoznik 3 years, 3 months ago
Introduced in QEMU's commit of v2.1.0-rc0~18^2~2 the
VSERPORT_CHANGE event is always available for all QEMU versions
we support (4.2.0, currently). Therefore, we can assume the
capability is always set and thus doesn't need to be checked for.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_process.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index e7f92228f5..7d112f5bae 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -214,8 +214,7 @@ qemuConnectAgent(virQEMUDriver *driver, virDomainObj *vm)
     if (priv->agent)
         return 0;
 
-    if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VSERPORT_CHANGE) &&
-        config->state != VIR_DOMAIN_CHR_DEVICE_STATE_CONNECTED) {
+    if (config->state != VIR_DOMAIN_CHR_DEVICE_STATE_CONNECTED) {
         VIR_DEBUG("Deferring connecting to guest agent");
         return 0;
     }
@@ -230,7 +229,7 @@ qemuConnectAgent(virQEMUDriver *driver, virDomainObj *vm)
                           config->source,
                           virEventThreadGetContext(priv->eventThread),
                           &agentCallbacks,
-                          virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VSERPORT_CHANGE));
+                          true);
 
     if (!virDomainObjIsActive(vm)) {
         qemuAgentClose(agent);
-- 
2.37.4
Re: [PATCH 07/48] qemu: Assume QEMU_CAPS_VSERPORT_CHANGE
Posted by Ján Tomko 3 years, 3 months ago
On a Tuesday in 2022, Michal Privoznik wrote:
>Introduced in QEMU's commit of v2.1.0-rc0~18^2~2 the
>VSERPORT_CHANGE event is always available for all QEMU versions
>we support (4.2.0, currently). Therefore, we can assume the
>capability is always set and thus doesn't need to be checked for.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> src/qemu/qemu_process.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano