From nobody Sat Feb 7 08:13:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1667896266; cv=none; d=zohomail.com; s=zohoarc; b=UhNrFc2I/3Mq0egg2iVOPpi5UEKxPm4Vj/M1inPXLVtY1SKitQfoEbVhrxw2BJgqdXTbL7+ZvmFcJuRp1YI6aAAVwyIpbX3wLkBjohnknPcuy2pZklO1IFsVM7/wYgr1maWN/qY67S/H3gCvCdCoNsRqyYFfOdJYIovqkBGyYBg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667896266; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fWua9EeqZu5I4aPA6dAvhe8HSvlF2+ic903wwkHHXCw=; b=TGHGoRoqS0P1KF+1DU1JyVDnKJrK8fEIQyMDIK2a4+Ob4/3I7bpuZujoufYlVFSz10S5bDX4B0iqXwEpWE0WYpjwlDBg9//ixpz1cb6OS2E2WT0ty/LTA4xQXkdEku9hGLQmpNaGVGpm93NpXG1CNNnsyZxjqaadF0JvSJTKQro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1667896266305361.86671251175767; Tue, 8 Nov 2022 00:31:06 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-107-bB3Cwrz0OeSmRkVa9TsyiQ-1; Tue, 08 Nov 2022 03:30:08 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3DEFD3C0F68A; Tue, 8 Nov 2022 08:29:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C4264B3FC6; Tue, 8 Nov 2022 08:29:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id F18F91946594; Tue, 8 Nov 2022 08:29:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3A6D819465B3 for ; Tue, 8 Nov 2022 08:29:57 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2005A4EA47; Tue, 8 Nov 2022 08:29:57 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id B772D4EA4B for ; Tue, 8 Nov 2022 08:29:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667896265; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fWua9EeqZu5I4aPA6dAvhe8HSvlF2+ic903wwkHHXCw=; b=Mvc+qvATbyJ78soor57EhzIvEyP5WuuAYvatdvTS43H79qoTmplE9bBkiVAVH9eZCh4ttD kg+3ixV1r11oB6LAAAuG/1z6RX7zgVXSjrwOyyn0x6twa3dOeFVCtVn03h06v2+uA3lHBS UBceY/PY6BJFCaJr2fAj3l/hrOIhGto= X-MC-Unique: bB3Cwrz0OeSmRkVa9TsyiQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 07/48] qemu: Assume QEMU_CAPS_VSERPORT_CHANGE Date: Tue, 8 Nov 2022 09:29:09 +0100 Message-Id: <31ea2b4b7c018075f162b6e31c8a89e78611e09c.1667896101.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1667896267059100006 Content-Type: text/plain; charset="utf-8"; x-default="true" Introduced in QEMU's commit of v2.1.0-rc0~18^2~2 the VSERPORT_CHANGE event is always available for all QEMU versions we support (4.2.0, currently). Therefore, we can assume the capability is always set and thus doesn't need to be checked for. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_process.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index e7f92228f5..7d112f5bae 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -214,8 +214,7 @@ qemuConnectAgent(virQEMUDriver *driver, virDomainObj *v= m) if (priv->agent) return 0; =20 - if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VSERPORT_CHANGE) && - config->state !=3D VIR_DOMAIN_CHR_DEVICE_STATE_CONNECTED) { + if (config->state !=3D VIR_DOMAIN_CHR_DEVICE_STATE_CONNECTED) { VIR_DEBUG("Deferring connecting to guest agent"); return 0; } @@ -230,7 +229,7 @@ qemuConnectAgent(virQEMUDriver *driver, virDomainObj *v= m) config->source, virEventThreadGetContext(priv->eventThread), &agentCallbacks, - virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VSERPOR= T_CHANGE)); + true); =20 if (!virDomainObjIsActive(vm)) { qemuAgentClose(agent); --=20 2.37.4