[PATCH 00/48] Retire more capabilities

Michal Privoznik posted 48 patches 3 weeks, 5 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1667896101.git.mprivozn@redhat.com
src/qemu/qemu_agent.c                         |  7 +-
src/qemu/qemu_agent.h                         |  3 +-
src/qemu/qemu_capabilities.c                  | 76 ++++---------------
src/qemu/qemu_capabilities.h                  | 30 ++++----
src/qemu/qemu_command.c                       | 15 +---
src/qemu/qemu_domain.c                        | 10 +--
src/qemu/qemu_driver.c                        | 40 +++-------
src/qemu/qemu_process.c                       |  6 +-
src/qemu/qemu_validate.c                      | 54 -------------
tests/qemuagenttest.c                         | 50 +-----------
.../caps_4.2.0.aarch64.xml                    | 15 ----
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 14 ----
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 15 ----
.../caps_4.2.0.x86_64.xml                     | 15 ----
.../caps_5.0.0.aarch64.xml                    | 15 ----
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 15 ----
.../caps_5.0.0.riscv64.xml                    | 15 ----
.../caps_5.0.0.x86_64.xml                     | 15 ----
.../qemucapabilitiesdata/caps_5.1.0.sparc.xml |  9 ---
.../caps_5.1.0.x86_64.xml                     | 15 ----
.../caps_5.2.0.aarch64.xml                    | 15 ----
.../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 15 ----
.../caps_5.2.0.riscv64.xml                    | 15 ----
.../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 15 ----
.../caps_5.2.0.x86_64.xml                     | 15 ----
.../caps_6.0.0.aarch64.xml                    | 15 ----
.../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 15 ----
.../caps_6.0.0.x86_64.xml                     | 15 ----
.../caps_6.1.0.x86_64.xml                     | 15 ----
.../caps_6.2.0.aarch64.xml                    | 15 ----
.../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 15 ----
.../caps_6.2.0.x86_64.xml                     | 15 ----
.../caps_7.0.0.aarch64.xml                    | 15 ----
.../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 15 ----
.../caps_7.0.0.x86_64.xml                     | 15 ----
.../qemucapabilitiesdata/caps_7.1.0.ppc64.xml | 15 ----
.../caps_7.1.0.x86_64.xml                     | 15 ----
.../caps_7.2.0.x86_64.xml                     | 15 ----
tests/qemumonitortestutils.c                  |  3 +-
tests/qemuxml2argvdata/controller-order.args  |  2 +-
tests/qemuxml2argvdata/cpu-numa-disjoint.err  |  1 -
.../fd-memory-numa-topology2.args             |  2 +-
.../fd-memory-numa-topology2.xml              |  2 +-
.../fd-memory-numa-topology3.args             |  2 +-
.../fd-memory-numa-topology3.xml              |  2 +-
tests/qemuxml2argvdata/net-virtio-teaming.err |  1 -
tests/qemuxml2argvdata/numatune-memnode.err   |  1 -
.../video-device-pciaddr-default.args         |  2 +-
.../video-qxl-device-vgamem.args              |  2 +-
tests/qemuxml2argvdata/video-qxl-device.args  |  2 +-
.../video-qxl-sec-device-vgamem.args          |  2 +-
.../video-qxl-sec-device.args                 |  2 +-
.../video-vga-device-vgamem.args              |  2 +-
tests/qemuxml2argvdata/video-vga-device.args  |  2 +-
.../video-virtio-gpu-device.args              |  2 +-
.../video-virtio-gpu-sdl-gl.args              |  2 +-
.../video-virtio-gpu-spice-gl.args            |  2 +-
.../video-virtio-gpu-virgl.args               |  2 +-
tests/qemuxml2argvdata/video-virtio-vga.args  |  2 +-
tests/qemuxml2argvtest.c                      | 31 +++-----
tests/qemuxml2xmltest.c                       | 21 ++---
61 files changed, 90 insertions(+), 706 deletions(-)
delete mode 100644 tests/qemuxml2argvdata/cpu-numa-disjoint.err
delete mode 100644 tests/qemuxml2argvdata/net-virtio-teaming.err
delete mode 100644 tests/qemuxml2argvdata/numatune-memnode.err
[PATCH 00/48] Retire more capabilities
Posted by Michal Privoznik 3 weeks, 5 days ago
Chop chop. More capabilities can be retired.

https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/688345136

Michal Prívozník (48):
  qemu: Drop misleading comment for
    qemuDomainQueryWakeupSuspendSupport()
  qemu: Acquire QUERY job in qemuDomainQueryWakeupSuspendSupport()
  tests: Make qemuAgent single sync
  qemu: Assume QEMU_CAPS_NUMA
  qemu_capabilities: Stop detecting QEMU_CAPS_NUMA
  qemu: Retire QEMU_CAPS_NUMA
  qemu: Assume QEMU_CAPS_VSERPORT_CHANGE
  qemu_agent: Drop @singleSync from _qemuAgent
  qemu_capabilities: Stop detecting QEMU_CAPS_VSERPORT_CHANGE
  qemu: Retire QEMU_CAPS_VSERPORT_CHANGE
  qemu: Assume QEMU_CAPS_DUMP_COMPLETED
  qemu_capabilities: Stop detecting QEMU_CAPS_DUMP_COMPLETED
  qemu: Retire QEMU_CAPS_DUMP_COMPLETED
  qemu: Assume QEMU_CAPS_QOM_LIST_PROPERTIES
  qemu_capabilities: Stop detecting QEMU_CAPS_QOM_LIST_PROPERTIES
  qemu: Retire QEMU_CAPS_QOM_LIST_PROPERTIES
  qemu: Assume QEMU_CAPS_QUERY_CURRENT_MACHINE
  qemu_capabilities: Stop detecting QEMU_CAPS_QUERY_CURRENT_MACHINE
  qemu: Retire QEMU_CAPS_QUERY_CURRENT_MACHINE
  qemu_capabilities: Stop detecting QEMU_CAPS_BITMAP_MERGE
  qemu: Retire QEMU_CAPS_BITMAP_MERGE
  qemu: Assume QEMU_CAPS_QUERY_DISPLAY_OPTIONS
  qemu_capabilities: Stop detecting QEMU_CAPS_QUERY_DISPLAY_OPTIONS
  qemu: Retire QEMU_CAPS_QUERY_DISPLAY_OPTIONS
  qemu: Assume QEMU_CAPS_VIRTIO_NET_RX_QUEUE_SIZE
  qemu_capabilities: Stop detecting QEMU_CAPS_VIRTIO_NET_RX_QUEUE_SIZE
  qemu: Retire QEMU_CAPS_VIRTIO_NET_RX_QUEUE_SIZE
  qemu: Assume QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE
  qemu_capabilities: Stop detecting QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE
  qemu: Retire QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE
  qemu: Assume QEMU_CAPS_VIRTIO_NET_HOST_MTU
  qemu_capabilities: Stop detecting QEMU_CAPS_VIRTIO_NET_HOST_MTU
  qemu: Retire QEMU_CAPS_VIRTIO_NET_HOST_MTU
  qemu: Assume QEMU_CAPS_VIRTIO_NET_FAILOVER
  qemu_capabilities: Stop detecting QEMU_CAPS_VIRTIO_NET_FAILOVER
  qemu: Retire QEMU_CAPS_VIRTIO_NET_FAILOVER
  qemu: Assume QEMU_CAPS_BLOCKIO
  qemu_capabilities: Stop detecting QEMU_CAPS_BLOCKIO
  qemu: Retire QEMU_CAPS_BLOCKIO
  qemu: Assume QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES
  qemu_capabilities: Stop detecting QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE
  qemu: Retire QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES
  qemu: Assume QEMU_CAPS_DISK_SHARE_RW
  qemu_capabilities: Stop detecting QEMU_CAPS_DISK_SHARE_RW
  qemu: Retire QEMU_CAPS_DISK_SHARE_RW
  qemu: Assume QEMU_CAPS_DISK_WRITE_CACHE
  qemu_capabilities: Stop detecting QEMU_CAPS_DISK_WRITE_CACHE
  qemu: Retire QEMU_CAPS_DISK_WRITE_CACHE

 src/qemu/qemu_agent.c                         |  7 +-
 src/qemu/qemu_agent.h                         |  3 +-
 src/qemu/qemu_capabilities.c                  | 76 ++++---------------
 src/qemu/qemu_capabilities.h                  | 30 ++++----
 src/qemu/qemu_command.c                       | 15 +---
 src/qemu/qemu_domain.c                        | 10 +--
 src/qemu/qemu_driver.c                        | 40 +++-------
 src/qemu/qemu_process.c                       |  6 +-
 src/qemu/qemu_validate.c                      | 54 -------------
 tests/qemuagenttest.c                         | 50 +-----------
 .../caps_4.2.0.aarch64.xml                    | 15 ----
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 14 ----
 .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 15 ----
 .../caps_4.2.0.x86_64.xml                     | 15 ----
 .../caps_5.0.0.aarch64.xml                    | 15 ----
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 15 ----
 .../caps_5.0.0.riscv64.xml                    | 15 ----
 .../caps_5.0.0.x86_64.xml                     | 15 ----
 .../qemucapabilitiesdata/caps_5.1.0.sparc.xml |  9 ---
 .../caps_5.1.0.x86_64.xml                     | 15 ----
 .../caps_5.2.0.aarch64.xml                    | 15 ----
 .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 15 ----
 .../caps_5.2.0.riscv64.xml                    | 15 ----
 .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 15 ----
 .../caps_5.2.0.x86_64.xml                     | 15 ----
 .../caps_6.0.0.aarch64.xml                    | 15 ----
 .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 15 ----
 .../caps_6.0.0.x86_64.xml                     | 15 ----
 .../caps_6.1.0.x86_64.xml                     | 15 ----
 .../caps_6.2.0.aarch64.xml                    | 15 ----
 .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 15 ----
 .../caps_6.2.0.x86_64.xml                     | 15 ----
 .../caps_7.0.0.aarch64.xml                    | 15 ----
 .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 15 ----
 .../caps_7.0.0.x86_64.xml                     | 15 ----
 .../qemucapabilitiesdata/caps_7.1.0.ppc64.xml | 15 ----
 .../caps_7.1.0.x86_64.xml                     | 15 ----
 .../caps_7.2.0.x86_64.xml                     | 15 ----
 tests/qemumonitortestutils.c                  |  3 +-
 tests/qemuxml2argvdata/controller-order.args  |  2 +-
 tests/qemuxml2argvdata/cpu-numa-disjoint.err  |  1 -
 .../fd-memory-numa-topology2.args             |  2 +-
 .../fd-memory-numa-topology2.xml              |  2 +-
 .../fd-memory-numa-topology3.args             |  2 +-
 .../fd-memory-numa-topology3.xml              |  2 +-
 tests/qemuxml2argvdata/net-virtio-teaming.err |  1 -
 tests/qemuxml2argvdata/numatune-memnode.err   |  1 -
 .../video-device-pciaddr-default.args         |  2 +-
 .../video-qxl-device-vgamem.args              |  2 +-
 tests/qemuxml2argvdata/video-qxl-device.args  |  2 +-
 .../video-qxl-sec-device-vgamem.args          |  2 +-
 .../video-qxl-sec-device.args                 |  2 +-
 .../video-vga-device-vgamem.args              |  2 +-
 tests/qemuxml2argvdata/video-vga-device.args  |  2 +-
 .../video-virtio-gpu-device.args              |  2 +-
 .../video-virtio-gpu-sdl-gl.args              |  2 +-
 .../video-virtio-gpu-spice-gl.args            |  2 +-
 .../video-virtio-gpu-virgl.args               |  2 +-
 tests/qemuxml2argvdata/video-virtio-vga.args  |  2 +-
 tests/qemuxml2argvtest.c                      | 31 +++-----
 tests/qemuxml2xmltest.c                       | 21 ++---
 61 files changed, 90 insertions(+), 706 deletions(-)
 delete mode 100644 tests/qemuxml2argvdata/cpu-numa-disjoint.err
 delete mode 100644 tests/qemuxml2argvdata/net-virtio-teaming.err
 delete mode 100644 tests/qemuxml2argvdata/numatune-memnode.err

-- 
2.37.4

Re: [PATCH 00/48] Retire more capabilities
Posted by Peter Krempa 3 weeks, 5 days ago
On Tue, Nov 08, 2022 at 09:29:02 +0100, Michal Privoznik wrote:
> Chop chop. More capabilities can be retired.
> 
> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/688345136
> 
> Michal Prívozník (48):

[...]

>   qemu: Drop misleading comment for
>     qemuDomainQueryWakeupSuspendSupport()
>   qemu: Acquire QUERY job in qemuDomainQueryWakeupSuspendSupport()
>   qemu: Assume QEMU_CAPS_NUMA
>   qemu_capabilities: Stop detecting QEMU_CAPS_NUMA
>   qemu: Retire QEMU_CAPS_NUMA
>   qemu: Assume QEMU_CAPS_VSERPORT_CHANGE
>   qemu_capabilities: Stop detecting QEMU_CAPS_VSERPORT_CHANGE
>   qemu: Retire QEMU_CAPS_VSERPORT_CHANGE
>   qemu: Assume QEMU_CAPS_DUMP_COMPLETED
>   qemu_capabilities: Stop detecting QEMU_CAPS_DUMP_COMPLETED
>   qemu: Retire QEMU_CAPS_DUMP_COMPLETED
>   qemu: Assume QEMU_CAPS_QOM_LIST_PROPERTIES
>   qemu_capabilities: Stop detecting QEMU_CAPS_QOM_LIST_PROPERTIES
>   qemu: Retire QEMU_CAPS_QOM_LIST_PROPERTIES
>   qemu: Assume QEMU_CAPS_QUERY_CURRENT_MACHINE
>   qemu_capabilities: Stop detecting QEMU_CAPS_QUERY_CURRENT_MACHINE
>   qemu: Retire QEMU_CAPS_QUERY_CURRENT_MACHINE
>   qemu_capabilities: Stop detecting QEMU_CAPS_BITMAP_MERGE
>   qemu: Retire QEMU_CAPS_BITMAP_MERGE
>   qemu: Assume QEMU_CAPS_QUERY_DISPLAY_OPTIONS
>   qemu_capabilities: Stop detecting QEMU_CAPS_QUERY_DISPLAY_OPTIONS
>   qemu: Retire QEMU_CAPS_QUERY_DISPLAY_OPTIONS
>   qemu: Assume QEMU_CAPS_VIRTIO_NET_RX_QUEUE_SIZE
>   qemu_capabilities: Stop detecting QEMU_CAPS_VIRTIO_NET_RX_QUEUE_SIZE
>   qemu: Retire QEMU_CAPS_VIRTIO_NET_RX_QUEUE_SIZE
>   qemu: Assume QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE
>   qemu_capabilities: Stop detecting QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE
>   qemu: Retire QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE
>   qemu: Assume QEMU_CAPS_VIRTIO_NET_HOST_MTU
>   qemu_capabilities: Stop detecting QEMU_CAPS_VIRTIO_NET_HOST_MTU
>   qemu: Retire QEMU_CAPS_VIRTIO_NET_HOST_MTU
>   qemu: Assume QEMU_CAPS_VIRTIO_NET_FAILOVER
>   qemu_capabilities: Stop detecting QEMU_CAPS_VIRTIO_NET_FAILOVER
>   qemu: Retire QEMU_CAPS_VIRTIO_NET_FAILOVER
>   qemu: Assume QEMU_CAPS_BLOCKIO
>   qemu_capabilities: Stop detecting QEMU_CAPS_BLOCKIO
>   qemu: Retire QEMU_CAPS_BLOCKIO
>   qemu: Assume QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES
>   qemu_capabilities: Stop detecting QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE
>   qemu: Retire QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES
>   qemu: Assume QEMU_CAPS_DISK_SHARE_RW
>   qemu_capabilities: Stop detecting QEMU_CAPS_DISK_SHARE_RW
>   qemu: Retire QEMU_CAPS_DISK_SHARE_RW
>   qemu: Assume QEMU_CAPS_DISK_WRITE_CACHE
>   qemu_capabilities: Stop detecting QEMU_CAPS_DISK_WRITE_CACHE
>   qemu: Retire QEMU_CAPS_DISK_WRITE_CACHE

For the above patches:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

The following two are excluded:

>   tests: Make qemuAgent single sync
>   qemu_agent: Drop @singleSync from _qemuAgent

First one breaks test-suite, second one can't be applied without first one.
Re: [PATCH 00/48] Retire more capabilities
Posted by Peter Krempa 3 weeks, 5 days ago
On Tue, Nov 08, 2022 at 09:59:00 +0100, Peter Krempa wrote:
> On Tue, Nov 08, 2022 at 09:29:02 +0100, Michal Privoznik wrote:
> > Chop chop. More capabilities can be retired.
> > 
> > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/688345136
> > 
> > Michal Prívozník (48):

[...]

> The following two are excluded:
> 
> >   tests: Make qemuAgent single sync
> >   qemu_agent: Drop @singleSync from _qemuAgent

Reviewed-by: Peter Krempa <pkrempa@redhat.com>