[PATCH 11/17] qemuBlockStorageSourceAttachData: remove 'storageNodeNameCopy'

Peter Krempa posted 17 patches 5 years, 5 months ago
[PATCH 11/17] qemuBlockStorageSourceAttachData: remove 'storageNodeNameCopy'
Posted by Peter Krempa 5 years, 5 months ago
This was a hack when we were locally regenerating the nodename so that
it's not leaked. Now that we use proper virStorageSource with
persistence it's no longer required.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_block.c | 1 -
 src/qemu/qemu_block.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 9095986f73..487b0a72e7 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -1557,7 +1557,6 @@ qemuBlockStorageSourceAttachDataFree(qemuBlockStorageSourceAttachDataPtr data)
     virJSONValueFree(data->encryptsecretProps);
     virJSONValueFree(data->tlsProps);
     virJSONValueFree(data->tlsKeySecretProps);
-    VIR_FREE(data->storageNodeNameCopy);
     VIR_FREE(data->tlsAlias);
     VIR_FREE(data->tlsKeySecretAlias);
     VIR_FREE(data->authsecretAlias);
diff --git a/src/qemu/qemu_block.h b/src/qemu/qemu_block.h
index 9aab620947..0701fc18d1 100644
--- a/src/qemu/qemu_block.h
+++ b/src/qemu/qemu_block.h
@@ -85,7 +85,6 @@ struct qemuBlockStorageSourceAttachData {

     virJSONValuePtr storageProps;
     const char *storageNodeName;
-    char *storageNodeNameCopy; /* in some cases we don't have the corresponding storage source */
     bool storageAttached;

     virJSONValuePtr storageSliceProps;
-- 
2.26.2

Re: [PATCH 11/17] qemuBlockStorageSourceAttachData: remove 'storageNodeNameCopy'
Posted by Ján Tomko 5 years, 4 months ago
On a Friday in 2020, Peter Krempa wrote:
>This was a hack when we were locally regenerating the nodename so that
>it's not leaked. Now that we use proper virStorageSource with
>persistence it's no longer required.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_block.c | 1 -
> src/qemu/qemu_block.h | 1 -
> 2 files changed, 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano