From nobody Sun Feb 8 19:56:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599835267; cv=none; d=zohomail.com; s=zohoarc; b=ItDnjQ1qG5a4mkMIWhjCRmYLp8w9riDrt/iCyLKTf7PLbxFFqIPxkbQZcE+ChoDA+vlSbij1+brSeQro/32ERH4QCEW0JLt7ogCuLHJec+QCKGf45q9554oA7KnhYSvGKhHH4Z4pGjTWclT7rn5wWpfL5vflOKJ7+V77Ez5uMhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599835267; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tifONuuj0AINC2BmDc8JGr4SycotJAT8XkbSYHvtra8=; b=InvK2/G3Gh0dWcCT2KwXHG/hOzriNaIq5VCCot7OnxwWgKl2PqPenNi08aBNnyU8i3qTZeHp1jvjrDqHkrjh44k/DhAQiVIEvhdb4tPazNcxeJLo+LvGIzLgs7oDqKa0mUJujkFZg/2+kiNmXTnH19Uu7GIWMF32nMwKrJ8YIcc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1599835267129220.8355969020471; Fri, 11 Sep 2020 07:41:07 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-58L_JNW1ORKhShMvkHyQyA-1; Fri, 11 Sep 2020 10:39:51 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF41856ADE; Fri, 11 Sep 2020 14:39:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A03025C1BD; Fri, 11 Sep 2020 14:39:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6EB9392311; Fri, 11 Sep 2020 14:39:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08BEbtth002421 for ; Fri, 11 Sep 2020 10:37:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id 407238FCA3; Fri, 11 Sep 2020 14:37:55 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.92]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA59C8FCA1 for ; Fri, 11 Sep 2020 14:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599835263; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tifONuuj0AINC2BmDc8JGr4SycotJAT8XkbSYHvtra8=; b=X6ABm6uqeARVul94pRM5V+obVUSY9/ZSINNRTh30wKaXKUY48fPJziBL+qhcMD8S5tgmuL VlivAezuUMZkgSulgWgIzhlsEbp+jz75E2hkAeeuJfSgaKMtCGFZTdPeVs2HbkO5nZyvXU qxTg4iUHuLX+GEA/ZiblAEEKCunY484= X-MC-Unique: 58L_JNW1ORKhShMvkHyQyA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 11/17] qemuBlockStorageSourceAttachData: remove 'storageNodeNameCopy' Date: Fri, 11 Sep 2020 16:37:29 +0200 Message-Id: <36299dababa7e780dbb23dba059aa8f0b40bd9e0.1599834862.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" This was a hack when we were locally regenerating the nodename so that it's not leaked. Now that we use proper virStorageSource with persistence it's no longer required. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_block.c | 1 - src/qemu/qemu_block.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 9095986f73..487b0a72e7 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -1557,7 +1557,6 @@ qemuBlockStorageSourceAttachDataFree(qemuBlockStorage= SourceAttachDataPtr data) virJSONValueFree(data->encryptsecretProps); virJSONValueFree(data->tlsProps); virJSONValueFree(data->tlsKeySecretProps); - VIR_FREE(data->storageNodeNameCopy); VIR_FREE(data->tlsAlias); VIR_FREE(data->tlsKeySecretAlias); VIR_FREE(data->authsecretAlias); diff --git a/src/qemu/qemu_block.h b/src/qemu/qemu_block.h index 9aab620947..0701fc18d1 100644 --- a/src/qemu/qemu_block.h +++ b/src/qemu/qemu_block.h @@ -85,7 +85,6 @@ struct qemuBlockStorageSourceAttachData { virJSONValuePtr storageProps; const char *storageNodeName; - char *storageNodeNameCopy; /* in some cases we don't have the correspo= nding storage source */ bool storageAttached; virJSONValuePtr storageSliceProps; --=20 2.26.2