[PATCH 00/17] qemu: Fix startup of VM with SCSI hostdev with long user-provided alias

Peter Krempa posted 17 patches 2 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1599834862.git.pkrempa@redhat.com
build-aux/check-spacing.pl                    |  36 ----
docs/coding-style.rst                         |   8 +-
src/conf/domain_conf.c                        | 170 ++++++++---------
src/conf/domain_conf.h                        |   1 +
src/qemu/qemu_block.c                         |   1 -
src/qemu/qemu_block.h                         |   1 -
src/qemu/qemu_command.c                       |  74 +++++---
src/qemu/qemu_domain.c                        | 176 ++++++++++++------
src/qemu/qemu_domain.h                        |   8 +-
src/qemu/qemu_hotplug.c                       |   2 +-
src/qemu/qemu_process.c                       |  21 +++
tests/qemustatusxml2xmldata/modern-in.xml     |   1 +
...-secinfo-upgrade-in.xml => upgrade-in.xml} |   9 +
...ecinfo-upgrade-out.xml => upgrade-out.xml} |  20 ++
.../hostdev-scsi-lsi.x86_64-latest.args       |  38 ++--
...hostdev-scsi-virtio-scsi.x86_64-2.8.0.args |   5 +
...hostdev-scsi-virtio-scsi.x86_64-4.1.0.args |   5 +
...ostdev-scsi-virtio-scsi.x86_64-latest.args |  36 ++--
.../hostdev-scsi-virtio-scsi.xml              |   8 +
.../hostdev-scsi-virtio-scsi.xml              |   8 +
tests/qemuxml2xmltest.c                       |   2 +-
21 files changed, 370 insertions(+), 260 deletions(-)
rename tests/qemustatusxml2xmldata/{disk-secinfo-upgrade-in.xml => upgrade-in.xml} (98%)
rename tests/qemustatusxml2xmldata/{disk-secinfo-upgrade-out.xml => upgrade-out.xml} (96%)

[PATCH 00/17] qemu: Fix startup of VM with SCSI hostdev with long user-provided alias

Posted by Peter Krempa 2 weeks ago
Device alias was used to generate the backend nodename. This doesn't
work well if somebody specifies a very long useralias since qemu limits
nodename to 32 bytes. Stop basing the nodename on the alias.

Peter Krempa (17):
  virDomainHostdevSubsysSCSIiSCSIClear: Inline contents into only caller
  virDomainStorageNetworkParseHosts: Switch to a more modern XML parsing
    approach
  virDomainHostdevSubsysSCSIHostDefParseXML: Switch to a more modern XML
    parsing approach
  syntax-check: Don't forbid curly braces around single line condition
    body
  qemuxml2argvtest: hostdev-scsi-virtio-scsi: Add hostdev with useralias
  conf: Add virStorageSource member for SCSI host device config data
  tests: qemustatusxml2xmldata: Rename 'disk-secinfo-upgrade' case to
    'upgrade'
  tests: qemustatusxml2xmldata: Add local SCSI hostdev to 'upgrade' case
  qemu: domain: Fill in (i)SCSI backend nodename if it is not present in
    status XML
  qemuBuildHostdevSCSI(A|De)tachPrepare: Use virStorageSource in def for
    SCSI hostdevs
  qemuBlockStorageSourceAttachData: remove 'storageNodeNameCopy'
  qemu: domain: Extract preparation of hostdev specific data to a
    separate function
  qemuDomainSecretHostdevPrepare: remove
  qemuDomainPrepareHostdev: Allocate backend nodenames in the prepare
    function
  qemuDomainPrepareHostdev: base hostdev secret object names on backend
    alias
  qemuDomainPrepareHostdev: Don't base backend nodename on device alias
  qemuxml2argvtest: hostdev-scsi-virtio-scsi: Use longer user-alias for
    SCSI hostdev

 build-aux/check-spacing.pl                    |  36 ----
 docs/coding-style.rst                         |   8 +-
 src/conf/domain_conf.c                        | 170 ++++++++---------
 src/conf/domain_conf.h                        |   1 +
 src/qemu/qemu_block.c                         |   1 -
 src/qemu/qemu_block.h                         |   1 -
 src/qemu/qemu_command.c                       |  74 +++++---
 src/qemu/qemu_domain.c                        | 176 ++++++++++++------
 src/qemu/qemu_domain.h                        |   8 +-
 src/qemu/qemu_hotplug.c                       |   2 +-
 src/qemu/qemu_process.c                       |  21 +++
 tests/qemustatusxml2xmldata/modern-in.xml     |   1 +
 ...-secinfo-upgrade-in.xml => upgrade-in.xml} |   9 +
 ...ecinfo-upgrade-out.xml => upgrade-out.xml} |  20 ++
 .../hostdev-scsi-lsi.x86_64-latest.args       |  38 ++--
 ...hostdev-scsi-virtio-scsi.x86_64-2.8.0.args |   5 +
 ...hostdev-scsi-virtio-scsi.x86_64-4.1.0.args |   5 +
 ...ostdev-scsi-virtio-scsi.x86_64-latest.args |  36 ++--
 .../hostdev-scsi-virtio-scsi.xml              |   8 +
 .../hostdev-scsi-virtio-scsi.xml              |   8 +
 tests/qemuxml2xmltest.c                       |   2 +-
 21 files changed, 370 insertions(+), 260 deletions(-)
 rename tests/qemustatusxml2xmldata/{disk-secinfo-upgrade-in.xml => upgrade-in.xml} (98%)
 rename tests/qemustatusxml2xmldata/{disk-secinfo-upgrade-out.xml => upgrade-out.xml} (96%)

-- 
2.26.2