Hi Abner,
Thanks for this point, I will add the "Cc:" to maintainers in commit
message at PATCH V2.
Thanks,
Minh Nguyen.
On 5/4/2023 9:16 AM, Chang, Abner wrote:
> [AMD Official Use Only - General]
>
> Hi Minh,
> You can run Patchcheck (Basetools/Scripts/) before you sending out the patch, Patchcheck can catch the patch format errors.
> Please add "Cc:" to maintainers in commit message in each patch and send the V2 with the subject prefix in the format of "PATCH version", such as "PATCH V2".
>
> For example:
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>
> Thanks
> Abner
>
>> -----Original Message-----
>> From: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
>> Sent: Thursday, May 4, 2023 9:58 AM
>> To: devel@edk2.groups.io
>> Cc: patches@amperecomputing.com; Chang, Abner
>> <Abner.Chang@amd.com>; nicklew@nvidia.com; igork@ami.com;
>> nhi@os.amperecomputing.com; Minh Nguyen
>> <minhnguyen1@os.amperecomputing.com>
>> Subject: [v1 PATCH 0/5] Adding necessary changes for RedfishPkg
>>
>> Caution: This message originated from an External Source. Use proper
>> caution when opening attachments, clicking links, or responding.
>>
>>
>> This patchset adds necessary changes for RedfishPkg to avoid some
>> unexpected cases and fix compilation.
>>
>> Changes since v1:
>> + Remove redundant change and change the commit message for more
>> precise in PATCH 2/5.
>>
>> Nhi Pham (1):
>> RedfishPkg: Add missing newline character
>>
>> Vu Nguyen (4):
>> RedfishPkg: Correct variable type to prevent memory corruption
>> RedfishPkg: Fix condition checking of error status
>> RedfishPkg: Create RestEx child on selected interface
>> RedfishPkg: Fix compile issue on Linux
>>
>> RedfishPkg/Include/Library/RestExLib.h | 3 +
>> RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 +-
>> RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 +-
>> RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153 ++++++++----
>> --------
>> RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 4 +-
>> RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 +-
>> 6 files changed, 73 insertions(+), 98 deletions(-)
>>
>> --
>> 2.39.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103942): https://edk2.groups.io/g/devel/message/103942
Mute This Topic: https://groups.io/mt/98676443/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-