From nobody Mon May 6 22:03:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103937+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103937+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683170087331904.2651840075321; Wed, 3 May 2023 20:14:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id kfszYY1788612xJTvvZiMkhc; Wed, 03 May 2023 20:14:47 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web10.40198.1683165514015483678 for ; Wed, 03 May 2023 18:58:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JyAZH2ipkjMO3QtF4Vb2tXX59J3X6Ob8nuIKYpRAwDklXH7MJxjwzYSqBlydf9VpI4BQ4OoFvDYVTnY06BHZHm/aqzjpLYzpYJ7v8HiZBQbXLcIgB+BYTalBuXOphjjVYA6TDy7rpgQjECIVc8ZedhA4Ff8o4l2ZXzhQ9qd2c/RIpWmVDCCSU1x9AZZgOumgst23Y49bElD5FaHdWgplaAt7hNM311JISKppsNrdoQ8vKjBxlSPD+SlmbSlrSWK2GVClq1GgpNZ5sTHprRzRunjboGICy3cnX6el/Nk3yHa60ZOjIKY3444gBZL5zXAYpMPKyR6UQepy/0Bd4iedTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dSihEz/Jt8Y2iDBo4H0XhIU1PmahKSAz6K0TQX95Bhs=; b=dLM62W1micNU3Z/dV/9nNl/KLLy7ck6Uc9MT66I+E+HHbQDiv7u6CMXMLKLZnaTE9edyb1uwx2xVXinMEvjl4U8W3dgxBtTipGlX5E0CkpcOID8ir3Xe475rqtEiMDjgwSlxaobNLbaoPXPzFr/tX3ih8FXTHbllP6rd7k3/495M2kLkDkJabnPj7wgqsY/lsBi8RsDpS2Ow1lI2ka+HmrApgR5OWvz9IgFZ9292DWnBvWk1yCfN4il/+lyRe/3U2MwYzp87va3SoBHurWeLkV8Hgg6mxeVzKkPInvSr3F/HlA6X3lM+4q+fnM+SCrkXNl34VhBxwnjJ8K8Awczh9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) by DM6PR01MB5978.prod.exchangelabs.com (2603:10b6:5:1df::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 01:58:31 +0000 X-Received: from SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a]) by SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a%3]) with mapi id 15.20.6340.030; Thu, 4 May 2023 01:58:31 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Vu Nguyen , Minh Nguyen Subject: [edk2-devel] [v1 PATCH 1/5] RedfishPkg: Correct variable type to prevent memory corruption Date: Thu, 4 May 2023 08:57:50 +0700 Message-ID: <20230504015754.1352305-2-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> References: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2P153CA0037.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::6) To SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR01MB8049:EE_|DM6PR01MB5978:EE_ X-MS-Office365-Filtering-Correlation-Id: 5df5009c-c25c-4648-e004-08db4c430f8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: OE/5IYeJLh3dsKpCgWJSOqN5IVzkwuOnr5ts7FFtVA4rc+xopeI8wVpxvXlcpViCkt/Ldj34ft8b2m91JoIKilr+i+RjPlE/hwymYUv91u94Aw5sD7urpTWBumYNCHKb1BhRn5tgVgITNFo6s/TsKCSV8Y+DA48A9W6kt6nCbmWZYFZlIiJ9KaJmxg5hzpKNRxUe4U5jl8MDTyeKMymJjX7s5sV0woktfhlu7qbYZsUikF7Ek9x7tftYwXo+L5Kf5mCJBE6q5EAsAskPtVi2yr+VDXiuqSLaoTuELholDaZln2byhwlxjQJfgt5RHjhRGA56Iim+L/c61FxxIhlL2RbLjDbGPMcCifhAoHfdDzLAg+Ef8J4UzbaFg2tcW1lfBtC9T1bMBY102FTX/sjgxwIQGgn8fQuLE0kf7JcxI/Jg9ek+plNKvuPdouPCFYUGnyNvXpmWb+oDEOlMXKaYcJ5Vx1TVlbUWt2P9VjB0yPhS5Vhoj88o6wWgANkFyix/BKGVieFEm7OKr5F1X3dJFy1VHi8DXIuvfxe4OlS1lWrrQK6l1nW1F0vB11wFCBz3X8kz6vxOZfL/CbricKMze6iU7nX+S5cQWhZ4SeegpR/8mpfqhXCR0yCgUTnMvQza X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WVgRdpzN2XPBct5Pn72tNFlq0KVSwvjEOlt89B2yzWu/agKObEU3AU5uV6FP?= =?us-ascii?Q?jdLY//GLdBHeUNqzRalk3f90CscaT2nm586eYQ64twcTpU2pZ5LCvcBe5ymY?= =?us-ascii?Q?97/adJnfvK3rMm4KwESppmpA7SUpvwgrLRJIrhFUKjznwHYnIe8Ysr5hqr+c?= =?us-ascii?Q?Q6WzuALNoqGePhksWNaDlvwoHrgHdUxT1Rx4RuO7ZEzxOzwgQVadnk7Dm1kl?= =?us-ascii?Q?AuUBl32pfvBvimECJxK0Db4j7SD0MZKy42bHRpTJ+H15sh1aYrICW6En/8Ia?= =?us-ascii?Q?TNXA0zgZxWjimvC1VZ8R3V9LOAoGai9R8d+oy5enxhZO0XLRAAUqTImPwYWJ?= =?us-ascii?Q?8lNdl4lm7vnYBg5gaqJM/zYJ9UxilwTGnS9xDSb46Q3QTyvJQ8fdLErz/V6z?= =?us-ascii?Q?GOeS//C8bbQYCVTbzP5wZqbleUGfbYkWBLBuW6uf8+WT08z+iNMT2kbLI7Ci?= =?us-ascii?Q?qRyibJuTL1581xgaO1hrtmzZnsiyquxsB/cYP68Zo+E/3phVl5WWoawGGCQs?= =?us-ascii?Q?1HnTYTpGGy97dBWTCmaB3YRi1GWm0PkL4vZWTM39obBH2mpgRYMl2uJLw51t?= =?us-ascii?Q?hEGPzKk2ZjxBfUi1CGudlqHs9jidUzaUv1B6vaPujlcmbyr0r0wl+VVkcNsW?= =?us-ascii?Q?A0/mO+qHNdmZyNdcaomAxL5K86hBfVny7GixxvkbNqjszFRK6oDGlu4Zmkfe?= =?us-ascii?Q?m5W9rJeS0WcluLwuHInTF8x130FmDQa/DZOgeeCkBvXwLs39ZywE1fRxcJdZ?= =?us-ascii?Q?hHUq4dC3ZA++ivcD/k0VYL2yP1H1UFyEDcCWhdfuCkd0Rp+8sN9+H4lQAy7C?= =?us-ascii?Q?J7OC+aDxcalPaouMfUYObgI4WW/v96MB3ugeQDAmNZJ5DQcDtycpu8KhT22l?= =?us-ascii?Q?30iMnuWfw3wb8/6Wix4O0WckLf14esOjHuZnwgixlmUxCQq6FVhxLnCyiRak?= =?us-ascii?Q?2npv2bU9JNwxcioPU22uEdRhOErl/nBjqlDQNGIM/RZPOw64TuuHYCI0j3Ge?= =?us-ascii?Q?GA+Ni4B6szsTez9Blx6XYE7bStTlXc81pokz5IUlMnNwQwkUMD/1p32IWZqg?= =?us-ascii?Q?sed5uZ1qQwN1hczgjcPTIFMMtBAjRWoVmIe+r0hM/TdkRe2rYg4EzCa9l1BC?= =?us-ascii?Q?zsUlBgQ/hComoD1yX2jftdsykk8poXqovmGfZqTfsLrmjDOh6in40vIDsnE4?= =?us-ascii?Q?rz26BG+IxCh7aYq4TWbceHlIGOMIoafzikV1VV6a4SZ4EgbQ89osxnuaYsby?= =?us-ascii?Q?f5nJZ+Mf1Pn7cefB6x/a4e+hVx4WH24iaE3LEpDqMQlX66IZV2ZH1ceCkH7R?= =?us-ascii?Q?012LAkii7+N+jpmZilgwmm0qNWMt7xQMfmqpm2Qp0NZ5QqaioDl+NPwwwsJ0?= =?us-ascii?Q?c/2fHEYi+JbeePRnbaIcBCxhZXv4DUAgyBBvi4+XOtWgGwXjVSbrYXzekPLE?= =?us-ascii?Q?ixX3SEFjofl84xyuwOKgZFswx4dd/0b8HIiN9ulVl6onxyzxA4JQJyrYe0uq?= =?us-ascii?Q?e6Yx/d9VqLw4oDX/5JMPtmZX+4psl4O2CRuVtULogUJhy6DGwtYmZvyWySSA?= =?us-ascii?Q?P2l3Hez8VxDIV/LpC5d4aS3cIpxjwm43dMdxJTvOy9IgFDUc0/SZYC1aiKfU?= =?us-ascii?Q?TsHIwYU1x8TKzvG1S6EmT/0+VVJlUZiKfM2EASR0U4G5?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5df5009c-c25c-4648-e004-08db4c430f8b X-MS-Exchange-CrossTenant-AuthSource: SJ2PR01MB8049.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 01:58:31.4279 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ghBN+YaSEhhHxD80PsxNSOXJ3uyLEptuZMIPv5f8tfb5Yq/j0vd4dX0/doVTdYrUeFRVS33QfhAXRCXYgLkh+GYr/R5lTmsi/llyGEU77DZHtxDZ4Tv+a7bwJ8sJW2x9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5978 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: mdgOUg13xnBq8IJaQsxsXrakx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683170087; bh=l7tE/+MvEdStaqsmCWq22gVb680Dkv3g3GGuqGKgZZs=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=SxYc6KtAgR+sOHqATUvFrDntLXYmZAacaIiEZ6MqbpwwAF06bHEStRZHPoqYwUCmgnG olOxKEcfPwNqTwSJ2qSc8YCM0Af1A9hD1qQd1acqPWl/t04dV9NE9btuoJAxRVX0wDl+F MeeXfvqVRoU6UrDkTZShfxImKhICEedQmho= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683170088530100015 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen Id will be casted by CoreOpenProtocol, declare this variable with a wrong type might result in the corruption of other local variables. Signed-off-by: Minh Nguyen Reviewed-by: Nickle Wang --- RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h b/RedfishPkg= /RedfishRestExDxe/RedfishRestExDriver.h index 4a9e9f7b81a4..6b94e5814c43 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h @@ -3,6 +3,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -84,7 +85,7 @@ struct _RESTEX_SERVICE { // EFI_HANDLE HttpChildHandle; =20 - UINT32 Id; + UINT32 *Id; =20 EFI_REST_EX_SERVICE_INFO RestExServiceInfo; }; --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103937): https://edk2.groups.io/g/devel/message/103937 Mute This Topic: https://groups.io/mt/98677247/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 22:03:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103938+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103938+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 168317008696562.53444090905714; Wed, 3 May 2023 20:14:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id fdLxYY1788612xHgkDxSIKYC; Wed, 03 May 2023 20:14:46 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web10.40199.1683165516892047154 for ; Wed, 03 May 2023 18:58:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SPca2/sy5IvaMElhEp7KdvLIWTYIwcktHGekUCNurK+cnjOcc57xU3QovPDWjCEKNPI+IdUqSuOrZUX1cFn7SCtS2JX7eENFpoxFpZqlSo4EYDWW7iu7G+enR8zMTf31UapyW11iIVbKsOhZdwJ7RRICn2V/5ZGp4r7Sha65LA7DVZw5TWKLbyf9WO3AI7k5E7MTQljbtXV51tqRRhqKOVH7lIR1r2+4DLY8H/VNpKDTSB/5FITRYV5895kpc2diAYP/qnGYHxep77NJFwtqa6wPUVCQ9jtqfTfHNf9TOXjprdQ/rcql6xDtUbrJxyjXTKZ+NMH6VE/iUzaWJnIkkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xNrdBY1r5fbo82TYj7RUasTeZQFHcKwRx+s6YJweN8Q=; b=BoDqKb4vVWVPzUXx2Xr+kf+Q2CxcgNqGFzgbfT2dav94r024Lowpg6T/Q9saNS3TztFR0LMgb1NYa5NMNcwhbgMBxlkEjAE9Zm2dDYHG5VNfIiEmKkvHFv94c1EGT+8rImPLfub9OlJ83dUbRhDAnESFENO9tgUvWhE8yu/LJMTF5tDT0IV8JltiexMGJq0OTrnX8akMiFBezF6YR14ZvkQcpg2v7Ys9F1Yh00BhvYHb3UdeXJvx+lPKwMws8fQow+5WxYtogdSuxXYgMN/TUYd4ikTCUyDCbe7YaC4XL/vHavqCvVOxsusmUke7iynzCRrGgX1yyh+d/scQAaY0qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) by DM6PR01MB5978.prod.exchangelabs.com (2603:10b6:5:1df::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 01:58:34 +0000 X-Received: from SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a]) by SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a%3]) with mapi id 15.20.6340.030; Thu, 4 May 2023 01:58:34 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Vu Nguyen , Minh Nguyen Subject: [edk2-devel] [v1 PATCH 2/5] RedfishPkg: Fix condition checking of error status Date: Thu, 4 May 2023 08:57:51 +0700 Message-ID: <20230504015754.1352305-3-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> References: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2P153CA0037.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::6) To SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR01MB8049:EE_|DM6PR01MB5978:EE_ X-MS-Office365-Filtering-Correlation-Id: fdf3f2b1-5ce8-489b-dded-08db4c431144 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: Ax7z0pwxYS+wkKF/0ezafy1U4ev001NGV8j3yLQRrkRW3jpSOFQByEoLijUdbD/GdCw7mvRuBcM3F0YbksT2CO/+iyEzUnLCn1dc2tyiAVWD6XvhrXn6TUyY14OYRWJOjDBLOcSN9T+Zw4b3x9J2iTAxc0DSWGOYbeykayu+JB5T/Mg4x0Ua6dBnEPHxeIT2p6EGPMCBxqp5qDjHwRj0vg6ZYkkGeGOtHyuM3F3GIzGcjPw8pqKVTuAKNRaChNwN83HORPb4nGNLoh2/5zx8Lsgx1FYQLcz+FLMMnJwklXiTCljqC3LoJI56ivs04OXnSMt8cfJIohxKN5acxyZYxRlxXyGoqlBj0NJcshz3ug7J6S3el+/1Mgu1lh0PLSAnv8YOfFExHTQnWRj4bwkK8z5poLeBgUBgBAp2FVQq/uf7Y/iwAtEj/e7IiN+yZmk15NkKp/sPQZoK/5XeoqQMomSAYBGAGNGrld85vgBt7NJKgb3eEV6RC6giSdEUabZUkseoadCj7Ypj1y9ndzmFhiH2ln8Go2n6dnthN+zte/zqWHqzAqLIEmMCFUtCD55yhwDXoWjazDcz4cULjIPLz2lpuKVIPNpZtc7phWbn5/YhKPVvrYZMdDkSlq2/hiIh X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hyDaNepua0btCUmUvTcfaalBahXbTujF5LR4LVD4TF97Ak01T5xGpzgDO0bo?= =?us-ascii?Q?3G8arZAqPb46t9e/g51yAkGOQazBfysrfpaxmGtWDbYR2DZiu6VvyH5/UnNY?= =?us-ascii?Q?Aw+sWghQJWMRQZ1mjMe7kP5OI3Q0TuUls6aBQvGasuvk08QQbzA+zzpB3e0e?= =?us-ascii?Q?VTnlJp0w0hZ8nYhVCI33jIGI1wHK2ojOCPcdBoEisOoDLy+QQQLCOlYzk77Y?= =?us-ascii?Q?PL/38WAsIaO7P4NvCRpIoIrv1yDfA32cZAByjloqGbfksKaWHMyKuzLFrWbt?= =?us-ascii?Q?OsdF+PaCVR2IwwUyr465wVbuy1wYRJr80FAMKEV5lztWUkFw5CJ0BvRip39v?= =?us-ascii?Q?ceD3B+E1P3wkxSEvOq/yuLRMvHAY+GRT/EomWd+bX7CFvu4SU7GFiHKaPloN?= =?us-ascii?Q?QQSLowHYItt+6Jq74PLRH8Zu6ooLbYP8ZD3JBXVzL7+4JHHMDyoH2jHM5yMD?= =?us-ascii?Q?/TK+b6dKeC4TGLmLVtoJw/m6Cl7okIJCRGFdXdhQcln4YViNYFsQDP8gW2nf?= =?us-ascii?Q?eo8i8/MSMbf9nKW0wZFLy3M5mtcaG6HlhDyMe330zwiQqZ9rfsaopR5gSuRY?= =?us-ascii?Q?UVWq3F12w0khXbhK8B33Nh4V+Yp8n3cqZjfQM0Y7WCCPD2GMGa8KyZS21B0/?= =?us-ascii?Q?8W922+nqPQHJ7O3LvoxNBm0NjNAZRFqA9GsHTqlNUSX+J1cK5oC9pC/mCsK2?= =?us-ascii?Q?pWMHFdNpC1DwPOsXF2Gj0w232HoyuJEUzDtHgseTfI7u//tDEa31nakji1nx?= =?us-ascii?Q?sUS2YME4ftcJQbpeJzCnAX38yrteOWklMmyGlnyNaXrFg/7YSOFQSmtzuq12?= =?us-ascii?Q?xS55YgI2NZPRCPJJaHF7fpR2ZKd6UH5Ng46L0LSOgK7KwSvcLRSR/r3rGowN?= =?us-ascii?Q?+BNoHTpmJTfI+MQuuZeDRg/MQgeVG2VB/wv/CL1hz/ouYyQtoJ2IaNVuyzLP?= =?us-ascii?Q?O6ufZNHUNq0zWRRa96LAtj5ZWB9FZ8X9m5P63lx2Nmq5YaLBkZr8uU79+owv?= =?us-ascii?Q?MJVVGwrvvFmtPH0hKtTrKFp05V2zTjWk7ZyMmDg5TMeLkPkb79TTYYHMX2Xt?= =?us-ascii?Q?yv9XE10NjINzcZYLt4Qo2oOZ1Gk6cFdCCuRhse2z14vSinGkpdoNu9pvpbo/?= =?us-ascii?Q?MDtaSmHalsQxsv6OBjvSL5OhqoIvtQ5QVVQ4SY5utcOjJ3/dkvL1S3Hq5TWI?= =?us-ascii?Q?uKvRMcbYSVypsQkOUk/uotqzj8SW8TILjsCEVE67nW7UqypbCNEiQPXidZVf?= =?us-ascii?Q?0y6G8zs9P/5vMKzg9uKknli4d1zPiPVv9yXgRv3IdCuId9fKzBlTjjADrbjS?= =?us-ascii?Q?Ju8Ae7wU/EOdjPyX4ffo0zFSPCx6VyFxFgtcvL+9Q9SiJ8RbXlpMGnA1CdkC?= =?us-ascii?Q?EI9ZokesoNARC1UEl8MmfPFZQza0+2f+jvWZkUjT9lybxZiSYYPk8swG5aMa?= =?us-ascii?Q?2+gJvRJLanTg9OlX4UbGTZri9AeA4O+m67qh4z5JfXm+pJa92f/Z5DGiW28L?= =?us-ascii?Q?8RP/+CzfOMfykUqo+F6fFCdJdlHvm4ZvwxiAB7LaxUBfVo2ewWBFtATFESoa?= =?us-ascii?Q?vuq5MWn432hnhp9IdcTPBTqrDtnhEFwmYefG5r30XW+jCaWf890DlfhyPOmV?= =?us-ascii?Q?v5S+O68y7SvvveXCcbCEARE7YxH9Pdw3m3/Gtz00fvK5?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdf3f2b1-5ce8-489b-dded-08db4c431144 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR01MB8049.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 01:58:34.3008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wVuq+YeKcbJ1biZTsoOhcjQHGUW5cmR7iRwgDRCQqrDS20rRUiEEVPteyxti+bSyyX1EJw84T/ZEUetRyp6Rh/yvmicmetSq7sVS/YMXyhIvxXWIkoVKR78Rtv8VDA3M X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5978 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: fkkdiWQyaPu6bwpTlwdbMHXfx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683170086; bh=FbOIvPheaCXverEb1kDxYeK1BZDxgTeF/zbzauGzsH0=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=UdieXKyatGNAmopL7uGOd0WF8SRQRfpPCApQ9joUiDD2sQkCEJYbWtId6skYERBIi6u YOfUaLL+LtB1VkobKP/x17n7Hy9GfTG+uPCOANmLDAhvt+5ceMHdzS02PRmH1zRPfDynD sEJB07QXtWf5FtK4xsWufiCyQ3qMefgTpoA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683170088719100020 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen This change fixes condition checking of error status, the condition should be compared with TRUE status to be identical with an error message. Signed-off-by: Minh Nguyen --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 583c6f78e19c..a247bfed9e34 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -5,6 +5,7 @@ (C) Copyright 2021 Hewlett Packard Enterprise Development LP
Copyright (c) 2022, AMD Incorporated. All rights reserved. Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -926,7 +927,7 @@ AddAndSignalNewRedfishService ( } =20 Status =3D gBS->SignalEvent (Instance->DiscoverToken->Event); - if (!EFI_ERROR (Status)) { + if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__)); } } --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103938): https://edk2.groups.io/g/devel/message/103938 Mute This Topic: https://groups.io/mt/98677248/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 22:03:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103939+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103939+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683170088605787.3740726194509; Wed, 3 May 2023 20:14:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 67vaYY1788612xyPTmWhQxdh; Wed, 03 May 2023 20:14:48 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.108]) by mx.groups.io with SMTP id smtpd.web10.40200.1683165520369557336 for ; Wed, 03 May 2023 18:58:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kqDDHuIWdOpZyL/ljK0T6SX6APbxWPIAZWZrR8gS5+BpB23qRM9tx4zI/IeuDkk0XK1zewr+GpmKpSbRFRvHXvWFhqZdaYuQOqREhCE9BO0UAh4OJY1JCjZQ92eM1i/w/t+OHRhjd8zB/tGnFPg//OpkrPpDOirzfdpdWAZGhScTXf2pKuVb09mBx/WvY6KnfjPxLCH5ukz4nGkbujkk6TcLG3OFBvP+9ZJzJTaJXX04pWDiIVIMLkkccSUF8cajTHtBK9zR677CRmJG5BN96WlBHCGveG14/6fuOfSShtquGbgPOcBSz6ubd794Hmq4W4dKmMknzLmWJYNc4dNtIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aP3BUNFW+xXGUG8IniIBvISmYemgCWzOwyBdsH+KfSk=; b=IEYwvKbB8MDMmTvcCccBv0tsnYyIh+KiUMykL8++I55Y2nsWy9ax+QZJVlfahToAUMwhsHw5zePoQtb4bAtxNnHpUroEK0bfr14edQP855/PAl97c+5lcJ3gLoxlLFFDzbnLOzR2Qnav6ytWjm2PwcmZPvvy1b/QAcvKxH/YygjTh18LDZ7oFCyUjW1a7UPROQG1YXA5W6yUYe0w21pBJ+WOzLT46hLW/rS2SXDVy3DKSRIeUMg1M9sGGGP7zoB5o0J8+E/zFQK5c64dUOMtEP35x1sa2NEclgyBL+M2EHRA7E+wZhIM4o28F/PvKoL5NZ5Xo3bTN8TeF/p/a+RJWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) by DM6PR01MB5978.prod.exchangelabs.com (2603:10b6:5:1df::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 01:58:37 +0000 X-Received: from SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a]) by SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a%3]) with mapi id 15.20.6340.030; Thu, 4 May 2023 01:58:37 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Vu Nguyen , Minh Nguyen Subject: [edk2-devel] [v1 PATCH 3/5] RedfishPkg: Create RestEx child on selected interface Date: Thu, 4 May 2023 08:57:52 +0700 Message-ID: <20230504015754.1352305-4-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> References: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2P153CA0037.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::6) To SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR01MB8049:EE_|DM6PR01MB5978:EE_ X-MS-Office365-Filtering-Correlation-Id: cc6f7047-303b-459f-88a5-08db4c43132d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: PyknjffpYolCK3cOUkE+zWmZyrysU/bIFeDdvNRLqS6SbQZN4BZcZXV3fVGFDd2mEunooXA264JSUEsGG3lJ13vundQfzHXQ5PKLi4RNuL9KuLhH5RQUu5EvJyzYB6LKCb7VmUJSkBk/NQTtQu0BMZjllY77i8Xuvgh6D5ysVBdMzdRwh2jNIuX7Y8hNmKrBk7BTiP+miWTWeea6oMgoseXtaubdL8uFX05vwKiWREJ6pXWL7ynqazECxGs1quygK6gJxo2rvXEEYox9YqC14zsU2ml1I9paAuVnEvFFQrTeksTosbL0ZflFcB9mM6m7RFXlnK/MjU7C1zEwR1oOdfQPY+idju/0SNDD2Xgzfea/2hvOJcuCHPuwOggvlnZaoPT22XaKN74ojpt3z/y0ZUNJLOfEyqEbeI1nh/7xpP1ZsJulkXyjU3J+zLtorGPCSqEp193U0HerWrVTYST9ue4ggHzKL9i7uMO47vtTTvsF04TnRDs06+HJ27KP0pWJiIGn1W0twzWcu0TKeBPhUwfKmYEy+hVrhJXn4G+0v6yoV9/hd09xE6HXB4/xQ1oNcJ157OcpAU35yly72S+tSXqpwJVJolMJrreEykAvGIYV1nIHeozaOYqdviajzDdC X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JPYWu84jO0rl6fRgheQOsOu0ZoBqOIhsvwIw2zUls0LGwuyXNS3Tvxrbe0AE?= =?us-ascii?Q?EyxBk3bbAt2EsA0OvuskppTy24MtDrQK7YtzPITxpe6/V4JnYRWyPpq6qeGQ?= =?us-ascii?Q?vCrcl54ICktlQ5Cyf+ds51TWj0wVjQXlxfUjtO6x4VwQ7XoZL+/SZctxujbo?= =?us-ascii?Q?zQLVlbdZ9YBsq81j9xzi/zRMBn/49O38WW8kTaV6SO1VC8na+nGYud2lqZ10?= =?us-ascii?Q?R30tWIAv5hY41CTyz8nhQMOZHV9xASAoUU1KZDPbloYWsc/qiAjjHnlNVYfc?= =?us-ascii?Q?1HoO4Lq9F1l9qlRQ0ap+aMETtyWvmeKtxGt+Y/T9OlIHtGcBWhGRceVHiDw0?= =?us-ascii?Q?FNcJ7Frjau9/C+XOxqooD5XrjKMpqVJNOeG1kxIzC9N4c9DrmLkb+xnF7DI/?= =?us-ascii?Q?tPQ1DrIWOEo+GxmnT6PyFFL9xAVuJiz5trwLWxqCMqUL/h54XxS+LEWRseSj?= =?us-ascii?Q?+Vym1+C91QyVUC9A/reYAx1dbzLoDsgkfO69dzpMkel/OI0mM5oYpGawz3yB?= =?us-ascii?Q?xYAs3WjUnw2JqoJsSJM1iaZw15XA6ZgY/Ly7xl41OrdU+4REeuB9vzGUW1jV?= =?us-ascii?Q?H0Z7TQBNq68gmr3RQIBfsNSy7Cl3oJY9PvntJJW8atSUOnzYBeb0dA7eVf0/?= =?us-ascii?Q?rWDpqrbdroQCi2DqvbqV3yzJc+v7AbVm4wcOyJgsLpd0DBDpBcljva0ZHxTW?= =?us-ascii?Q?894lMGC6M1h1lKpu0tYPnMxGWMrBlTm7bkVkI6k5G1FiVFk3IPDkTTB7c8wJ?= =?us-ascii?Q?8y3yZV8jedZE9YdvKRIOdLaTknIWxMU88sP+RksZPFkcdguBeJwi63YWgg9q?= =?us-ascii?Q?EPCmuXc+6lFYxpcu+jhOMMuaRVL31cFREEK4z48F9kLBA/b3l1EMBogidYq0?= =?us-ascii?Q?S5Hzg39CJrUxf63fDwoCDNoEvWnPGorAqY3jVCdwzKmg2Ojrflmj0ePzZZZD?= =?us-ascii?Q?fgQd03IW3ASbzhK29y4w0vzJboTVRSZuG/2s9aQrZSWx6W9lQpuIjr3sxOaX?= =?us-ascii?Q?qghfRzYT43nHcwKRiFwMkcp6yQV7Wb1a4B7MlN86wAsvEweY3gfyFq64Ak1/?= =?us-ascii?Q?ZJfa68+d03JPHpiOkBxAhni8yhvdMbvbOzSEvhsApX4l/v+Qw5qhUjtLCBR/?= =?us-ascii?Q?iZeezNw/a3bNoPbBBhKvQMWDj/k7ZyTLBk9LIwgiHnBTUPDNxRfw6J/IcVX9?= =?us-ascii?Q?HyR5EUZliEKOkGi8zzbfT1tnYanVMQvUaYkOCyWH7Q5jN79SliEJTSKZlpYx?= =?us-ascii?Q?dyKPtNbTH8ZZqFZ3fYY1EPGVEza1hQRBGJIDD48hP9T2wc2kpjSeZhD/fQho?= =?us-ascii?Q?kKnKr56BUM9lIqYfKHI0CKCT12QZa0B6u8rgYqNbdBQVafaFt7ZD6Q9IDGGx?= =?us-ascii?Q?tKRUoakhOpmBPPAekVmtrF/G7v408UAKb88peWTIGjrASm614KkzsFjKDiwu?= =?us-ascii?Q?JJBYR365jlpT4OeMQx1TiANcCN3XMrDE5kE96e1niSzD3n23Yo82RGFUu1Zo?= =?us-ascii?Q?YIaCU29+An/2UOWzdfKssCOTI5juKG+mLxH86vMPkFkd0kjjiOZjvMDUkv7F?= =?us-ascii?Q?9FVk6MORbzhRhsfD7bPESc1SUyIIUrQPmKVnHQdsHFx8dNZl8QxeajbmtcM5?= =?us-ascii?Q?q6mMND3rH58px/tnIAELhQP5vkdW02DZd0S/I1ivqpjh?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc6f7047-303b-459f-88a5-08db4c43132d X-MS-Exchange-CrossTenant-AuthSource: SJ2PR01MB8049.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 01:58:37.2938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R/0AaJh/bF91ohhTUSMJaQsBQILueVjzfrk6y62F3+DRRM7upNuYiRA29nzm25keq/oEp+vrd+UABScWHiFN2tKiVk8VL+kyTVskj0l8thIJFCTTtYMqJueyxkYdLEDb X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5978 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: igkeUKhDPmLy86e3qNMobLc2x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683170088; bh=ZnvYe1KbDOnlaXud229e/f3cbyZhdCXJrfZUfn3UaEI=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=qVdJEpyY7SgBYGHSxZC6wAJ6/Ix6ARbpHqyhW/f8ile0gV3LWrVev8hRHi6aGbC/qbI V6ka5+VSJ/C4Zqbf6OMD/egRNS/F3SfNcC3O/2ccyJtsQ+/X6kH1jXO8eFkuF+JF81ulZ 9lRTTDaZYdfA3gfH2zsW7R3L/jC3w17PkZw= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683170089483100027 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen When a MAC address matching interface is found, a RestEx child will be created to provide the Redfish communication on that interface. Currently, It will try to locate all RestEx binding services and choose the first satisfied instance without taking care about current selected interface. This might raise an issue on the system with multiple network devices that the RestEx child was installed on wrong interface. Signed-off-by: Minh Nguyen --- RedfishPkg/Include/Library/RestExLib.h | 3 + RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153 ++++++++---------= --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 1 + 3 files changed, 63 insertions(+), 94 deletions(-) diff --git a/RedfishPkg/Include/Library/RestExLib.h b/RedfishPkg/Include/Li= brary/RestExLib.h index bc4e4ca6caa7..2c32c3684cf4 100644 --- a/RedfishPkg/Include/Library/RestExLib.h +++ b/RedfishPkg/Include/Library/RestExLib.h @@ -2,6 +2,7 @@ This library provides help functions for REST EX Protocol. =20 (C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -20,6 +21,7 @@ This function allows the caller to create child handle for specific REST server. =20 + @param[in] Controller The controller handle used of selected = interface. @param[in] Image The image handle used to open service. @param[in] AccessMode Access mode of REST server. @param[in] ConfigType Underlying configuration to communicate= with REST server. @@ -32,6 +34,7 @@ **/ EFI_STATUS RestExLibCreateChild ( + IN EFI_HANDLE Controller, IN EFI_HANDLE Image, IN EFI_REST_EX_SERVICE_ACCESS_MODE AccessMode, IN EFI_REST_EX_CONFIG_TYPE ConfigType, diff --git a/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c b/RedfishPkg/Li= brary/DxeRestExLib/DxeRestExLib.c index d9acad24dec1..6002be93c54e 100644 --- a/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c +++ b/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c @@ -2,6 +2,7 @@ This library provides help functions for REST EX Protocol. =20 (C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -9,6 +10,7 @@ =20 #include #include +#include #include #include #include @@ -21,6 +23,7 @@ This function allows the caller to create child handle for specific REST server. =20 + @param[in] Controller The controller handle used of selected = interface. @param[in] Image The image handle used to open service. @param[in] AccessMode Access mode of REST server. @param[in] ConfigType Underlying configuration to communicate= with REST server. @@ -33,6 +36,7 @@ **/ EFI_STATUS RestExLibCreateChild ( + IN EFI_HANDLE Controller, IN EFI_HANDLE Image, IN EFI_REST_EX_SERVICE_ACCESS_MODE AccessMode, IN EFI_REST_EX_CONFIG_TYPE ConfigType, @@ -41,8 +45,6 @@ RestExLibCreateChild ( ) { EFI_STATUS Status; - UINTN NoBuffer; - EFI_HANDLE *Handle; EFI_HANDLE ChildHandle; EFI_REST_EX_PROTOCOL *RestEx; EFI_REST_EX_SERVICE_INFO *RestExServiceInfo; @@ -59,116 +61,79 @@ RestExLibCreateChild ( } =20 *ChildInstanceHandle =3D NULL; - // - // Locate all REST EX binding service. - // - Handle =3D NULL; - NoBuffer =3D 0; - Status =3D gBS->LocateHandleBuffer ( - ByProtocol, - &gEfiRestExServiceBindingProtocolGuid, - NULL, - &NoBuffer, - &Handle - ); - if (EFI_ERROR (Status) && (Status !=3D EFI_BUFFER_TOO_SMALL)) { + + ChildHandle =3D NULL; + Status =3D NetLibCreateServiceChild ( + Controller, + Image, + &gEfiRestExServiceBindingProtocolGuid, + &ChildHandle + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "%a: Failed to create service child - %r \n", + __FUNCTION__, + Status + )); return Status; } - - Handle =3D (EFI_HANDLE *)AllocateZeroPool (sizeof (EFI_HANDLE) * NoBuffe= r); - if (Handle =3D=3D NULL) { - return EFI_OUT_OF_RESOURCES; - } - - Status =3D gBS->LocateHandleBuffer ( - ByProtocol, - &gEfiRestExServiceBindingProtocolGuid, + Status =3D gBS->OpenProtocol ( + ChildHandle, + &gEfiRestExProtocolGuid, + (VOID **)&RestEx, + Image, NULL, - &NoBuffer, - &Handle + EFI_OPEN_PROTOCOL_GET_PROTOCOL ); if (EFI_ERROR (Status)) { - FreePool (Handle); - return Status; + goto ON_ERROR; } =20 // - // Search for the proper REST EX instance. + // Get the information of REST service provided by this EFI REST EX driv= er // - while (NoBuffer !=3D 0) { - ChildHandle =3D NULL; - Status =3D NetLibCreateServiceChild ( - *(Handle + (NoBuffer - 1)), - Image, - &gEfiRestExServiceBindingProtocolGuid, - &ChildHandle - ); - if (!EFI_ERROR (Status)) { - Status =3D gBS->OpenProtocol ( - ChildHandle, - &gEfiRestExProtocolGuid, - (VOID **)&RestEx, - Image, - NULL, - EFI_OPEN_PROTOCOL_GET_PROTOCOL - ); - if (EFI_ERROR (Status)) { - goto ON_ERROR; - } - - // - // Get the information of REST service provided by this EFI REST EX = driver - // - Status =3D RestEx->GetService ( - RestEx, - &RestExServiceInfo - ); - if (EFI_ERROR (Status)) { - goto ON_ERROR; - } - - // - // Check REST EX property. - // - switch (ConfigType) { - case EfiRestExConfigHttp: - LenOfConfig =3D sizeof (EFI_REST_EX_HTTP_CONFIG_DATA); - break; - - case EfiRestExConfigUnspecific: - LenOfConfig =3D REST_EX_CONFIG_DATA_LEN_UNKNOWN; - break; + Status =3D RestEx->GetService ( + RestEx, + &RestExServiceInfo + ); + if (EFI_ERROR (Status)) { + goto ON_ERROR; + } + // + // Check REST EX property. + // + switch (ConfigType) { + case EfiRestExConfigHttp: + LenOfConfig =3D sizeof (EFI_REST_EX_HTTP_CONFIG_DATA); + break; =20 - default: - goto ON_ERROR; - } + case EfiRestExConfigUnspecific: + LenOfConfig =3D REST_EX_CONFIG_DATA_LEN_UNKNOWN; + break; =20 - if ((RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceAccessMod= e !=3D AccessMode) || - (RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceType !=3D= ServiceType) || - (RestExServiceInfo->EfiRestExServiceInfoV10.RestExConfigType != =3D ConfigType) || - ((LenOfConfig !=3D REST_EX_CONFIG_DATA_LEN_UNKNOWN) && (RestExSe= rviceInfo->EfiRestExServiceInfoV10.RestExConfigDataLength !=3D LenOfConfig)= )) - { - goto ON_ERROR; - } - } + default: + goto ON_ERROR; + } + if (RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceAccessMode != =3D AccessMode || + RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceType !=3D Serv= iceType || + RestExServiceInfo->EfiRestExServiceInfoV10.RestExConfigType !=3D Con= figType || + ((LenOfConfig !=3D REST_EX_CONFIG_DATA_LEN_UNKNOWN) && (RestExServic= eInfo->EfiRestExServiceInfoV10.RestExConfigDataLength !=3D LenOfConfig))) { + goto ON_ERROR; + } =20 - // - // This is proper REST EX instance. - // - *ChildInstanceHandle =3D ChildHandle; - FreePool (Handle); - return EFI_SUCCESS; + // + // This is proper REST EX instance. + // + *ChildInstanceHandle =3D ChildHandle; + return EFI_SUCCESS; =20 ON_ERROR:; NetLibDestroyServiceChild ( - *(Handle + (NoBuffer - 1)), + Controller, Image, &gEfiRestExServiceBindingProtocolGuid, ChildHandle ); - NoBuffer--; - } - - FreePool (Handle); return EFI_NOT_FOUND; } diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index a247bfed9e34..dd5bdbb377e9 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -87,6 +87,7 @@ CreateRestExInstance ( EFI_STATUS Status; =20 Status =3D RestExLibCreateChild ( + Instance->NetworkInterface->OpenDriverControllerHandle, Instance->Owner, FixedPcdGetBool (PcdRedfishDiscoverAccessModeInBand) ? EfiRes= tExServiceInBandAccess : EfiRestExServiceOutOfBandAccess, EfiRestExConfigHttp, --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103939): https://edk2.groups.io/g/devel/message/103939 Mute This Topic: https://groups.io/mt/98677249/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 22:03:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103940+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103940+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683170086584233.45170001550332; Wed, 3 May 2023 20:14:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id CZ4WYY1788612xJhLqMCDSKM; Wed, 03 May 2023 20:14:46 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web10.40201.1683165523049281938 for ; Wed, 03 May 2023 18:58:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G6cBGKZBIeVJlnhRKRas+BwIZN9vDeqwT41XPty+as3r87LFH091JNs5w4Gf2UO1tOWv4rs0r4ey9As+HRAn8OeYpLX2rFIvLa/mqYzKhtud/lIa2AtylPPv2aBGw9abxNwzJqtgiJEbRUnHOizrq1YAS6xJif+lnV/qIhdyHcTL2tkTwGEdF9LJeq7UNESQyiW1atO5T1A9Mju8t7HoTr/JlnD5LOuTaFYmo0y2uTrreHaASriTuiuLyncnZ7+YUGuV5AHXVDlbwyqfBJ9ImHpWheRSfGHyl78K0G188Vm9yGhxaiNbSxNzShCEtTRU++FaiuGFt17MDxo/lLSwjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iPPeFQr9LoDqx/2VruodM+n6dLk9b3SYTilcEqmXhtk=; b=aQEENT6O2SqTT2yn6w15xuxVtsE5V1lFo3ocsBdCSBWBO50KzRCv2iCIDVItXrQ0UGdPCwigHOnAbyyapKZei4r7Lzc3eu9rX9b3gYNucRsRSkdccgLaXssqnq0TVzkYWZ6DZN8PI0VDUl4BJmtSwW/DGKlAhlVuYknVDtFURuMZkHc35w2mEEErQ2lN6nP7oBaeMf9kHJgzC5BaT9HKUG2AyBNhey1ey6+c2esdY7z7LwUuoDdGvDKu7JY6jo4W7JrKj2v56GhzEhHkLqeVJjXT6spaTKb8o0mt6IJu9RsrPk6CtSDTR9Bzv+uKkJ/kbCY6QsZCqMCyM85IkGEaHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) by DM6PR01MB5978.prod.exchangelabs.com (2603:10b6:5:1df::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 01:58:40 +0000 X-Received: from SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a]) by SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a%3]) with mapi id 15.20.6340.030; Thu, 4 May 2023 01:58:40 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Minh Nguyen Subject: [edk2-devel] [v1 PATCH 4/5] RedfishPkg: Add missing newline character Date: Thu, 4 May 2023 08:57:53 +0700 Message-ID: <20230504015754.1352305-5-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> References: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2P153CA0037.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::6) To SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR01MB8049:EE_|DM6PR01MB5978:EE_ X-MS-Office365-Filtering-Correlation-Id: 6651fcf8-b55b-42f3-b049-08db4c4314ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: Qo19RuZtv6+t4hKgm6IMu7n5cQeyb+z0/cI2As/Fhe8ekofsNhAGKRBhsuev9piHKBcBZ2blTbP3XR8kdL2LymYnjF+A6lnhzVwL74hpSHyIQtcQWfQnHNDTsU9L3ZnIOBYKwanbXyuqQMTh3IswPP31FySicHuUDo1L+QdHtcUfJlmvu52Rfe7w4q8awfav1bGiKu1OsJVA6P/ZHHRdp7UtfuXdbh/ST1/coTU700TSqZWxF56dz/NX4Dk0S4lt8HSqLA7ozHWT9DUjgCZTyKgYQkhgQjrq0KsSQ24uN2zH1IPt9wKWVtqBSi7wcIyjbv/bp13tQJzYwNKkirKSrLThhqFzhgh6FgEvVB5GZFj0Ej9+x/h0i0ulmmTx3kelX6S5zwsYzJ4IztlWqACmww6LCyFQDjh6zdKtev5cWp04lYgIDr6r2IoivKOTblvLcgTp9NGp2YT5P5J6FVS3041ksqIAeJNpa8bDrM4XG37LCNq10fb6xEF8nslLLBRjWxjU77zV12jkP8bxkX5W3PrdTmSBQqiaNBMVSfUSlyU4qp3+f/O4n5cJkDOShA/37Y8yrYgr245cVVOCGL0NAPADb1zgdIxM34l5aZZSXYlKqz7+Na86WZTSNbkfJRq4 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?enqduxrNOqPdQeAJkbTplNDoz1geacqQucgl649Sb88XH6bZekuvv7VsoMPh?= =?us-ascii?Q?X8mibDPoWhyhlLj6ctE/4QZeHZivRZJdqYg2sjimyAtXNwdtaaVhxxVrhyJr?= =?us-ascii?Q?RojN+uhhdR69k/1D8OlPNw8azw2w1EOTq+drQV348iK5XQ/SZdNZLA68kdV7?= =?us-ascii?Q?xpOLsEAhZ+0ttCL410wJDzy4igreiNZyRMS6VWFDWgNRtCFpD98Qzklu3oK8?= =?us-ascii?Q?otVX58M8p7XIIG/Ni7Gi7tt91ePu7rg7BTM52Cit5Ua0To2t6P2QMU0rTxRF?= =?us-ascii?Q?NsqxFK9RLSoIaFSjd1Cn/Dye36uNdNe03Sz2Svo3OOsMlj2+nbo+/xj/7prY?= =?us-ascii?Q?YNrjL381gOa1l1oonq+Hw63BJnZ3u+Nlu26rzKJwZPqdI6BdDJKB2PwVwJ7N?= =?us-ascii?Q?zGFwVMFuGPIaWd1GvJuFdeFiSTCHpf+e/rqapvUPLc9WySwF3YcL/Rp0IbzL?= =?us-ascii?Q?3FuAQo/Y4P/H3QS8ooDxkCw1ia+lgB2DlOR+ZzfTIfUfJUnP6RIeep52zZPX?= =?us-ascii?Q?9zt/p/j8rcSxQn4AkXaHSxb8xjkh72psFVAJBY2FHCBnYuJS4JeughBOsnry?= =?us-ascii?Q?aEEqiVUTbClMIHRckzLmzfjbiZIqPE6eUUKFyGQeC8d7ERj3yLSgmp01m6E1?= =?us-ascii?Q?o8XJpKdDr+awEoMgLXEPwLgWBLOFOT/G1u++MQD9vvQwKkCKNuXBOvQgwKaI?= =?us-ascii?Q?YCcG4d19InIOn28WeuS+01LWu6O4IEVoCKFt5QfGdsoq3zvMm5gGsM/FvSwW?= =?us-ascii?Q?COQ4VLWvN/EJw0p0y6F78phB2qKuzEZtliyUzUb5I5M7i3D8H+0fjgW14SXk?= =?us-ascii?Q?ic3yZ1PpdAx0ShmstOn051MEpRn2lkozACikuacQKlsHrbUqSA4fsVmOXEyd?= =?us-ascii?Q?pnQPK2AvncrKrdVqInMWuoVQTYIWEXaTqti+8rboxS/wNs/ADx3bs5dJd4zO?= =?us-ascii?Q?onq9EkNLyEnQCAACimun5LyFhbWk4iyTDCJmkd1piD7QbduDFUr1jkBEixS8?= =?us-ascii?Q?JRNHjCT6WgtActZ9eXRDV4FsEl4LuxWXoWw2tVUHuZzawceBoE7Qxd0fCMpT?= =?us-ascii?Q?Cs01e0PGEDw+YXMgpm3CuzNePXidwb2M866QrBQNfl60TBdDhF15WuC8GKc3?= =?us-ascii?Q?l2xZEQe5VfWoOjYgmNMsHCUOf3GjY9XP3AqYVPfQ12D0yFdqTzgF9ajmsFD+?= =?us-ascii?Q?hfV3sds1bOdMTydUbEoWi7L5Apodq+Cjxq87l2Bcn+VEXD6LNOAUUZVU8sFe?= =?us-ascii?Q?gIWgkUPdVKKtIdTM+UHfHUywgkWmxIEfHF6Q7uOHgdW5GdYtbx/P9uT/06mk?= =?us-ascii?Q?1tTFJQ5Bjo2qDE8mzd/bmJYpPl2zD8+boAQVLJpmnOD7bUiMVI1z55a6lYk8?= =?us-ascii?Q?QQqbLJdv8SgP97AsHJ2c+sAuPmv1Ty+8fEDqpTFPGuLaxYq38C6m1XxxfztS?= =?us-ascii?Q?FPaMLu33cU5k+vWfA8W3hGGKA0ZjOQ+0UCatYQB6EWQAfKU3wTuekr6xS8Az?= =?us-ascii?Q?lRH8lkAppWa1blZ7HEylhky/j3pP5CIZ1fy/Hw+z0xl3uHCqmzPOpTx+Cz9d?= =?us-ascii?Q?GK9qbAJyFGryi41XEpsH9z0gajWj91XlGI6LN1ZrXxjhXTi9uJOSHsZeKn6i?= =?us-ascii?Q?vaS+k6IxqAzHU7P0XT7UcvD/949biKsydAxVu2bIcTcM?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6651fcf8-b55b-42f3-b049-08db4c4314ce X-MS-Exchange-CrossTenant-AuthSource: SJ2PR01MB8049.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 01:58:40.0735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WJkJejoP/d2DKFBqRzfgDkHzaSixVJkuzIAlcaBHItSSz1N3MeXertilDGOjucZwz+Y9G+U9yvO3tNQuXWYdpIt2NBGbr3ynjxuK/xkuygRhl3HkEaXg7mFOlkNwcVQU X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5978 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: 53NYOjkPfUbGGyUOBdxXQUvmx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683170086; bh=c9MAnZG/SCHqqj8OipFpbBD96Sgjrqb+8UFyzw4HCgI=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=UNfc8EnHOxLlFIhAtmi8j6l3MClZQCV+dsaiF2x+40LfpQYWrl67uOLLb5pqsXp9ZRz CLNz9uGRO2YgOXi12LR8hD4bYPHglGW5p8x7+33RDTPsdDc1JzW77PVF8juoQfssg4yvp 9z0kG/J/4EZk/LP5U86/lUs+XZdfnbTPYwY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683170088410100012 Content-Type: text/plain; charset="utf-8" From: Nhi Pham This adds a missing newline character to make the error log readable in case the module is failed. Signed-off-by: Minh Nguyen Reviewed-by: Nickle Wang --- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c b= /RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c index 45fc6e2182bc..c4fa59193a2f 100644 --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c @@ -8,6 +8,7 @@ (C) Copyright 2020 Hewlett Packard Enterprise Development LP
Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -59,7 +60,7 @@ RedfishCreateSmbiosTable42 ( Status =3D RedfishPlatformHostInterfaceDeviceDescriptor (&DeviceType, &D= eviceDescriptor); if (EFI_ERROR (Status)) { if (Status =3D=3D EFI_NOT_FOUND) { - DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is pr= ovided on this platform.", __func__)); + DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is pr= ovided on this platform.\n", __func__)); return EFI_NOT_FOUND; } =20 --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103940): https://edk2.groups.io/g/devel/message/103940 Mute This Topic: https://groups.io/mt/98677250/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 22:03:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+103941+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+103941+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683170088207892.615722845054; Wed, 3 May 2023 20:14:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ODi7YY1788612xDXvxit4ahs; Wed, 03 May 2023 20:14:47 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web11.39863.1683165525779867290 for ; Wed, 03 May 2023 18:58:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KQ2Be82Zigy3Wm9JVx+gqQwdrQKa4RMNlA6K0uwkz0GCPo+RpK27LUdRclhNZ6sHkXuEs5+Hs6sL4XpJIfetUNIpyUT/KtYPaFEqlLiCwHjnWK1IR0r1yZUQyWgg0hvyCOnIkHf7zE1tjBYwbBPTnjggm38HKqOmefTbvcGjgXysmTvz8b1KfbaAiCMW3HfFba9DlR0R9V9jTU/5uWN+m+iGwB5Fm2q0gAeHu6O9nZSAQ+8iHMJsnTHjlFbXpB7JhK8t24cOV9DSlonh4wA5KhuJmbhfNhxUkRyXn49RBwwYN1u6Rp5pKa+8H13UHPjDcmGj/JJNOCjSLHPXZy6Phw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hnpG3bUCxmaBvARhhw6TaH3kmzIWdQn0fckNBgL1Ubk=; b=S9RIiC+mx/J2IaCA+2SpjMVJEZIB6ocZDa0OQEVxLZyZ0HhvLK/YRrxUnI/5DtAeKUDCx15YDpY1b/HUImEMdeziOuXxgcfo76NTecow7o+eAADMai7dxqZZwiBoRxOzKTqgTY2MH9Xo6LJaqZuzcCYiOffQrxtEMSAUgselokN+IKsbyleXe/i/9znPXOeOl6zOthDLhsCc5wvflNXlV2zTeJJRuiWEs9CXb4cZ5fUOx2PZPkVFmrRnPohvmYhVJlXQpqsCFxSJNCVzmurVhNZZRVsjvJ5C3DJ1aSCqcoO36/qJsISBQIZx+8IPuzdz6Z+9FLI9OrpGAXemGSo8TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) by DM6PR01MB5978.prod.exchangelabs.com (2603:10b6:5:1df::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 01:58:43 +0000 X-Received: from SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a]) by SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a%3]) with mapi id 15.20.6340.030; Thu, 4 May 2023 01:58:43 +0000 From: "Minh Nguyen via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Abner Chang Subject: [edk2-devel] [v1 PATCH 5/5] RedfishPkg: Fix compile issue on Linux Date: Thu, 4 May 2023 08:57:54 +0700 Message-ID: <20230504015754.1352305-6-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> References: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2P153CA0037.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::6) To SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR01MB8049:EE_|DM6PR01MB5978:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fee38f3-28ae-48a1-bd4d-08db4c4316b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: LM4QxYw9i0OAzq0+TCAL7T/qq4aZ4DJt2fya999PVdFIDJBKTO8MNqs7xY2laXv7wazdSwIa2ePWCr7/UrhVIfw6vrB59Lo/5ug5sjl90kcm9tZqm/TYkFx2uDK0Zv55nHikS0L5VSdTuXK2W287jkROFUv959M1Rdg6vUKy+gGTrVh3RlcXAlet9gAsPuG4RlDA0ilUWofjaP4pdLa+upmYGln3gd5wPoHrb7VBF1QUCDZB7wB3hsEaoWSCbokuYj3NhQqIoOlQnjuGd2Y/6K0jD7llxmUCGhVTDz8uuWENqSp9BpY+DGbhzjPuaZAKdJOFiHPWyCCZtskaxbNbhRCoO4kBzSCF8p0hI9VFfc2lQmRKtLEMZyFVW/mbA2PqJ6gDy8EFQ3vw6RFlbkQZosQMEZbmlIlQONnWe4jovVGmPYmRGHXSv6zWtutfSiUqwq7onQS2k/DtgNAGIPPGNs/dLsnsu8e0h4F/sx0qiWKE2c/KBrs9FXPKlU+XPhDbER4sA/dcV6Kix6eIjSgOtyrlt+MvmJP0I/UCZ3L2mpdd56pZf7ZcOnhRz96LUeFxlJgOKXGrk8axd9dssDwZ0MidL7FXEydyugvSFkd24wVFQJTByA0g/5dtXc78iM69 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/wbMmr3V7u8UfqQYqVoJ+r89T/TO4+UBdgrgKCKZpSbop1Msp9AoWUZZtQqF?= =?us-ascii?Q?MVJ60FUAwWF2ae740Vlip58Yybh209KcdDd4rGZLSuDPyNVkuOqD4Bl7OLzP?= =?us-ascii?Q?JNXPQe5eDphLAPpyjHSSCkScrqao8V1qaBXCuLYXUjtXkp++4L4lHAkGY/SL?= =?us-ascii?Q?FbK54o0IX0DyhuTKvJ1wcY/s3GDst+lPhvhuWQusRpKIYX+L57MX8gD5rVim?= =?us-ascii?Q?p9TV1wL31318j8Rz4TKrOLTxA8yieDrgCIpL9gDq47RQez3FhyTg+F/kD4bV?= =?us-ascii?Q?5SGc3Ji8rFy+yk2n2CWWuDJLikTvxHKcNSH+Vpl/UOzoYLUprOaRuYhotPB+?= =?us-ascii?Q?f171DUgoujN/bTxWSEoVgXVW8jlzBWrxR63+lx4jmYa6DAUrqrWHY7PmQ0FV?= =?us-ascii?Q?daSFew/+o4M9OBpMTmhR7VkkjT4+z59lhWdOUdFvttFC617WhRk6p4qXBDc2?= =?us-ascii?Q?TNbOn2U4rhROqWRcEnBOXePjo/3NuKOVGFXUXywsYktoJ5+5F8AUl/U6V/wm?= =?us-ascii?Q?kGQB8otfJWEy0QYCzPu6zVS6d7KP6y4SgZEb8XI9JdY0RisATfn7puWuwQVe?= =?us-ascii?Q?St2/WWLlmu7c9cyuhZwZQNNq8+nlY/fTdGql8O7C/eR1KskGZUW3fdC/c5gD?= =?us-ascii?Q?6HeroUer9Zo+ZFeBtKKVV/PwA/GukP2ooEM/d2Diy71X6ISdJb+6ZSlFQDCu?= =?us-ascii?Q?UD/RLjtSQKbAE2BKP8LDkra1qzOuCJSZ8m1Ur7QhIFsiB9pjrmgWz+9ApRKQ?= =?us-ascii?Q?oyYTi22X2LUB+GJ+cx+2yz/aBdx0JNo4Se54Dez7tC8tzCgkb9dsvRvtnG7P?= =?us-ascii?Q?LmEiR7BJyj21cUamv+shhBEWemSMaxV16GOq6dEfMKnjQ6H8a8RMLdCCeAmZ?= =?us-ascii?Q?pKVRWdje5c+/et5gq0kFrAv40/GjBr5SR/6vVF0vy7ITGl40M9hdLzEai+Lg?= =?us-ascii?Q?/cll41yW98IzXg2VGCK0Nu0yXcJXWLPMF5BqA/o1F3AI3SbRumo8WehK+pb4?= =?us-ascii?Q?C4qK6ZsLe3IqOCOI6xXaAx1nhAjaJ9LW19+AxW1ORMdFcLcMB8txIp+2rE/x?= =?us-ascii?Q?oUma1BydBAM/+tejJJC0t/lecRQYMSXH7BwgG7s5pStOJYqQYnUoBlvQ5npv?= =?us-ascii?Q?WTPppWHjF/QRMq6tY0na0fhrM/47nEQgWpmS5G7rNe3hgmgqYuEs4+djUOQw?= =?us-ascii?Q?c2dvIwVCfsO3fH6tJ7Pvqg18almrnbYU0dalNbtxgMkO47P4eyjGhXHvcjtn?= =?us-ascii?Q?FDyLizouzRQCxOyjOqlFv+zQybQxNpWE86G0F9rKqatJ4HZDHY09KGPbTiMD?= =?us-ascii?Q?8dpk1/os/WQHZz3qi8/7NqWXb1IPW3j5Csd33WTIu8n+iWmdlMuYNXxr3wCX?= =?us-ascii?Q?6G13swbd+CLqVmjKva1KxNUxRbVfsYBTHytwjBRQyuIOys8vZGCv+Y5OxODg?= =?us-ascii?Q?f+tqMqjHXoheG82yDMCvVCUgApN+9ASYDcNjoxr1w8jS6rZB84k+MMr38PtD?= =?us-ascii?Q?QslrBYU6qeuKwH1VOI+CrphyddcVHJS/+iSSNOYzeLORZ1Otfk3rJq/G3X8o?= =?us-ascii?Q?du84m17JKBdBrXMlvZ9KzKcCADKVpivCUHxCeUQlnZiR4hefzSSGwdPrE9Df?= =?us-ascii?Q?w2GwGWXlcuiGi1HZRGgznguvP4M8rgh+GOzA8rmPvWVQ?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fee38f3-28ae-48a1-bd4d-08db4c4316b9 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR01MB8049.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 01:58:43.3182 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zWr3R6eHbUWHZSWCwLKwPIbHHAk9xxI+2PuoKQj59xtU7bU45sKblily4JjZZ28aUn4YJI+D9wTMcKrhoz22HmieumGzrNXzYy6JSgvz4oIOvfz09ND+8Hc9srj8v6UD X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5978 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: Oi3MiQNFkTAcJtmLjWM4aoK6x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683170087; bh=4FGJwddNVmScK4yRWnOIvflHNa7vQ8VQGX/C1g9P0qY=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=n7+XJB07whE2lkJq1NDRcEerT2U0jt63xbY/g3PnkqJxFrw0+SYg0B2eAN5Zcn/TW+V Y9iXNRLed+kVmrIEJKTxktkx7zlUHtcDYG2Suz75NMdTMP9eXWuHiAO7VCy19JYunrOZG q/Bd+Ii47bMorA+dHRp1XaF+3CgWfpbNRB8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683170088416100013 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen It requires a fixed size array to store the content of device path PCD. Add the array size to solve this issue. Signed-off-by: Minh Nguyen Reviewed-by: Abner Chang --- RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h b/RedfishPkg/= Include/Pcd/RestExServiceDevicePath.h index 91b1198297c2..57fc199f61f2 100644 --- a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h +++ b/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h @@ -4,6 +4,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -14,6 +15,8 @@ =20 #include =20 +#define MAX_DEVICE_PATH_NODE 40 + typedef enum { DEVICE_PATH_MATCH_MAC_NODE =3D 1, DEVICE_PATH_MATCH_PCI_NODE =3D 2, @@ -32,7 +35,7 @@ typedef struct { // 0x03,0x0b,0x25,0x00,0x00,0x50,0x56,0xc0,0x00,0x02,0x00,0x00,0x00,0= x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0= x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01, // 0x7f,0xff,0x04,0x00} // - EFI_DEVICE_PATH_PROTOCOL DevicePath[]; + EFI_DEVICE_PATH_PROTOCOL DevicePath[MAX_DEVICE_PATH_NODE]; } REST_EX_SERVICE_DEVICE_PATH_DATA; =20 #endif --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103941): https://edk2.groups.io/g/devel/message/103941 Mute This Topic: https://groups.io/mt/98677251/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-