[edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg

minhnampere via groups.io posted 5 patches 11 months, 2 weeks ago
Failed in applying to current master (apply log)
RedfishPkg/Include/Library/RestExLib.h                       |   3 +
RedfishPkg/Include/Pcd/RestExServiceDevicePath.h             |   5 +-
RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h            |   3 +-
RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c               | 153 ++++++++------------
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c           |   4 +-
RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c |   3 +-
6 files changed, 73 insertions(+), 98 deletions(-)
[edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg
Posted by minhnampere via groups.io 11 months, 2 weeks ago
This patchset adds necessary changes for RedfishPkg to avoid some unexpected cases and fix compilation.

Changes since v3:
 + Replaced __FUNCTION__ with __func__ to be more C11 compliant.
Changes since v2:
 + Added "Cc:" to maintainers in commit message.
 + Corrected patch format subject prefix.
Changes since v1:
 + Removed redundant change and change the commit message for more precise in PATCH 2/5.

Nhi Pham (1):
  RedfishPkg: Add missing newline character

Vu Nguyen (4):
  RedfishPkg: Correct variable type to prevent memory corruption
  RedfishPkg: Fix condition checking of error status
  RedfishPkg: Create RestEx child on selected interface
  RedfishPkg: Fix compile issue on Linux

 RedfishPkg/Include/Library/RestExLib.h                       |   3 +
 RedfishPkg/Include/Pcd/RestExServiceDevicePath.h             |   5 +-
 RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h            |   3 +-
 RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c               | 153 ++++++++------------
 RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c           |   4 +-
 RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c |   3 +-
 6 files changed, 73 insertions(+), 98 deletions(-)

-- 
2.39.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104149): https://edk2.groups.io/g/devel/message/104149
Mute This Topic: https://groups.io/mt/98699661/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg
Posted by Chang, Abner via groups.io 11 months, 2 weeks ago
[AMD Official Use Only - General]

Hi Minh,
Please add my RB for 3/5 in commit message and push to minhnampere:Adding_necessary_changes_for_RedfishPkg again.   I will check the PR and merge it once it passes CI.

Thank for your contribution.
Abner

> -----Original Message-----
> From: minhnampere <minhnguyen1@os.amperecomputing.com>
> Sent: Friday, May 5, 2023 2:46 PM
> To: devel@edk2.groups.io
> Cc: patches@amperecomputing.com; Chang, Abner
> <Abner.Chang@amd.com>; nicklew@nvidia.com; igork@ami.com;
> nhi@os.amperecomputing.com; tinhnguyen@os.amperecomputing.com;
> minhnampere <minhnguyen1@os.amperecomputing.com>
> Subject: [PATCH V3 0/5] Adding necessary changes for RedfishPkg
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> This patchset adds necessary changes for RedfishPkg to avoid some
> unexpected cases and fix compilation.
> 
> Changes since v3:
>  + Replaced __FUNCTION__ with __func__ to be more C11 compliant.
> Changes since v2:
>  + Added "Cc:" to maintainers in commit message.
>  + Corrected patch format subject prefix.
> Changes since v1:
>  + Removed redundant change and change the commit message for more
> precise in PATCH 2/5.
> 
> Nhi Pham (1):
>   RedfishPkg: Add missing newline character
> 
> Vu Nguyen (4):
>   RedfishPkg: Correct variable type to prevent memory corruption
>   RedfishPkg: Fix condition checking of error status
>   RedfishPkg: Create RestEx child on selected interface
>   RedfishPkg: Fix compile issue on Linux
> 
>  RedfishPkg/Include/Library/RestExLib.h                       |   3 +
>  RedfishPkg/Include/Pcd/RestExServiceDevicePath.h             |   5 +-
>  RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h            |   3 +-
>  RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c               | 153 ++++++++----
> --------
>  RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c           |   4 +-
>  RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c |   3 +-
>  6 files changed, 73 insertions(+), 98 deletions(-)
> 
> --
> 2.39.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104104): https://edk2.groups.io/g/devel/message/104104
Mute This Topic: https://groups.io/mt/98699661/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V3 0/5] Adding necessary changes for RedfishPkg
Posted by Minh Nguyen 11 months, 2 weeks ago
Hi Abner,

  I've updated. Thanks for your review.

Thanks,

Minh Nguyen

On 5/5/2023 2:38 PM, Chang, Abner wrote:
> [AMD Official Use Only - General]
>
> Hi Minh,
> Please add my RB for 3/5 in commit message and push to minhnampere:Adding_necessary_changes_for_RedfishPkg again.   I will check the PR and merge it once it passes CI.
>
> Thank for your contribution.
> Abner
>
>> -----Original Message-----
>> From: minhnampere <minhnguyen1@os.amperecomputing.com>
>> Sent: Friday, May 5, 2023 2:46 PM
>> To: devel@edk2.groups.io
>> Cc: patches@amperecomputing.com; Chang, Abner
>> <Abner.Chang@amd.com>; nicklew@nvidia.com; igork@ami.com;
>> nhi@os.amperecomputing.com; tinhnguyen@os.amperecomputing.com;
>> minhnampere <minhnguyen1@os.amperecomputing.com>
>> Subject: [PATCH V3 0/5] Adding necessary changes for RedfishPkg
>>
>> Caution: This message originated from an External Source. Use proper
>> caution when opening attachments, clicking links, or responding.
>>
>>
>> This patchset adds necessary changes for RedfishPkg to avoid some
>> unexpected cases and fix compilation.
>>
>> Changes since v3:
>>   + Replaced __FUNCTION__ with __func__ to be more C11 compliant.
>> Changes since v2:
>>   + Added "Cc:" to maintainers in commit message.
>>   + Corrected patch format subject prefix.
>> Changes since v1:
>>   + Removed redundant change and change the commit message for more
>> precise in PATCH 2/5.
>>
>> Nhi Pham (1):
>>    RedfishPkg: Add missing newline character
>>
>> Vu Nguyen (4):
>>    RedfishPkg: Correct variable type to prevent memory corruption
>>    RedfishPkg: Fix condition checking of error status
>>    RedfishPkg: Create RestEx child on selected interface
>>    RedfishPkg: Fix compile issue on Linux
>>
>>   RedfishPkg/Include/Library/RestExLib.h                       |   3 +
>>   RedfishPkg/Include/Pcd/RestExServiceDevicePath.h             |   5 +-
>>   RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h            |   3 +-
>>   RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c               | 153 ++++++++----
>> --------
>>   RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c           |   4 +-
>>   RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c |   3 +-
>>   6 files changed, 73 insertions(+), 98 deletions(-)
>>
>> --
>> 2.39.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104157): https://edk2.groups.io/g/devel/message/104157
Mute This Topic: https://groups.io/mt/98699661/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-