From nobody Thu May 2 23:39:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104150+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104150+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683306766197734.3711954058176; Fri, 5 May 2023 10:12:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id zSsQYY1788612xRXj896EWd7; Fri, 05 May 2023 10:12:45 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.112]) by mx.groups.io with SMTP id smtpd.web11.21029.1683269192559761346 for ; Thu, 04 May 2023 23:46:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ACb2O4QK9CLANo2RVfTTprQuGjDKyv841cjdc6DEDes8iDRsSuG8yEF8I25phIutrZ0siUwTkQNxKd+j5S4Kh3lKr6HvzHk9O4ZGezBKUhxfz6qfvKQfEjWXRJd5KBkPl7+ZDQnAdfOHjH0gt5L/ltEa3DbdoWPsw+0oHCtxOZCuHL+kg5fC9gfzlCUsBJcELzJDovSy02BolktTN+uDQypKRYpso0q3Sr8Uwmy63sgRM9aKuF88ZnSzywCh2o29w3dSnZ+E0vzTiuuAJ3bMzf2q691AlUhaPcWCzDymnrjpan0MCIG/w2TbJTpRo87r6XBm+Vebvcy+E4M/YmLXqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=35uvj5Ksz/2/Lk61WIfbLpSL01av76B96OAsKjjzYps=; b=ZcoJ8jKea7h5ggB1sS/CZG5xqyEXReTckMbCedeMetGNnder+JnMCVmxBpSrxwp9QSjPDltqEdPaJnUafIt8Wqx15xkSjuXdHeUaSQBb9DHpxUzxD25jctsEYFeNdzwU0MNQzJsmpBAiyTwARwpSIcosI6XP90iz6b6i2pGNz5Jv3PikXMqWF0SxGOBrnRGFrAPu2ms1WsA3/CubT7kDwFRtIPKSE7mB7Io/QEV6QAG5/Pfc3VDA6X/YL4SBJhjN3M5Gwz+0Juf4OQRU5LbyisN9q2Vzjtsk9A5wjqnzP9aIA3HgYKaS4Lw/quXnGaw/SQabsb/EHEJkyda5IdUtBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN6PR01MB5087.prod.exchangelabs.com (2603:10b6:805:b8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 06:46:30 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 06:46:30 +0000 From: "minhnampere via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V3 1/5] RedfishPkg: Correct variable type to prevent memory corruption Date: Fri, 5 May 2023 13:45:56 +0700 Message-ID: <20230505064600.1478461-2-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> References: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG3P274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::17) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN6PR01MB5087:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f8af5ef-2a20-4f9a-b0c6-08db4d3474d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: Zbm+UADXW6tAp+uzBLiVhAaw3nfysLwUaRDrUheAwgJPLlsnXZuUsBEOqiGhEwB3iTmDFEdBFXfRnHS3vJTKQCV9M7YHvVtdUx1E4gBr8cpYzJHiKKC3h6wV7VZRkWMd7FxUiJHjkHvdFl1CTWxNpP7udFYc7fRUsJ8V5G3mnMLKEoVfcHAugcJZwl/iV6Y1LQMlIT+xK1G2/yws5Vq5/riZaDXeTUrdiIZbCwZhgnwg42/F2NYMnESdKZVU2BE3p/OIp4Klt+qqvmyzDGx21hPSsjcvkW4puFKkz62VnfXDWuRQrLxP2wscyEMW4aAvFfI30og1JO86SLSsVwvfFjByF1Xe8GX37SvwvSuUR5t8sh1ijJyxhjrbGEFZ+jeUJQiAkEaAgAb2qHAj0tG3kVQqQmb9OmeiisAMwBXLMk5I6VwojOn9jLd4fOy65/xy0NlUzNqd3bDDXNAZidqDcFF5Sy2KwrMK68z6o4LeP5Y43HVA+43wlhejSpb+noWDs2hFmlUoPlbDVtoPZCpnyaoaxDZzPAP7Mpy+/wOVqGdDMoWTlcBEPIHtgq413QCkkIyr9mEjB6zOLk8xUi5qFrTg3VI6y/S/W3y16c+TnYKova1znYyNEHp3tqJpyjTvk2yYM0TbBa6WHTEXB5gq0A== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vJQ6vOG46rODhG2RYgLE2+1uiajTG/+l4TguFRQ8C17XY6RkexP6lzdKuOu8?= =?us-ascii?Q?Mr4dLlpcts0Prr0g0nNlJpIzK4ZcJlZJR0n5px2chxSv7trHirWs0pCmLq4f?= =?us-ascii?Q?G6cHUMgmLfUv9iz+LbQOBL2ZeShict5VoZpXESevNKGkRKdGYD15+4GLpEVm?= =?us-ascii?Q?D7Z/Hijjq0kf5t1wonIQ6slaLblh/VDnYcnFTsyRuEwGguYcLw3u3Dy6lQW9?= =?us-ascii?Q?yJmIx9AQhSgN+1x+Udd6bvShhJxcEkDMJrjMmL4gxFDcM8EOIL6nPRMh1MNK?= =?us-ascii?Q?kyBQUwRS8R9EtWW0DJgVMXD06jfWWrxmDAzlH7kV8aBRzQ1Pqej0EyT5NAo0?= =?us-ascii?Q?AiJaPD6oY2o7iRwpoT6V9v+apiUReU3CPP76eaIPjObH7D+1pgvkHqePf8lo?= =?us-ascii?Q?U8+iDLdliaIzvZXwvv3JFw4vxhFR5ZgP/tJTiQG8Ph0LdjvYeb7d77afB9E5?= =?us-ascii?Q?6yT5N2yNVpgrXdvFvLZu1Qlzi3I2DysoFtDDPp9+OxAHKb/Jp4e4/oS+i9qi?= =?us-ascii?Q?sNYk665j8VsOhFu/DYTUZJESVsINy9T5R6JC/xuUgdcLkN6ce8ZRca2pcZwu?= =?us-ascii?Q?nXcI+m9vXB3NZDv7vromMGCJbEcly3sZ7Ocb5XGdkxs5MqBxQTFmlXATUBs/?= =?us-ascii?Q?nTUKI8eJPjs6uLck3cSVwZGXE4iS9z1x2YPfERAD1dsStmLD3g3PoXQnAyV/?= =?us-ascii?Q?nXLkIXiP0dQpkFzQfyEfOitTRlPFv3LPz3o/w6U5eRG9d7a9kdpql+YtQRat?= =?us-ascii?Q?K6LBOGjFnd9XzVnqGP+6UvYM9DR7s/1+ZEJvx4US92ABhB9ng5Y2EktNWKPE?= =?us-ascii?Q?40JMbqYEWf/e+PN7GSeTmP9AY7ezdv7IkAf87JTHS+QJ1TYSEt5qlQHCJbqP?= =?us-ascii?Q?jF736Sti4SjMUeQ95U6fG/Zf4Fyo+bD0Mogz98Zi1BOFvlyn5opHKEy2c7fB?= =?us-ascii?Q?Y641s7PVcjMEBJmVnZ+8yHndAhXCO2z2h8zB6Je0iBbelpd0VF06piZM76gR?= =?us-ascii?Q?i6tcySlBvi8udmO4CDNCvO8nUnUDy4jvgaErG5Yjzd77yV/1/sCT9BWl1BIh?= =?us-ascii?Q?pa8C8lwj37xuqPVSFZBmI10tk6JUo9Lc20kU8tRrc6KvNuc0xgMai8Ydqn2n?= =?us-ascii?Q?FQgv/jXh7am3DvPfb8Z//JGpuJt+niLOp0Rte4uWHl+0+9dv1IsoZiyo/APj?= =?us-ascii?Q?OJ3aTWBzsSFJIvWEXThBhv7IjGKHxq1xWkUK4F/X3F7r8K+wNZClmqPLOUd5?= =?us-ascii?Q?VF+5MhrDBlFZUCHbtEV66es82O04lD49mse21iAQW2oluYsX4yhvwaoJQ1a6?= =?us-ascii?Q?HvcYPm4gr7pLJxTAQgtnPg0eY8gTt2ZaSLWGI86cc3sKSS2SGLjGzmUlaA+s?= =?us-ascii?Q?dH4jl7pSd/376Oyqt0v0Mq/TJ6kZj+9sCwSN21yH/lHkAPvGQYnAmGPFobkr?= =?us-ascii?Q?h+3M1ErylfU/pdQMA1npVd0ZaPpxfB+hVZBK4Ph4j3l5s1MvpBEHPjYsPjnZ?= =?us-ascii?Q?/VLmsvJMBXOnWEyvpKt/Hw2oeBlPGGGk6p573l8qE6zu7p4bqD3ysDdvmn6o?= =?us-ascii?Q?dIuGsnRqA1GKpT4CVG6bfPLTdQYu/wghNj2Pxfg29JUjwNBVfXCoJ2ZnihLv?= =?us-ascii?Q?g5ejow6wUjn3Z7LuD96X3iJvJalc8FrCDswVmWDGBH0c?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f8af5ef-2a20-4f9a-b0c6-08db4d3474d5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:46:30.0945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +LgT2j1MYRIaGPwujElz++jnfmrIOJbExedm79uCflyCmxX/kP0k5MOZT+QKAA+Mah/fu4vA3S+Xu8lm2dw1ygApGzdt44Ff+ajz0NfrgoJ6j87GhAsxpYu5sHEnh8mT X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB5087 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: x7fTDTgxqzYIpJSxDZo8EAfMx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683306765; bh=8tYL0ENug+wlc5QxILJOEk5ID//zc5SyGevyuIFrWd4=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=m1fLJsrHEZouvmmXbAv0JI9gI+Wt3Oixa6fYzDHI4wf8k5E3mzBGBOaV9cU15R4sxeu KsFzWlO4H+2WvWPZNgj30Bjt+vYEIBy5CMUHiKLy5TG/pCjQd2T6e30tPkPEccLhWE31c RzgCm3WrzCwGoIkTN134hySwUKUM8yoCZ1M= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683306766579100039 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen Id will be casted by CoreOpenProtocol, declare this variable with a wrong type might result in the corruption of other local variables. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h b/RedfishPkg= /RedfishRestExDxe/RedfishRestExDriver.h index 4a9e9f7b81a4..6b94e5814c43 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h @@ -3,6 +3,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -84,7 +85,7 @@ struct _RESTEX_SERVICE { // EFI_HANDLE HttpChildHandle; =20 - UINT32 Id; + UINT32 *Id; =20 EFI_REST_EX_SERVICE_INFO RestExServiceInfo; }; --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104150): https://edk2.groups.io/g/devel/message/104150 Mute This Topic: https://groups.io/mt/98710280/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 23:39:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104151+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104151+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683306767029845.7599619750678; Fri, 5 May 2023 10:12:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 6kqwYY1788612xMrrQWd8qDQ; Fri, 05 May 2023 10:12:46 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.135]) by mx.groups.io with SMTP id smtpd.web11.21031.1683269195013177370 for ; Thu, 04 May 2023 23:46:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kn9PTwrE4s10RTvLdhrVYKusWP8TvckOIFa+C1lKlofwqMDJA5GgNSa6laDJTPNPCYudPX4D0m4JjcTDsJtx8oJFMMIzaXxsHBeajorhgJmBpVpVEBFXER/nHs8pOa1ZC8O8NISVOfYA0zWr2Wq+xysAtt/Rf448upBWG0iU1rnLCigVjzyaGRyISexPidXQW5TEecrCFQMxSz2YJqHkQc5ZfIOlhCSJF5hXBeO5peWxAyYOjAzZ1Eu2VLgOPscQycAOKLJSAOle0Z3zw5NGcADBJiMa6+0vSR4hPMQu9P6wBxy5ZT7d5ONmcDJQKp4p3olMGeUTXHIJMaeM7AGdJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ibXkIUL1HAHNsSK5dzTFUmCmEAR2DExKnnrxmlpYwe0=; b=M3xYolzgNzMpml5Pzkh7eUPk2cF++5VRBpalKxdwYf2frIi1hKFMwDVdoO/Z2TgFNsUKRjtrTUZ5Doah0EC2Y+J79hL8l5eXAn7iFurPkBqh+fQZXQPca3hBdA5WfGR6NIFYJFMjq/ny5xkSOCyGp9TseUN/eOq2odZl+dvdSSyyRhWDyHn5X1XR7ijgrAohMvNOwWEdQLm9O1fbZdNKUT4YnBsQORbkVReTi7uT/Yl4mNkXwwZ/jYdZ1fEdb/9Jy14KBrahYG/8XPCX1c/5zgFudGyBWuDQStWiENY+F+//capkESUvLpcULm5AgAkoaECYQ3IMvPmFfsx1IVfg5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN6PR01MB5087.prod.exchangelabs.com (2603:10b6:805:b8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 06:46:33 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 06:46:33 +0000 From: "minhnampere via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V3 2/5] RedfishPkg: Fix condition checking of error status Date: Fri, 5 May 2023 13:45:57 +0700 Message-ID: <20230505064600.1478461-3-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> References: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG3P274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::17) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN6PR01MB5087:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ca07748-b3d6-4c2d-e44f-08db4d3476a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: veiM6mEXc+4b/CCv5YajA4DOs5GAryRdq3sn5R1tVlt339K4fxDdOqxPaPrgW+49PLHnzGtl3Ik42MCq8KkbrLfQcpCGtj4kUdzc/Xb7Atc+a0fWy5PbWq1nIGDyfPcgGnXZETYFPHN/3/UO0cWNCQHAO/FIpgUWZeLZiCFloBaRvUl441qsjPIFp2ZlPAPrZKPW971ZKrkfBj7WXSlUY5vUcCz5qu+hUoKXN3+xhkkQGBxtdor6m3MFdk3hrrWMw5oB809WPE2/S5WvextFEU0cI9Z1ZbEjitnZiY4Nrm35OjEizHXLhe7JTTsA37EAiAYmaDDI6A1Om4pIB4oqc33WrWP5jMRG+itU61gg3xrNRC+CJAOcLB1G4QOqJgQvSgWvbcfCQyDs4q6CZMUsx0SwjjQtDdjOjyyDWtQMoDJk5ex7MRkQskWwmbJqtb7/6t8oj1mNWkEwdNCpFfSS1W778mBXuEzOWrFtfDveGJLazgcBsnirnN3G4Eb/0fVevdj9DURalPX1TDGZvlJxv8zit5t/rq8BMYKHO/lgCLIcLfkOnp81hT8S/vmUjZ/ZCIIMVx155etJz4jteWD9X5k3emaOgnu+cfCa+EqA1K8ypoVQsGAw5jrwoSePx5TTFD1dsRHfTPkNMV/OPVxnXQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ytVWC3ndQg5wk36W10wjNgxUj+0xjT23mnjD2J8gWv65+4W8vAXc1/NK6XhK?= =?us-ascii?Q?uqCHFn6CSnjeRModCUYpEVwpxUx0jlA6M/BGwQuqS5XAfUWUXfZeTLanAA+n?= =?us-ascii?Q?qV1/deQWOOwEZEPJ/o0MKUYoUaCE1mHaBNXkAYHykLbYN5yclJmVGfyXdbHq?= =?us-ascii?Q?dPemciiXQNAvUOfRvCPvo/3o+bz0d205x0riwAdvVDQRqr00WiTVr2tA9pQ0?= =?us-ascii?Q?KCNqlBCnx/oKWmfGgSoTHq2n+DE1TneCdrQCZx+NnG3LIp4Q10U2QLotvCIW?= =?us-ascii?Q?1mU3apcNw8zJFlqgN4O8ckGvdM/93PU7IIcS4a6ifdXL/kB/L33pzmEYhyxQ?= =?us-ascii?Q?tOOp+mZcHSgP7254JjbAZGwA7H8itAGZUEBa78ZjQRerH6ixktzjmgQZVnZM?= =?us-ascii?Q?NZ7kJg0n+2HdXJjY35FUBmwWR3d0z9hTuI9kKi5D4GpTOml36lFi4GCW8My/?= =?us-ascii?Q?sdvc3oZaXP7U4+J6wPRFGG6UlZaoYgYpfGA6drNkohm3R7qrHAz1s2QipGSC?= =?us-ascii?Q?LFdf98b4Edob9i9wKcrDm/Io5FGkce1JO9tV3f9TTzhfCPLvMQ1sENwZflFP?= =?us-ascii?Q?kFkL2iXVIJyeUlXILVOavY4Ff7010T9aPCvH9olonGmp9C6heAMQvLxLNOtD?= =?us-ascii?Q?0H0av96wFgqfSRTy2ltCQPc+Bw8AAPT9UlWjeGjs+XTho6b7qmM+jYNFeuGi?= =?us-ascii?Q?EmpsC+mdcTRWBIx4Ptj5RM7j2ng/H6OnJZ+JClFtsFp8KrO64HAoF0oZk+fd?= =?us-ascii?Q?GHntlscNpdMAPrlVqys7KD6yt0OBRUplRVrjDGZpzYAD3kHnTxEkpIXLpVJ/?= =?us-ascii?Q?7CMMso/sFVbpyCwvlG+06S8KmAlT6vAv7Id7qU9y48lg9hBnTxKBtO5LlLAW?= =?us-ascii?Q?QQdZF62RBr6m/JgBFkeWfHHiL4QJINljytNuzEf43mr/P/a9e9lPOFkKdwWz?= =?us-ascii?Q?x+FIupZSNl1I4jKT8RG7E1Acfyr4kcdMkCde2Qvhfb+Ns/4LnQVk+i3tPAT5?= =?us-ascii?Q?3ruz1WzL7zgAOAE3YhxVgM3zgituOS21gXx6qx1oRpMxe7J8dp67/lt0BvbF?= =?us-ascii?Q?Ruu6A044CB8fh5TjH8hEDJCWlb+k0+iU/G07EBum0DYC1v5L1vUDK0qTlILa?= =?us-ascii?Q?prAHUKNV9fOFH7nFFboMDvabqWzo0ceyOumZgrVcEoCVuXhnvNPZsxpv0LW3?= =?us-ascii?Q?2d/fRIZhVce266H+V2g2ksFEtP8Nxyz2ONOaFuSCaiFJPnR9kh6RmPsH/WvJ?= =?us-ascii?Q?mPnz5wdNTe8+VJPb7v3ZGu/38dPiGd00YrrgMUZw4zvSF96E9fGjDLOJBVu1?= =?us-ascii?Q?6cYpCkGxjaOh6n+RTMIU7pBKA9hNyCDSTGfZiAVmY9NreZ5YG4/RCcNtVCUS?= =?us-ascii?Q?SrhmhkqA+nknL3pFuAKgkaxKh4zhxDhHJndZFVOaoOrmkwLyEwjRx077vFzQ?= =?us-ascii?Q?dPqt5wufmgOwk2hrX005iBrshFS+4lwpKe56qP9Sph9zUBkQd+m4eA5KA1Zf?= =?us-ascii?Q?RhvZtcKWCImHdL4B+ctBX4nPUrujxRUzeLpWSTykD2v01DmtmNqvGPPmObEp?= =?us-ascii?Q?TAlOnmf/z55xDaYrhbwCdxjc3t8bydoylPy7Hi8JEgZZ4EZl6thKNXOYaCoI?= =?us-ascii?Q?HdFgdS48NFV3tLBD/4enJu2LL1yJbe/BVeaOhYbBPTv+?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ca07748-b3d6-4c2d-e44f-08db4d3476a8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:46:32.9517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vjl+jHl/OhnRCa5Jb3BTrADzUdhp9oLM2xC85bWoKDNVCWjuhkvAppy68PB8rAzphluxvcytVVLeQ2AsydoOq8luJZ6mijHZGr6PhPTRwuAJr53gWyaTqEhPQLj1qDW+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB5087 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: 06oRbaQVOjPih8P7yPUE0ZcVx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683306766; bh=tz6+8Hk4cbBD+Q3zTnGwDoDITOWJyDg/62n1TdtbQAY=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=HPlwBKvuVPPiZ2lgYouI2YnBpmiZOUGuC0IBg86HpZ43gNQquXsSbtTK5w0AGsQiD+k Us2Jpmgbbv7/w3P5xHYZt/VKq6m44tT6zQBCeGFenqbR0Wpe02MppexdM9APYTtZ34hDL IFR6tZDsidGSsDKeOmqKaslM8pNEdSAEYiU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683306768557100057 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen This change fixes condition checking of error status, the condition should be compared with TRUE status to be identical with an error message. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 0900a2479e7b..14702748813b 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -5,6 +5,7 @@ (C) Copyright 2021 Hewlett Packard Enterprise Development LP
Copyright (c) 2022, AMD Incorporated. All rights reserved. Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -926,7 +927,7 @@ AddAndSignalNewRedfishService ( } =20 Status =3D gBS->SignalEvent (Instance->DiscoverToken->Event); - if (!EFI_ERROR (Status)) { + if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__)); } } --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104151): https://edk2.groups.io/g/devel/message/104151 Mute This Topic: https://groups.io/mt/98710281/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 23:39:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104152+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104152+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683306766227189.79323903385034; Fri, 5 May 2023 10:12:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id pq7SYY1788612xhoDJ9Fqvne; Fri, 05 May 2023 10:12:45 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.122]) by mx.groups.io with SMTP id smtpd.web10.21112.1683269198533042841 for ; Thu, 04 May 2023 23:46:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dI0cqgDffVwmOTAG4KLjg2lZeoeXwB5tYpYfhMQT1C+YbzasNrlEzCwSGUltYj+HfV220a4uPZaAFflKhXh8MruYmnYZGVnW/sM/7KFG4oI9SAzqcTFGISkHUzAZykeVihrIwRyn3G7dUphAJ40h8QjIP1L2PeBEfWqdMnNopid0K8DMkyIRe0/nFkeDE6lpgSQhWSsvhH6wbNTbNvBdu7PpNUnGeOtD6ElobAeO57n+rhgMAtLaRnuGDLiaRyVH1+v3jcnK5MAvAzUxqV+oqh6b2hvIvbvB1JuEW4u1+68gycqQLlaOc11AfvDKCeVaFf+UsWOdMLMzLjgqLlXDKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Ix8DAkdu30eL1JNHynVYagve+VFUfzJnJTm5JfoknU=; b=V99N5FA1OAhyNN7piG5ZKrBcyi3OzxwIUtDPIZTBFxacYgRP79gE24PQd8rEvja4NLliErAYUtUhPdmQgi9vEGsYxBdarpHNVyaOmQY7cRgwFmfp02GuT+fE9sxUDV7EdjuiXXEH7Jnm4F5m19of+ESp08yYRES/QrgAFWLK1yE6PwdR0RXIVlVWvt/lt67SyKtKy9jNZMWg6kQO+qFeo9jHwO7wN1aw/CrFA2RdjDs0BQ4iBvSGBJnVlwMVZYDlSMCK82MWDvjO9dDoOLWb50/xdlaCqcEST6dqcK7oPkvtIi3VVjeCibIiu57tNg4OzMAp2YkNTIy6R1oegt+Z6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN6PR01MB5087.prod.exchangelabs.com (2603:10b6:805:b8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 06:46:35 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 06:46:35 +0000 From: "minhnampere via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V3 3/5] RedfishPkg: Create RestEx child on selected interface Date: Fri, 5 May 2023 13:45:58 +0700 Message-ID: <20230505064600.1478461-4-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> References: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG3P274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::17) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN6PR01MB5087:EE_ X-MS-Office365-Filtering-Correlation-Id: a1dd3d22-2be3-4a32-bb4d-08db4d34785a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: XnLY/qoCzzi+DHKFz0s4gNimctWrGfwfbDbzFz/RScoloCxWlhwI+ASyl7QKl7j/4951V7n7pQIIfublhUv6sOy6YPfeJZyL0M8li/7MmpCo56NbRjD1rfZ6t73xn21vIHD+B52WoSaLQ/FZz3xZ3IwTQBn42rRLN/BdkRjxy1ZhnedtKKRpwWlGwzUO6lMn7zs0T4UJl0N00lM+HQTfXUxBCOTJTt4cQFc3vSrZp/zVrEPMnNoCvcEiKc9njPXwSQilBZwmi4LDwc+6M2cnRl/TZU4SmbVxC3u/QXe7uKAXMqU2qF6GBiaXqGusjQq9y2lXvAam1TE86ULFCggO+xgsMIHHxpnkmHGrRWRdcYizYbH+DchO0hggbChcHmpV2x9Oo4ehTepEnnOv0nY8khvj7/5l2SSNABfLkqFpLdoPzMLPitos4S4g6EjQBmtG6UHWbYfg5cuzUHbS3vEiOlEwfBJsXBCBnoV0Xk636pm0ytQ5FjnyBLNSg7QkWDNNr9LHs7sCp80TxQnGaQkwS8Vc50ldKvn6MDd1vujrRVHJARW2ACoUDLg4xyTV6C4rqav/Jxb5Ny2NX3LswYUqlw1nwenHkwnDgkR73Fom8xWvEMKknLww+6pMVijvNWLf/924UmToNmXhuoEfj/e8Jg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F3YB5Q6eufZqD8eX/cHWashvLV+15Odm8baDQqKRQ5HZwSay0d4F6Ywd9AKh?= =?us-ascii?Q?N6efS/mbvoE4cuDt+LYoehEtXT5bDClNDjcpLs9w2mKVQxyePWwAtGt5Lz3p?= =?us-ascii?Q?ULvxe+9JJqalNDSE1kbwusIVT2I7ryGSx3v36o6q3abOyO/O+Own/uWL4lIK?= =?us-ascii?Q?TtG7zeZ7IV/pXANb21d5O+UmI+UDvROo+5ukUtLG0mAHbnd9uxy+7Vy9tkYU?= =?us-ascii?Q?Jlq86hz6BhnHXKzrrKbA7EHFnuuT/pGV7jHIDyBwD+HHmloMtDw2m54QaIf5?= =?us-ascii?Q?hPvqm8ndj2+zGvwGvCJz/cEq5nElaSO/nRJcgy1uf5+DfmggawHQDYLdzm05?= =?us-ascii?Q?FLlb6XzqUebeB6kvLB/hsFDczvFu1ufBs1t5PgmAxhNa5WBTko5DTFBWwSQ3?= =?us-ascii?Q?mJUgb8nlJ6WL4HXVrOq+zFcksMdN1HDsY/QzZvtp54L5vv8WOWuNv8ghwSMt?= =?us-ascii?Q?QnRajO+5JMaHEy+54wsoudE6d60wjv+NcVV5eQNc27RyZ39TN32PbVYkmJDI?= =?us-ascii?Q?kL4VMMhjn9aayB9CDkjqShL991VfX+F3VAtvWRbF5qPHHnPrhcRv/gZV5bUG?= =?us-ascii?Q?iZVR2M8O5bo+/CtOsdeDXljPkLUd54Qxf0Fy4tS/zOa7Pn/Nk57XRkInSTQ7?= =?us-ascii?Q?K17DqBB2XFxkz2LK0sV9PIeUj33wp9RsL0QdHwL/Qqx51R6XH6t6IPuPM1Jx?= =?us-ascii?Q?b1Wt2wtNpEFY1hh4GseTV3pMI+Sje6yVw2PaibcORajujiSJQbRjG/K4u87y?= =?us-ascii?Q?602PWeYRtFBnBWpmKXlIn8PZkjbnhA7YMZ8yjpDulSDjrFQN7Bnnb8HL4Ll7?= =?us-ascii?Q?wN10GArwEB4+mFVbYUd7CA37+u05649gAZUhJQhs/d7QgldjbBHPPdX2+EbR?= =?us-ascii?Q?5E1BOslM8v1UrVTDEhX9R6SUQ2lQgrOwQeJ75C2sQBHCSIxB79KvSi2Ae97V?= =?us-ascii?Q?DBkrP2Cl6VcBp89E82lts1/6iQvdsSJ5PNOtf2Xhf3L9hM7H1+YUy1ix2GNb?= =?us-ascii?Q?HcPfg8hXeyV+V2HC3tEjdWwnGVpaqdyPZS6lReQbG2v6mFxZOvNgbZiPE+oT?= =?us-ascii?Q?jqx094lbBEIAG11kA1dRcfo6aNGlq0zMIcrbgsAEWY6eGTo4ZHiAwD84Ydt2?= =?us-ascii?Q?laIwjCMqK3vXFwhMVl/Ki2hL+xoDVXZvJqNfOEiLycaWVmgG1KCLF1K9dGq3?= =?us-ascii?Q?jKErAuqb7j6s/OwqcJ5MMfzpBVdn1fxNvFFylgD2LJJ3os4b7i+aMnAnOe57?= =?us-ascii?Q?7N/alsdRovQhWG49aMY8k3byPc2nbgzAl/QeiLT3Wej3vAzUohsUnFDfUfkr?= =?us-ascii?Q?PnhxEgX+aXWPh7st/K+sAvtBih9rS/yVMGkOmU/jc5YgdUtTGPzKSlU6F8Z5?= =?us-ascii?Q?I0u9tFYHWj++R3BwFin6tMi1LqP9E/QmANgg3hDV79IALDHq9XDsKe34D8Zf?= =?us-ascii?Q?47VSpQmEvpBuE9j1xsRjotubO9Br98XSTcKXoiBbE8TfBdkyd5ZrYeMgVQBG?= =?us-ascii?Q?W08CUw02NRNGLx5j3MsPqqQT/7HHuPTjVrcY83Qkph2aZl/5hwjHN9ByRKmn?= =?us-ascii?Q?k4Q1lpT/9XXKAwVAs028hIDefZf8xKexiVG273BFuvo48XkVEkFFtaAlSDOh?= =?us-ascii?Q?CyqD8D5BHjTy9TrTcIFXLa6k73JpR9SuHqRwz8oKwbWv?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1dd3d22-2be3-4a32-bb4d-08db4d34785a X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:46:35.8047 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: czRuq8JQjYnsS0b/fFnK4xfJs/a8jsPYq1LfjF9tbIbsCHVSmzQcvp9g3ctEUl6HSOKrPfqg2sj7w92ksd/IMNTkRm40u4nilJ59BBje0wotFSPxCECtl8XmfbzLsF47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB5087 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: U46cJ1bG1qrfIpwbJRGXgZJlx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683306765; bh=L/aSUrvDsEF4+9JI/4uTF28c69WIVu5v3svYXhrY6vo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=N7CRovg64WS9ZhNtgrBDZ5SUAr2x55sygpt7fzprcTYyq2YzbS9f4uO5i3Rt6SFR6r7 MbL3Igpjni82D7OKYNpxx8VzOVOVJ9j8dtzg48G5XEdxQ5U5bQqoNbM7oaV7ufWqjy+ro wTRvToQTMAF3pTQg8WESzATdLMxsmx/ANuE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683306767472100047 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen When a MAC address matching interface is found, a RestEx child will be created to provide the Redfish communication on that interface. Currently, It will try to locate all RestEx binding services and choose the first satisfied instance without taking care about current selected interface. This might raise an issue on the system with multiple network devices that the RestEx child was installed on wrong interface. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Include/Library/RestExLib.h | 3 + RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153 ++++++++---------= --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 1 + 3 files changed, 63 insertions(+), 94 deletions(-) diff --git a/RedfishPkg/Include/Library/RestExLib.h b/RedfishPkg/Include/Li= brary/RestExLib.h index bc4e4ca6caa7..2c32c3684cf4 100644 --- a/RedfishPkg/Include/Library/RestExLib.h +++ b/RedfishPkg/Include/Library/RestExLib.h @@ -2,6 +2,7 @@ This library provides help functions for REST EX Protocol. =20 (C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -20,6 +21,7 @@ This function allows the caller to create child handle for specific REST server. =20 + @param[in] Controller The controller handle used of selected = interface. @param[in] Image The image handle used to open service. @param[in] AccessMode Access mode of REST server. @param[in] ConfigType Underlying configuration to communicate= with REST server. @@ -32,6 +34,7 @@ **/ EFI_STATUS RestExLibCreateChild ( + IN EFI_HANDLE Controller, IN EFI_HANDLE Image, IN EFI_REST_EX_SERVICE_ACCESS_MODE AccessMode, IN EFI_REST_EX_CONFIG_TYPE ConfigType, diff --git a/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c b/RedfishPkg/Li= brary/DxeRestExLib/DxeRestExLib.c index d9acad24dec1..0b3ae2755e86 100644 --- a/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c +++ b/RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c @@ -2,6 +2,7 @@ This library provides help functions for REST EX Protocol. =20 (C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -9,6 +10,7 @@ =20 #include #include +#include #include #include #include @@ -21,6 +23,7 @@ This function allows the caller to create child handle for specific REST server. =20 + @param[in] Controller The controller handle used of selected = interface. @param[in] Image The image handle used to open service. @param[in] AccessMode Access mode of REST server. @param[in] ConfigType Underlying configuration to communicate= with REST server. @@ -33,6 +36,7 @@ **/ EFI_STATUS RestExLibCreateChild ( + IN EFI_HANDLE Controller, IN EFI_HANDLE Image, IN EFI_REST_EX_SERVICE_ACCESS_MODE AccessMode, IN EFI_REST_EX_CONFIG_TYPE ConfigType, @@ -41,8 +45,6 @@ RestExLibCreateChild ( ) { EFI_STATUS Status; - UINTN NoBuffer; - EFI_HANDLE *Handle; EFI_HANDLE ChildHandle; EFI_REST_EX_PROTOCOL *RestEx; EFI_REST_EX_SERVICE_INFO *RestExServiceInfo; @@ -59,116 +61,79 @@ RestExLibCreateChild ( } =20 *ChildInstanceHandle =3D NULL; - // - // Locate all REST EX binding service. - // - Handle =3D NULL; - NoBuffer =3D 0; - Status =3D gBS->LocateHandleBuffer ( - ByProtocol, - &gEfiRestExServiceBindingProtocolGuid, - NULL, - &NoBuffer, - &Handle - ); - if (EFI_ERROR (Status) && (Status !=3D EFI_BUFFER_TOO_SMALL)) { + + ChildHandle =3D NULL; + Status =3D NetLibCreateServiceChild ( + Controller, + Image, + &gEfiRestExServiceBindingProtocolGuid, + &ChildHandle + ); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "%a: Failed to create service child - %r \n", + __func__, + Status + )); return Status; } - - Handle =3D (EFI_HANDLE *)AllocateZeroPool (sizeof (EFI_HANDLE) * NoBuffe= r); - if (Handle =3D=3D NULL) { - return EFI_OUT_OF_RESOURCES; - } - - Status =3D gBS->LocateHandleBuffer ( - ByProtocol, - &gEfiRestExServiceBindingProtocolGuid, + Status =3D gBS->OpenProtocol ( + ChildHandle, + &gEfiRestExProtocolGuid, + (VOID **)&RestEx, + Image, NULL, - &NoBuffer, - &Handle + EFI_OPEN_PROTOCOL_GET_PROTOCOL ); if (EFI_ERROR (Status)) { - FreePool (Handle); - return Status; + goto ON_ERROR; } =20 // - // Search for the proper REST EX instance. + // Get the information of REST service provided by this EFI REST EX driv= er // - while (NoBuffer !=3D 0) { - ChildHandle =3D NULL; - Status =3D NetLibCreateServiceChild ( - *(Handle + (NoBuffer - 1)), - Image, - &gEfiRestExServiceBindingProtocolGuid, - &ChildHandle - ); - if (!EFI_ERROR (Status)) { - Status =3D gBS->OpenProtocol ( - ChildHandle, - &gEfiRestExProtocolGuid, - (VOID **)&RestEx, - Image, - NULL, - EFI_OPEN_PROTOCOL_GET_PROTOCOL - ); - if (EFI_ERROR (Status)) { - goto ON_ERROR; - } - - // - // Get the information of REST service provided by this EFI REST EX = driver - // - Status =3D RestEx->GetService ( - RestEx, - &RestExServiceInfo - ); - if (EFI_ERROR (Status)) { - goto ON_ERROR; - } - - // - // Check REST EX property. - // - switch (ConfigType) { - case EfiRestExConfigHttp: - LenOfConfig =3D sizeof (EFI_REST_EX_HTTP_CONFIG_DATA); - break; - - case EfiRestExConfigUnspecific: - LenOfConfig =3D REST_EX_CONFIG_DATA_LEN_UNKNOWN; - break; + Status =3D RestEx->GetService ( + RestEx, + &RestExServiceInfo + ); + if (EFI_ERROR (Status)) { + goto ON_ERROR; + } + // + // Check REST EX property. + // + switch (ConfigType) { + case EfiRestExConfigHttp: + LenOfConfig =3D sizeof (EFI_REST_EX_HTTP_CONFIG_DATA); + break; =20 - default: - goto ON_ERROR; - } + case EfiRestExConfigUnspecific: + LenOfConfig =3D REST_EX_CONFIG_DATA_LEN_UNKNOWN; + break; =20 - if ((RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceAccessMod= e !=3D AccessMode) || - (RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceType !=3D= ServiceType) || - (RestExServiceInfo->EfiRestExServiceInfoV10.RestExConfigType != =3D ConfigType) || - ((LenOfConfig !=3D REST_EX_CONFIG_DATA_LEN_UNKNOWN) && (RestExSe= rviceInfo->EfiRestExServiceInfoV10.RestExConfigDataLength !=3D LenOfConfig)= )) - { - goto ON_ERROR; - } - } + default: + goto ON_ERROR; + } + if (RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceAccessMode != =3D AccessMode || + RestExServiceInfo->EfiRestExServiceInfoV10.RestServiceType !=3D Serv= iceType || + RestExServiceInfo->EfiRestExServiceInfoV10.RestExConfigType !=3D Con= figType || + ((LenOfConfig !=3D REST_EX_CONFIG_DATA_LEN_UNKNOWN) && (RestExServic= eInfo->EfiRestExServiceInfoV10.RestExConfigDataLength !=3D LenOfConfig))) { + goto ON_ERROR; + } =20 - // - // This is proper REST EX instance. - // - *ChildInstanceHandle =3D ChildHandle; - FreePool (Handle); - return EFI_SUCCESS; + // + // This is proper REST EX instance. + // + *ChildInstanceHandle =3D ChildHandle; + return EFI_SUCCESS; =20 ON_ERROR:; NetLibDestroyServiceChild ( - *(Handle + (NoBuffer - 1)), + Controller, Image, &gEfiRestExServiceBindingProtocolGuid, ChildHandle ); - NoBuffer--; - } - - FreePool (Handle); return EFI_NOT_FOUND; } diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 14702748813b..0b86a7b5cc4b 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -87,6 +87,7 @@ CreateRestExInstance ( EFI_STATUS Status; =20 Status =3D RestExLibCreateChild ( + Instance->NetworkInterface->OpenDriverControllerHandle, Instance->Owner, FixedPcdGetBool (PcdRedfishDiscoverAccessModeInBand) ? EfiRes= tExServiceInBandAccess : EfiRestExServiceOutOfBandAccess, EfiRestExConfigHttp, --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104152): https://edk2.groups.io/g/devel/message/104152 Mute This Topic: https://groups.io/mt/98710282/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 23:39:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104153+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104153+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1683306767773520.9350096489104; Fri, 5 May 2023 10:12:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id VZhMYY1788612xDPiIWCn1rg; Fri, 05 May 2023 10:12:47 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.94]) by mx.groups.io with SMTP id smtpd.web10.21113.1683269200555467571 for ; Thu, 04 May 2023 23:46:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jN8V4ls5PhUw248fkcgVUYV7aicod910lfjQt4bi430y+5FTQSmvQ3VFwsfJf254oWgqJxIwIuHeF+O0+mt/7/R5hsQBriAHUc59x6HO66eOK8tWaGD+6QwUozUameYguidG+9nIY195xlkmVKIq+c28SYbgVlU92OGlRpbxRyJDa64tmjnwxqRFQDKqIToaTWqpmNcg8tmzHmLK1Tclhmlw4VWsmtSa2haPVivYxZ6/QTvordu3aLBkrjaW1lCOfussQj4t81BBFgjl3nuPMoVJu/sREW2ZULNnLI9ikatymcDOkjI54KovIA5aKFnYyPrkUUqRlD9WzSn6ENo7BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zu8dl9fFUkyQ/+iKDqKCwJB7RvMIgqN/Q+9zIOazTmc=; b=gHPZQsW8D2l5IfJ6GZVkbkq01MKxqH1VcVgjzzPaShysESh6X7GolUvCz7WPDp7tZL4cw+B7PkLN7KbxYLzyO9cS0qeEG3izuUuT1a9ImppnGPDLKP9rspW3O1dJQ2Z/3ZTrAZVcWJGiKvj8bAGv+5mVlsfzF9xVB7IVjtfVrM4X5HRWsWZHnkLxMtCfsf7sWeXskBHfuOA4aDe39tcmGJeQ/fGhHdu7/f/KCMGvbMYmrWY8ICGwJJuHOJs1W2x4WG/b4ese84VojN17Mt9RbVtEYninQ9C8zDgNmGtX8GJzfP6dmXNMuu732OYWCnuW5wnz5Me+smH1JTJgqAUUxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN6PR01MB5087.prod.exchangelabs.com (2603:10b6:805:b8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 06:46:38 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 06:46:38 +0000 From: "minhnampere via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Minh Nguyen , Nick Ramirez Subject: [edk2-devel] [PATCH V3 4/5] RedfishPkg: Add missing newline character Date: Fri, 5 May 2023 13:45:59 +0700 Message-ID: <20230505064600.1478461-5-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> References: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG3P274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::17) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN6PR01MB5087:EE_ X-MS-Office365-Filtering-Correlation-Id: 717a9fc6-212c-4920-bbf2-08db4d3479f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: BST4dw8XXnYyZTFraqOLnklNZzJvygsTB1jS+Wbt9rsaTtLwdK2fJgVy2wNyCwRCA1p5FqX8nPq0i7KBQBKosKnCbR+VZrh4o7qFcRo2+k87fPJRbW0QugvwMp+EtS2/CnDGzBNq0l/PK864RtURWY/Kx9V/ouOpU3/qHu8rPAjYrT8jcy0MU2n9WEQtfWZC75PcRjy3qgxobzZgnUdyyBwYqRQ2GmMJjgN27GwcTjfJZuDFnZF6OhYcEe2enaBk9Y8hpK2SUU2wjJ6iRFaTQ+RVfZXs8gwAJasQoNm/19TBS6fACxeKvbdsDDxeCD5+io3uOHwFz1zqBor6hbJBizeT0aZnUMnac6qkBcyg77DRr/8M9v0gVF19mmAwGlSKKFvdiHkgN9RwgXXTIP0z9/m/wlMrs1rWQGHtKeoDduR7oRhqxnf6j5ltNRl9UErjMNtrOOz1vWYjH2ypXh7avZMt5bM2rqwR4zCKoNJt8jZNjirk0bsiHA3f+QnoWVhhNb6Q/JvcOdMTA/wad6AJMmzxq2M6f6KbzZWIe9EW8WOLOcKp3acJ9Yhr7Xh+L26pqbx8jIWiBY5rlJGgYUAD4QV3uMfw0ipYnbpVFFrYSS/ezaKui+8vc1639T0a0abBmgENYX+UcQndIuHQj0/IRA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CLEHAf8QWLsCalZGj2YtUtD5TGE/JbnorkQfl2V4XichL4G5m9vQ1yDYyo6D?= =?us-ascii?Q?jwwF+cf1aaWg4mRQkhJ+S5q5pBFt4by7ALMQhFynUMbX7tx3Lc5j58IgciNd?= =?us-ascii?Q?0FO87DBIuv607QxF63vq1mbYz3x8srFl1+hd6qVh483X/g4nNUYlGor4zwhb?= =?us-ascii?Q?OTyIKjNCvEED/dr7y4TWjgK99IpjeDTh2qc2+thcgnhv3byMGbfTQ1KPOyqJ?= =?us-ascii?Q?p8tQoXtMNU9fh8sFu7y/i1sFxTo8X5sCJTPdLGGF9YuhQlYjLnsCwOTkC5QO?= =?us-ascii?Q?Qle9qpoj4iEgdQsFk2al7D3B+mjxl432Z084rStZIkD+MupXncGzx/kusN0x?= =?us-ascii?Q?tlATB3aIB79hvLfqUyVBV4FENxuaQ86LOHyvDUuAQmYQVTkluqVbF1J88gVn?= =?us-ascii?Q?RQwnsP9A/1cR4JTyLWWSTAkU9XNOB+ogF6RdgPLY0Hfcddnk2Xq+JzMH9va6?= =?us-ascii?Q?TPcYpSoBq81+LGhFCSRYx/NSLQrRbIXF+6upPmKo20a7dQ6UL7Wfhasm+YYq?= =?us-ascii?Q?Uss5l6smJ9NdV8v1ReHuZNcEXo7ORoO6rwJcXgYsS8omWVUGFdO3WSWEnKIA?= =?us-ascii?Q?SiePkLy/wgIMeIOsGprlRJUdf+XkvQXSdk62jAtQcKuIGN80mxZIW6I0ZcV9?= =?us-ascii?Q?GwDGl7cieAefkNdFT7JjQxAqqtxlI+ixVCOPO2TNQ424mt1TqFUTEdJ57K0u?= =?us-ascii?Q?bMnhooNgXqAyuuZtRML77IRSnQVCF2SpL8mFqMek2Gh1PH9dx9HO6qz+JHO6?= =?us-ascii?Q?2XDS9Eob0ZT82XJb+JDlp9TapTAKVTEkXESLT/T0t8hCDx3zjqS4GEH+JsVh?= =?us-ascii?Q?MvKk377PeiwIncfhmWVxOs1TLCengxOGiool9/NKtIbgxsvFtkIjLgittINs?= =?us-ascii?Q?8a15/O1lvY02HcoVAQK5yltPibF8z46OJBPm/vV5mmlS3N5Az49QFdOtjudG?= =?us-ascii?Q?wGwTWUHnbxumVBkDxy8cT7jXdV1aGlJpu1mW7vKHfpoDi1YwZv4bE9KC1Q0l?= =?us-ascii?Q?OHUJ/OhLAtvCpy0PCiHUxPRaix6sWcJjJ5ojOTJbUM06/QOdbGnVjJYXnYmY?= =?us-ascii?Q?8dSyOJGcY/4YXRvY1RtwYqOMSEciLt9zLcXz1u9A4GSZnAUmruSQQ4OYhAqb?= =?us-ascii?Q?XBFHxMYQ+suSIhGgXQXdzkbPJRabuT0pEG1uctFC4G1rUQxZ72zf9Fgq9FaQ?= =?us-ascii?Q?KeMyanG+CEYFas4QMoLNf+Ms2x/dOTVED4Fl5y+3a09q7zza/Y6LyCcYF6W9?= =?us-ascii?Q?EnqQeHiJEoPHpHCKHr+cSMn71SJZK3LbxtQgL+WaKC/QdjiIs1MnE2Nx02ak?= =?us-ascii?Q?Xeijpe3PnMqXP4MZ0ml2hbb0g/aSu3qO3yk3V/JoLwME09XfnH0Gi/ws8WqY?= =?us-ascii?Q?VN6yIdPo+Iftz9T51txEx2sTxQ8hi/ybWud7RFI+xzr96UtTmXZETMb3Q/AL?= =?us-ascii?Q?7gQ18V48qN4llR7regQ+cXrcCrO/suf/zJDMbytSkcrbrJclxgsCa2xv/Z+e?= =?us-ascii?Q?W6goZvI9U7KkjyLMdJI9IITs+zZJNwqPavmoJcfXAbb0KMbwbXYFCaX43rUw?= =?us-ascii?Q?eRqDpfgvczY5vFl5xejljL3yMzIkzhZXtZq5eVpBCg08AfyTROf++An1Yz0F?= =?us-ascii?Q?8ojBC+vovC0i5soCrXti8M9wUyu6vpJR3w5GgzE0o4pb?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 717a9fc6-212c-4920-bbf2-08db4d3479f4 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:46:38.4776 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SyECEQbPepF1mkx1fEdBPlYlW36zk7LcwCVsCa8htmkNP7hDjgsOAthAoi2f45fDXcQkhzxJ6Y38ScRudaug4QMylNdZ3w8H0D1A+DWnLAfmfw4mmK3HfkS+6a8dfvgG X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB5087 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: jOrcBXiCO58dzVI9owLYs0KYx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683306767; bh=lhp5T9TtCLu54HyLs/wvFUlVFMseqlCzULbvn6AmV+M=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=nLLdZaL0711j/jVw2N3MdViJfNzBVqvvdRZbdjo/NejINz9G5bfg2JRsg31zJZI2eX2 vXbmNH8RY7tm8wrAbW3w294kksyDDLhJO+BKPDlRWqew54DurWSR96CNOFFiyREz47mHX 1rBbS/shK6Vc2Y4+Xbbzgp6vfdCy6dNuj2w= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683306769448100063 Content-Type: text/plain; charset="utf-8" From: Nhi Pham This adds a missing newline character to make the error log readable in case the module is failed. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Nickle Wang --- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c b= /RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c index 45fc6e2182bc..c4fa59193a2f 100644 --- a/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c +++ b/RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c @@ -8,6 +8,7 @@ (C) Copyright 2020 Hewlett Packard Enterprise Development LP
Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -59,7 +60,7 @@ RedfishCreateSmbiosTable42 ( Status =3D RedfishPlatformHostInterfaceDeviceDescriptor (&DeviceType, &D= eviceDescriptor); if (EFI_ERROR (Status)) { if (Status =3D=3D EFI_NOT_FOUND) { - DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is pr= ovided on this platform.", __func__)); + DEBUG ((DEBUG_ERROR, "%a: No Redfish host interface descriptor is pr= ovided on this platform.\n", __func__)); return EFI_NOT_FOUND; } =20 --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104153): https://edk2.groups.io/g/devel/message/104153 Mute This Topic: https://groups.io/mt/98710283/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 23:39:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+104154+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+104154+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 168330676865164.25524357766881; Fri, 5 May 2023 10:12:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id xUyaYY1788612xHVUbLhYjqh; Fri, 05 May 2023 10:12:48 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.116]) by mx.groups.io with SMTP id smtpd.web11.21037.1683269203966952981 for ; Thu, 04 May 2023 23:46:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ra1oF615cJO0GOJvCjZR5SIgzRRLOpWVrHUs8OQbSDTZjfuMwCJoBDx/1nscnj6P9S96pWSFxZH4v//Z8BgRzbwv3Njqp6vSkcwP7cBeOqYdPcdewucBh2KkkaEgDC/EvfZeDCdhDJGUCpOycVG+4+w2AVoYGiflWlK8uhmUaYfqI6CJIDh1ifxPqeRChajL4fvfv1aA0skV+y+9Zw7GP2zcWEK/0U5RSYnX+dY+Kb3fPkzsMbpB+SDiynfheITnvO9A/MV+CW5/WXXGlRR2jLJ7XaFr1fdal04Lpg5okEXc3asnSGhpwgF5REL7DL0Tr0PL1/McbwvIKNYjk+7g3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jh4UCFi3rgn5dNgMwlvoJsaOGmXOGa8O9eQW0uYisHY=; b=LNsARJPdfv+Ega6MxrESVYAyosItbLhCSZoX5rytwQceOm+w+BMQBQmE7Z5hW8c5k8XRMak2pEvjSzNERQ1Mn6jAOybzBGytG5chpHW64k5cnA0YE9Oy7Jr7Ywl8uJLAAky4LXGb5GrjoE3LqV2MfUvJjKx0U/cT15L6b0VJCH5Q3uglNKZvrXKeHucNsixV8/SMtQUi9Etjhu0/WQWbuKi/95hjuXhsBihrWARdpaKmQzTosBjsKzLZSJdga4+JS77xuImZrGq9+9xjPlaVLeBrvKC+CTiPLoTnGcr16XDvwbDSDi2LmWFP/GysBHEDRnBnyFJlwIyRd5fvRZ0zAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN6PR01MB5087.prod.exchangelabs.com (2603:10b6:805:b8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 06:46:41 +0000 X-Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%7]) with mapi id 15.20.6363.026; Fri, 5 May 2023 06:46:41 +0000 From: "minhnampere via groups.io" To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com, Vu Nguyen , Minh Nguyen , Nick Ramirez , Abner Chang Subject: [edk2-devel] [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux Date: Fri, 5 May 2023 13:46:00 +0700 Message-ID: <20230505064600.1478461-6-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> References: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG3P274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::17) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN6PR01MB5087:EE_ X-MS-Office365-Filtering-Correlation-Id: 64a7b5cb-843d-4768-94e4-08db4d347bc5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: wqbD2tSW77qLe9xE6GhltVK7cU5uAIHOF/FMigyxsO1WDwnGlTavUYc59iST85hF3LXeXRxGzSamzDYVxKj3viP8GTStxMqOKNsSLCq4m5iPLUazp4bYOmNDkfYYOT0lqF4TwLsgP3LmnrrT88ezwEiRkYnKIwZoVFHa7n3kkQg26Ghi3b5gmBaI9Y1YLURdESCPkzLC1djycy632gWyiz7r0oOwlMw3z0C0XPS57nJuPVy2k7EEMelIj7CvdaU9zqpoLO2fOrVjTgc2D0rO7iBnu1s/mYsQXhsXTXSbnMNwHR9TpdITrt51HewwC8KVEg6sxKXES6PSEDA3p29XkZ5juyJanDu0ZJITHeiIGSJsUqsC5btixn86h4qBOZOw1l2UhhXigQZ3nKvr1tJKL+xNXVEO9WWZ8ESPtpwTPI9quoE2qZv4GzXxdpEdL3uYZpUR9D+M1D7YSdnCRRn58XoLEBKr63PKeFiXFrzdxU8H9syTnXVacS8TJxsxwx6/c5W2boB5PYOfKX+z7pZC5+PUTkba++GNiiLvPzwerm6Q0zKWfbD80h/bxOTar5U5G5OVaa03nktBseJEuF/EZ7J3I1nkSp0l8asnmEgvhAXpk/3lvNT6zdH4vrv+SMhaWxRqL+VscadNd6WrLpElng== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M0TrO38GRMJ9mJnwtpUsZsCBqzoDkmE7EjpHj8yBu4UAq44nXP0g+7i/FT3W?= =?us-ascii?Q?C7b5I0ZvGXb9lkjvnbDb/7m0e/ERC30ws/h3ANeBy7ddiEILUFJCWX97pVes?= =?us-ascii?Q?Zdmi/4b4skZfh4d7jjbt5lV0XozTd1yGu67DsOUtYMPGdQwcehQ0F0C5SHqf?= =?us-ascii?Q?QEB4FnVYQoxLBRfC69ymEKFYIqyOPYixywQKxnrwy6CfX4amuSGGZBGgInNY?= =?us-ascii?Q?DEy/YofTAmg/0+aXhpMRNBfGOBNwZrjXB+ouzATHtATnp4kVPlSso9z1ABQf?= =?us-ascii?Q?A+rTHDNi6x2yw6pWYgIp9xLajeco/SQbn/ylp/tO9rdJ9BDgpDGkm8+cRTGQ?= =?us-ascii?Q?dQy1RPb7GUQZHjhCJVDJMXmwtBV1EvuLclUQyFLgqJbYRDWSoc+cR3VSvfOY?= =?us-ascii?Q?XG4hPboqa42EgntsGlHFqqlxIeRM0Zo209FAPnRbr1uv/iEzXM7S+9yVQTZb?= =?us-ascii?Q?eWMDmZQoYQ7ItacTHgpHTR5Dq7vQAQ7WLmtjW1lHKLqYIVQfLx+cjy5dOVaq?= =?us-ascii?Q?50y5f6haFKBRFQ/pCXRHcsxMMAIP8c60onjydTVzrGYgyCDKMqZimP84uPMg?= =?us-ascii?Q?B2okpTqcFpV4U5lwi2m5QOTHEjTTcgrSsbcIZ+83VrjrAP/TLHC44hIWdW3p?= =?us-ascii?Q?j7LbCyqdD4SjqGOWxmXPAPiLBq9ELhzSauPX36j56PFDrBV4BcO7PwglaZYm?= =?us-ascii?Q?pl/iHYC+TczKc6AleXhxkimScdpInpGGJXs1wGarsRip5cUWX9HnPJnEpUDH?= =?us-ascii?Q?lpOdYMCQfMwO2gU9D4GGEbVJUv74RLW93JaLjyJ/6tkRbZ6gPo/4BAsp1X50?= =?us-ascii?Q?C82WV0mN+kfOWTxT/wsuRvGLkpdWIq6wprRf8upyUiw/DxbSQRjVSZc+JCmH?= =?us-ascii?Q?LZ39p0jPpXFmiTWO+U9pK31tEu8v8DcZYSdaAZRWl1OVrl2YeywPHhfZcccE?= =?us-ascii?Q?HGE+DxOB+SXwP8aHNpjKKNJjnzuu1aQ8yQI/D74X0T11rz/+Nnwu4OquDaOh?= =?us-ascii?Q?DwSK/VCn8uAGr3PHV2v54mCPmRaWds3S5GULrXJr5mOUcHNRumh15KKtEGZp?= =?us-ascii?Q?emtVcrbs5R3O2SEicGr5KxX7RE3h7tMh8ARcjuUkc7rHpQy2Cno6uBeOfOD6?= =?us-ascii?Q?mC3J3pDZ99txab05y34u2UGO2hT9ean41x+p9xRej0hFIBhZ+qlxrr+hgBDD?= =?us-ascii?Q?cp5PFLnZNtZewVlwnsm/0JhHgJXXPD/l5/UBeJVx5j+BRzzPTYwSEYjXiu2G?= =?us-ascii?Q?0qNhDi7tfcNgMJn+POL1YkXbfw0kP4KINDqx5YqnMra1Ydspv8hR9et7kQVm?= =?us-ascii?Q?fNK6Pt3GoID+IM3goLmljoOSYVxIyQPunPOgSjP9nUGhCv5WjuGdbpoLH0fI?= =?us-ascii?Q?OQ6rqUka9AhhXtxnJ6oIcssRP0GqKVmfmVQKMvYazSehcUj7y7c7JV5ldXFI?= =?us-ascii?Q?QsD2YdS8Em1iAJBVYGsLziGVG1bfB71g1INipTelxPigjIFCduSTaixdKaXD?= =?us-ascii?Q?haGA/GkSUf2k7SP2wNMI5pm8Trdkr0kWH79Lzs4CY9Q6u/tsFWwdaNCDF/Op?= =?us-ascii?Q?YnDZAgV+3ulDZIgqo8D/9y/RdqgV4ELOvVyYMARlkoo4lF9LzeEwHtJIVfj3?= =?us-ascii?Q?qriKPUcvw+czbyIt6TM41I3S5kaeXh4AD4Dq2Uw7lcWf?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64a7b5cb-843d-4768-94e4-08db4d347bc5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 06:46:41.5473 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hKbOjpaqUGAzquDLH8hVbRm1JYk+27n9JfsggBh/u9cf0lGCcncBae/ww5t9mM8bJDa6kDYKxus0VESQdYDWhZC/SJBb2c1KlgednA5nVqgnBqg4JgzZ6QNzUSj3jeJq X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB5087 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,minhnguyen1@os.amperecomputing.com X-Gm-Message-State: jUJ2VQ0tqLUpNgHMAWtVM89Px1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1683306768; bh=1w/l7Ia4b02gGe42AJhvbC1mPkiKFJ1xMEci98sSVqg=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=HV8bxfsTBJVrXZ65VTxvYszUO6mHB331bcFl9ZQw7owqcWb3d4JFR+ou9x69oSFjZW0 Uok8BDdOlOhLybCsBieo3xjEy8pPJaretgq+HOXRRo7lM2yMYXP4PA6ntuDfrVN/qZglW ukyxhJ6nBk7FqnY4cKZWSehYXGQVsolB3E0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1683306769478100065 Content-Type: text/plain; charset="utf-8" From: Vu Nguyen It requires a fixed size array to store the content of device path PCD. Add the array size to solve this issue. Signed-off-by: Minh Nguyen Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h b/RedfishPkg/= Include/Pcd/RestExServiceDevicePath.h index 91b1198297c2..57fc199f61f2 100644 --- a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h +++ b/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h @@ -4,6 +4,7 @@ =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -14,6 +15,8 @@ =20 #include =20 +#define MAX_DEVICE_PATH_NODE 40 + typedef enum { DEVICE_PATH_MATCH_MAC_NODE =3D 1, DEVICE_PATH_MATCH_PCI_NODE =3D 2, @@ -32,7 +35,7 @@ typedef struct { // 0x03,0x0b,0x25,0x00,0x00,0x50,0x56,0xc0,0x00,0x02,0x00,0x00,0x00,0= x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0= x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01, // 0x7f,0xff,0x04,0x00} // - EFI_DEVICE_PATH_PROTOCOL DevicePath[]; + EFI_DEVICE_PATH_PROTOCOL DevicePath[MAX_DEVICE_PATH_NODE]; } REST_EX_SERVICE_DEVICE_PATH_DATA; =20 #endif --=20 2.39.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104154): https://edk2.groups.io/g/devel/message/104154 Mute This Topic: https://groups.io/mt/98710284/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-