[PATCH 0/2] sun4i-emac: replace magic number with marcos

conleylee@foxmail.com posted 2 patches 4 years, 5 months ago
drivers/net/ethernet/allwinner/sun4i-emac.c | 26 ++++++++++-----------
drivers/net/ethernet/allwinner/sun4i-emac.h | 18 ++++++++++++++
2 files changed, 31 insertions(+), 13 deletions(-)
[PATCH 0/2] sun4i-emac: replace magic number with marcos
Posted by conleylee@foxmail.com 4 years, 5 months ago
From: conley <conleylee@foxmail.com>

- sun4i-emac.h: add register related marcos
- sun4i-emac.c: replace magic number with marco

*** BLURB HERE ***

conley (2):
  sun4i-emac.h: add register related marcos
  sun4i-emac.c: replace magic number with macro

 drivers/net/ethernet/allwinner/sun4i-emac.c | 26 ++++++++++-----------
 drivers/net/ethernet/allwinner/sun4i-emac.h | 18 ++++++++++++++
 2 files changed, 31 insertions(+), 13 deletions(-)

-- 
2.31.1

Re: [PATCH 0/2] sun4i-emac: replace magic number with marcos
Posted by Corentin Labbe 4 years, 5 months ago
Le Mon, Jan 10, 2022 at 03:23:07PM +0800, conleylee@foxmail.com a écrit :
> From: conley <conleylee@foxmail.com>
> 
> - sun4i-emac.h: add register related marcos
> - sun4i-emac.c: replace magic number with marco
> 
> *** BLURB HERE ***
> 
> conley (2):
>   sun4i-emac.h: add register related marcos
>   sun4i-emac.c: replace magic number with macro
> 
>  drivers/net/ethernet/allwinner/sun4i-emac.c | 26 ++++++++++-----------
>  drivers/net/ethernet/allwinner/sun4i-emac.h | 18 ++++++++++++++
>  2 files changed, 31 insertions(+), 13 deletions(-)
> 

Hello

The from should be your real name.
You miss commit message.
The subject should be "net: allwinner: xxxx" or "net: ethernet: sun4i-emac: xxxx"
You did a typo marcos/macros
If you add a changelog, either put it in cover letter or below "---" in patch along git stats (changelog should not be part of commit message).

I think both patch should be merged.

Regards