[v1] staging: rtl8712: fix potential memory leak in r8712_xmit_resource_alloc()

[PATCH] staging: rtl8712: fix potential memory leak in r8712_xmit_resource_alloc()

xkernel.wang@foxmail.com posted 1 patch 4 years, 2 months ago

Diff against v2
Download mbox

There is a newer version of this series

drivers/staging/rtl8712/xmit_linux.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] staging: rtl8712: fix potential memory leak in r8712_xmit_resource_alloc()

Posted by xkernel.wang@foxmail.com 4 years, 2 months ago

From: Xiaoke Wang <xkernel.wang@foxmail.com>

In r8712_xmit_resource_alloc(), if usb_alloc_urb() fails, there are some
explored items should be released before this function returns.

Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
---
 drivers/staging/rtl8712/xmit_linux.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c
index 06283c4..1bfa204 100644
--- a/drivers/staging/rtl8712/xmit_linux.c
+++ b/drivers/staging/rtl8712/xmit_linux.c
@@ -113,6 +113,8 @@ int r8712_xmit_resource_alloc(struct _adapter *padapter,
 		pxmitbuf->pxmit_urb[i] = usb_alloc_urb(0, GFP_KERNEL);
 		if (!pxmitbuf->pxmit_urb[i]) {
 			netdev_err(padapter->pnetdev, "pxmitbuf->pxmit_urb[i] == NULL\n");
+			while (i-- > 0)
+				usb_free_urb(pxmitbuf->pxmit_urb[i]);
 			return -ENOMEM;
 		}
 		kmemleak_not_leak(pxmitbuf->pxmit_urb[i]);
--