[PATCH] mempolicy.h: Remove unnecessary header file inclusions with no test failure

Junjie Fu posted 1 patch 1 year ago
There is a newer version of this series
fs/aio.c                  | 1 +
include/linux/mempolicy.h | 1 -
mm/mempolicy.c            | 1 +
3 files changed, 2 insertions(+), 1 deletion(-)
[PATCH] mempolicy.h: Remove unnecessary header file inclusions with no test failure
Posted by Junjie Fu 1 year ago
Due to my previous patch not including pagemap.h in fs/aio.c, a test
failure occurred. In this patch, it has been fixed.

Previous patch address:
https://lore.kernel.org/all/tencent_08B979048FE091821B290B18AE97E70DC507@qq.com/

Signed-off-by: Junjie Fu <fujunjie1@qq.com>
---
 fs/aio.c                  | 1 +
 include/linux/mempolicy.h | 1 -
 mm/mempolicy.c            | 1 +
 3 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/aio.c b/fs/aio.c
index 50671640b588..9fad51dc823f 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -39,6 +39,7 @@
 #include <linux/compat.h>
 #include <linux/migrate.h>
 #include <linux/ramfs.h>
+#include <linux/pagemap.h>
 #include <linux/percpu-refcount.h>
 #include <linux/mount.h>
 #include <linux/pseudo_fs.h>
diff --git a/include/linux/mempolicy.h b/include/linux/mempolicy.h
index ce9885e0178a..d36877557b00 100644
--- a/include/linux/mempolicy.h
+++ b/include/linux/mempolicy.h
@@ -12,7 +12,6 @@
 #include <linux/rbtree.h>
 #include <linux/spinlock.h>
 #include <linux/nodemask.h>
-#include <linux/pagemap.h>
 #include <uapi/linux/mempolicy.h>
 
 struct mm_struct;
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 88eef9776bb0..5297e0df4e3d 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -99,6 +99,7 @@
 #include <linux/swap.h>
 #include <linux/seq_file.h>
 #include <linux/proc_fs.h>
+#include <linux/pagemap.h>
 #include <linux/migrate.h>
 #include <linux/ksm.h>
 #include <linux/rmap.h>
-- 
2.34.1
Re: [PATCH] mempolicy.h: Remove unnecessary header file inclusions with no test failure
Posted by Andrew Morton 1 year ago
On Wed, 11 Dec 2024 10:52:30 +0800 Junjie Fu <fujunjie1@qq.com> wrote:

> Due to my previous patch not including pagemap.h in fs/aio.c, a test
> failure occurred. In this patch, it has been fixed.
> 
> Previous patch address:
> https://lore.kernel.org/all/tencent_08B979048FE091821B290B18AE97E70DC507@qq.com/
> 

The previous patch had a changelog.  This one effectively has none.

So, please resend, with a full standalone changelog.

Prepare that changelog in a manner which is suitable for inclusion into
the permanent kernel record.  References to earlier versions of the
patch are uninteresting in that context.