[PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean

Rong Tao posted 1 patch 2 years, 7 months ago
tools/counter/Makefile | 1 +
1 file changed, 1 insertion(+)
[PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean
Posted by Rong Tao 2 years, 7 months ago
From: Rong Tao <rongtao@cestc.cn>

'make' create 'include' directory, we should remove it when 'make clean'.

Signed-off-by: Rong Tao <rongtao@cestc.cn>
---
v2: this commit, according to William Breathitt Gray's suggession in v1
v1: https://lore.kernel.org/lkml/tencent_FA682F628E818DD04B96C3E5A94ACFABE206@qq.com/
---
 tools/counter/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/counter/Makefile b/tools/counter/Makefile
index 8843f0fa6119..a0f4cab71fe5 100644
--- a/tools/counter/Makefile
+++ b/tools/counter/Makefile
@@ -40,6 +40,7 @@ $(OUTPUT)counter_example: $(COUNTER_EXAMPLE)
 clean:
 	rm -f $(ALL_PROGRAMS)
 	rm -rf $(OUTPUT)include/linux/counter.h
+	rmdir -p $(OUTPUT)include/linux
 	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
 
 install: $(ALL_PROGRAMS)
-- 
2.40.0
Re: [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean
Posted by William Breathitt Gray 2 years, 7 months ago
On Sat, Apr 22, 2023 at 10:27:38PM +0800, Rong Tao wrote:
> From: Rong Tao <rongtao@cestc.cn>
> 
> 'make' create 'include' directory, we should remove it when 'make clean'.
> 
> Signed-off-by: Rong Tao <rongtao@cestc.cn>

Queued (with minor commit description cleanup) for the counter-next
branch of the Counter tree.

Thank you,

William Breathitt Gray
Re: [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean
Posted by William Breathitt Gray 2 years, 7 months ago
On Sat, Apr 22, 2023 at 10:27:38PM +0800, Rong Tao wrote:
> From: Rong Tao <rongtao@cestc.cn>
> 
> 'make' create 'include' directory, we should remove it when 'make clean'.
> 
> Signed-off-by: Rong Tao <rongtao@cestc.cn>

Hi Rong,

The code changes in this v2 are acceptable for me now, but I would like
the commit description typos fixed. I can fix it myself when I apply
this patch so that you don't need to submit a v3. Would you be okay if I
did that?

William Breathitt Gray
Re: [PATCH v2] tools/counter: Makefile: Remove lingering 'include' when make clean
Posted by Rong Tao 2 years, 7 months ago
Hi, William,

Of course it's okay, thanks.

Rong Tao