pmdomain: ti: omap_prm: Fix a reference leak on device node

[PATCH] pmdomain: ti: omap_prm: Fix a reference leak on device node

Posted by Felix Gu 3 weeks, 2 days ago

When calling of_parse_phandle_with_args(), the caller is responsible
to call of_node_put() to release the reference of device node.
In omap_prm_domain_attach_dev, it does not release the reference.

Fixes: 58cbff023bfa ("soc: ti: omap-prm: Add basic power domain support")
Signed-off-by: Felix Gu <gu_0233@qq.com>
---
 drivers/pmdomain/ti/omap_prm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pmdomain/ti/omap_prm.c b/drivers/pmdomain/ti/omap_prm.c
index 5142f064bf5c..64a187f79a1a 100644
--- a/drivers/pmdomain/ti/omap_prm.c
+++ b/drivers/pmdomain/ti/omap_prm.c
@@ -655,6 +655,7 @@ static int omap_prm_domain_attach_dev(struct generic_pm_domain *domain,
 	if (pd_args.args_count != 0)
 		dev_warn(dev, "%s: unusupported #power-domain-cells: %i\n",
 			 prmd->pd.name, pd_args.args_count);
+	of_node_put(pd_args.np);
 
 	genpd_data = dev_gpd_data(dev);
 	genpd_data->data = NULL;

---
base-commit: 9b7977f9e39b7768c70c2aa497f04e7569fd3e00
change-id: 20260116-omap_prm-c7bdd9726abc

Best regards,
-- 
Felix Gu <gu_0233@qq.com>

Re: [PATCH] pmdomain: ti: omap_prm: Fix a reference leak on device node

Posted by Ulf Hansson 1 week, 5 days ago

On Fri, 16 Jan 2026 at 13:27, Felix Gu <gu_0233@qq.com> wrote:
>
> When calling of_parse_phandle_with_args(), the caller is responsible
> to call of_node_put() to release the reference of device node.
> In omap_prm_domain_attach_dev, it does not release the reference.
>
> Fixes: 58cbff023bfa ("soc: ti: omap-prm: Add basic power domain support")
> Signed-off-by: Felix Gu <gu_0233@qq.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/pmdomain/ti/omap_prm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/ti/omap_prm.c b/drivers/pmdomain/ti/omap_prm.c
> index 5142f064bf5c..64a187f79a1a 100644
> --- a/drivers/pmdomain/ti/omap_prm.c
> +++ b/drivers/pmdomain/ti/omap_prm.c
> @@ -655,6 +655,7 @@ static int omap_prm_domain_attach_dev(struct generic_pm_domain *domain,
>         if (pd_args.args_count != 0)
>                 dev_warn(dev, "%s: unusupported #power-domain-cells: %i\n",
>                          prmd->pd.name, pd_args.args_count);
> +       of_node_put(pd_args.np);
>
>         genpd_data = dev_gpd_data(dev);
>         genpd_data->data = NULL;
>
> ---
> base-commit: 9b7977f9e39b7768c70c2aa497f04e7569fd3e00
> change-id: 20260116-omap_prm-c7bdd9726abc
>
> Best regards,
> --
> Felix Gu <gu_0233@qq.com>
>

Re: [PATCH] pmdomain: ti: omap_prm: Fix a reference leak on device node

Posted by Markus Elfring 3 weeks, 2 days ago

…
> In omap_prm_domain_attach_dev, it does not release the reference.

See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc5#n94

Regards,
Markus