[v2] net: appletalk: Fix device refcount leak in atrtr_create()

[PATCH v2] net: appletalk: Fix device refcount leak in atrtr_create()

veritas501@foxmail.com posted 1 patch 3 months ago

Diff against v1
Download mbox

net/appletalk/ddp.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH v2] net: appletalk: Fix device refcount leak in atrtr_create()

Posted by veritas501@foxmail.com 3 months ago

From: Kito Xu <veritas501@foxmail.com>

When updating an existing route entry in atrtr_create(), the old device
reference was not being released before assigning the new device,
leading to a device refcount leak. Fix this by calling dev_put() to
release the old device reference before holding the new one.

Fixes: c7f905f0f6d4 ("[ATALK]: Add missing dev_hold() to atrtr_create().")
Signed-off-by: Kito Xu <veritas501@foxmail.com>
---
 net/appletalk/ddp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index 73ea7e67f05a..30242fe10341 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -576,6 +576,7 @@ static int atrtr_create(struct rtentry *r, struct net_device *devhint)
 
 	/* Fill in the routing entry */
 	rt->target  = ta->sat_addr;
+	dev_put(rt->dev); /* Release old device */
 	dev_hold(devhint);
 	rt->dev     = devhint;
 	rt->flags   = r->rt_flags;
-- 
2.34.1