1. Patchew
  2. linux
  3. View series

[PATCH] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)

Haichen Feng posted 1 patch 1 month, 3 weeks ago
There is a newer version of this series
drivers/platform/x86/hp/hp-wmi.c | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
Posted by Haichen Feng 1 month, 3 weeks ago 
The HP Victus 16-r0xxx (board ID: 8BC2) has the same WMI as other Victus
S boards, but requires quirks for correctly switching thermal
profile.

Add the DMI board name to victus_s_thermal_profile_boards[] table and
map it to omen_v1_thermal_params.

Testing on board 8BC2 confirmed that platform profile is registered
successfully and fan RPMs are readable and controllable.

Signed-off-by: Haichen Feng <2806891994@qq.com>
---
 drivers/platform/x86/hp/hp-wmi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index d1cc6e7d1..075d39417 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -213,6 +213,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCD") },
 		.driver_data = (void *)&omen_v1_thermal_params,
 	},
+	{
+		.matches = {DMI_MATCH(DMI_BOARD_NAME, "8BC2")},
+		.driver_data = (void *)&omen_v1_thermal_params,
+	},
 	{
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BD4") },
 		.driver_data = (void *)&victus_s_thermal_params,
-- 
2.54.0
Re: [PATCH] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
Posted by Ilpo Järvinen 1 month, 2 weeks ago 
On Sat, 25 Apr 2026, Haichen Feng wrote:

> The HP Victus 16-r0xxx (board ID: 8BC2) has the same WMI as other Victus
> S boards, but requires quirks for correctly switching thermal
> profile.
> 
> Add the DMI board name to victus_s_thermal_profile_boards[] table and
> map it to omen_v1_thermal_params.
> 
> Testing on board 8BC2 confirmed that platform profile is registered
> successfully and fan RPMs are readable and controllable.
> 
> Signed-off-by: Haichen Feng <2806891994@qq.com>
> ---
>  drivers/platform/x86/hp/hp-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index d1cc6e7d1..075d39417 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -213,6 +213,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCD") },
>  		.driver_data = (void *)&omen_v1_thermal_params,
>  	},
> +	{
> +		.matches = {DMI_MATCH(DMI_BOARD_NAME, "8BC2")},

Please place it into the correct place (8BC2 < 8BC[AD]) in the array.

> +		.driver_data = (void *)&omen_v1_thermal_params,
> +	},
>  	{
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BD4") },
>  		.driver_data = (void *)&victus_s_thermal_params,
> 

-- 
 i.
Re: [PATCH v3] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
Posted by Haichen Feng 1 month, 2 weeks ago 
Sorry for write wrong patch. It is my mistake. This patch move 8BC2 to the front of 8BCA.

Signed-off-by: Haichen Feng <2806891994@qq.com>
---
Change in v3:
 - Move 8BC2 to the front of 8BCA
---
 drivers/platform/x86/hp/hp-wmi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index d1cc6e7d1..a5cda787c 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -205,6 +205,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
 		.driver_data = (void *)&victus_s_thermal_params,
 	},
+	{
+		.matches = {DMI_MATCH(DMI_BOARD_NAME, "8BC2")},
+		.driver_data = (void *)&omen_v1_thermal_params,
+	},
 	{
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
 		.driver_data = (void *)&omen_v1_thermal_params,
-- 
2.54.0
Re: [PATCH v3] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
Posted by Ilpo Järvinen 1 month, 2 weeks ago 
On Fri, 1 May 2026, Haichen Feng wrote:

> Sorry for write wrong patch. It is my mistake. This patch move 8BC2 to 
> the front of 8BCA. 

Hi,

Thanks for the update but here you should describe the change. This text 
will be directly taken as the commit message of the resulting commit, so 
think of reviewers of your patch and those reading kernel's commit history 
later and write to those audiences.

I think the previous version had better text here (but this is based on my 
memory, I didn't actually go to fetch v2 from archives).

> Signed-off-by: Haichen Feng <2806891994@qq.com>
> ---
> Change in v3:
>  - Move 8BC2 to the front of 8BCA

If you want to have extra explanation about the process that got you here 
which should be put into the commit message, the place for such text is 
after the --- line like you have tha patch changelog (correctly) here.

-- 
 i.

> ---
>  drivers/platform/x86/hp/hp-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index d1cc6e7d1..a5cda787c 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -205,6 +205,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
>  		.driver_data = (void *)&victus_s_thermal_params,
>  	},
> +	{
> +		.matches = {DMI_MATCH(DMI_BOARD_NAME, "8BC2")},
> +		.driver_data = (void *)&omen_v1_thermal_params,
> +	},
>  	{
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
>  		.driver_data = (void *)&omen_v1_thermal_params,
>
Re: [PATCH v4] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
Posted by Haichen Feng 1 month, 2 weeks ago 
The HP Victus 16-r0xxx (board ID: 8BC2) has the same WMI as other Victus
S boards, but requires quirks for correctly switching thermal profile.

Add the DMI board name to victus_s_thermal_profile_boards[] table and
map it to omen_v1_thermal_params.

Testing on board 8BC2 confirmed that platform profile is registered
successfully and fan RPMs are readable and controllable.

Signed-off-by: Haichen Feng <2806891994@qq.com>
---
Change in v2:
 - Move code to correct place
 
Change in v3:
 - Move code to the front of 8BCA
 
Change in v4:
 - Add explanation about this patch
 - Insert a space at the second parenthesis in 8BC2 line
---
 drivers/platform/x86/hp/hp-wmi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index d1cc6e7d1..71a2093cc 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -205,6 +205,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
 		.driver_data = (void *)&victus_s_thermal_params,
 	},
+	{
+		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BC2") },
+		.driver_data = (void *)&omen_v1_thermal_params,
+	},
 	{
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
 		.driver_data = (void *)&omen_v1_thermal_params,
-- 
2.54.0
Re: [PATCH v4] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
Posted by Ilpo Järvinen 1 month, 1 week ago 
On Tue, 5 May 2026, Haichen Feng wrote:

> The HP Victus 16-r0xxx (board ID: 8BC2) has the same WMI as other Victus
> S boards, but requires quirks for correctly switching thermal profile.
> 
> Add the DMI board name to victus_s_thermal_profile_boards[] table and
> map it to omen_v1_thermal_params.
> 
> Testing on board 8BC2 confirmed that platform profile is registered
> successfully and fan RPMs are readable and controllable.
> 
> Signed-off-by: Haichen Feng <2806891994@qq.com>
> ---
> Change in v2:
>  - Move code to correct place
>  
> Change in v3:
>  - Move code to the front of 8BCA
>  
> Change in v4:
>  - Add explanation about this patch
>  - Insert a space at the second parenthesis in 8BC2 line
> ---
>  drivers/platform/x86/hp/hp-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index d1cc6e7d1..71a2093cc 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -205,6 +205,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BBE") },
>  		.driver_data = (void *)&victus_s_thermal_params,
>  	},
> +	{
> +		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BC2") },
> +		.driver_data = (void *)&omen_v1_thermal_params,
> +	},
>  	{
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
>  		.driver_data = (void *)&omen_v1_thermal_params,
> 

Hi,

Can you please resend this v4 into a new thread. b4 I use while applying 
patches seems to unable to  capture it from here and gets the wrong 
version.

-- 
 i.
[PATCH v2] platform/x86: hp-wmi: Add support for Victus 16-r0xxx (8BC2)
Posted by Haichen Feng 1 month, 2 weeks ago 
The HP Victus 16-r0xxx (board ID: 8BC2) has the same WMI as other Victus
S boards, but requires quirks for correctly switching thermal
profile.

Add the DMI board name to victus_s_thermal_profile_boards[] table and
map it to omen_v1_thermal_params.

Testing on board 8BC2 confirmed that platform profile is registered
successfully and fan RPMs are readable and controllable.

Signed-off-by: Haichen Feng <2806891994@qq.com>
---
Change in v2:
 - Move 8BC2 matching code to correct place
---
 drivers/platform/x86/hp/hp-wmi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index d1cc6e7d1..184eb920b 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -209,6 +209,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCA") },
 		.driver_data = (void *)&omen_v1_thermal_params,
 	},
+	{
+		.matches = {DMI_MATCH(DMI_BOARD_NAME, "8BC2")},
+		.driver_data = (void *)&omen_v1_thermal_params,
+	},
 	{
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BCD") },
 		.driver_data = (void *)&omen_v1_thermal_params,
-- 
2.54.0

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.