[PATCH v1 4/9] dt-bindings: timer: Add SpacemiT K1 CLINT

Yangyu Chen posted 9 patches 1 year, 6 months ago
There is a newer version of this series
[PATCH v1 4/9] dt-bindings: timer: Add SpacemiT K1 CLINT
Posted by Yangyu Chen 1 year, 6 months ago
Add compatible string for SpacemiT K1 CLINT.

Signed-off-by: Yangyu Chen <cyy@cyyself.name>
---
 Documentation/devicetree/bindings/timer/sifive,clint.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
index fced6f2d8ecb..860cf6a96b31 100644
--- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
+++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
@@ -43,7 +43,9 @@ properties:
               - thead,th1520-clint
           - const: thead,c900-clint
       - items:
-          - const: sifive,clint0
+          - enum:
+              - sifive,clint0
+              - spacemit,k1-clint
           - const: riscv,clint0
         deprecated: true
         description: For the QEMU virt machine only
-- 
2.45.1
Re: [PATCH v1 4/9] dt-bindings: timer: Add SpacemiT K1 CLINT
Posted by Conor Dooley 1 year, 6 months ago
On Mon, Jun 17, 2024 at 01:20:49AM +0800, Yangyu Chen wrote:
> Add compatible string for SpacemiT K1 CLINT.
> 
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Re: [PATCH v1 4/9] dt-bindings: timer: Add SpacemiT K1 CLINT
Posted by Yangyu Chen 1 year, 6 months ago
> On Jun 18, 2024, at 23:40, Conor Dooley <conor@kernel.org> wrote:
> 
> On Mon, Jun 17, 2024 at 01:20:49AM +0800, Yangyu Chen wrote:
>> Add compatible string for SpacemiT K1 CLINT.
>> 
>> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Actually, I'm not confident about this after carefully reviewing
the file. The "riscv,clint0" is marked deprecated, and the description
is For the QEMU virtual machine only.
Re: [PATCH v1 4/9] dt-bindings: timer: Add SpacemiT K1 CLINT
Posted by Conor Dooley 1 year, 6 months ago
On Tue, Jun 18, 2024 at 11:48:26PM +0800, Yangyu Chen wrote:
> 
> > On Jun 18, 2024, at 23:40, Conor Dooley <conor@kernel.org> wrote:
> > 
> > On Mon, Jun 17, 2024 at 01:20:49AM +0800, Yangyu Chen wrote:
> >> Add compatible string for SpacemiT K1 CLINT.
> >> 
> >> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Actually, I'm not confident about this after carefully reviewing
> the file. The "riscv,clint0" is marked deprecated, and the description
> is For the QEMU virtual machine only.

Right, I forgot about that portion of it. Probably, if this is sifive
plic compatible, then fall back to the sifive clint. Same, I suppose,
goes for the plic etc. The alternative is not have a fallback, modify
the driver, and future spacemit things will fall back to the k1's
compatible. I don't mind which you go for.