[PATCH] clocksource: delete unnecessary comments

Enlin Mu posted 1 patch 3 weeks, 1 day ago
kernel/time/clocksource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] clocksource: delete unnecessary comments
Posted by Enlin Mu 3 weeks, 1 day ago
From: Enlin Mu <enlin.mu@unisoc.com>

The new format is as follows:
  clocksource: jiffies mask:0xfff max_cycles:0xffff,max_idle_ns: 7645000 ns

Signed-off-by: Enlin Mu <enlin.mu@unisoc.com>
---
 kernel/time/clocksource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 0aef0e349e49..c70880376ec6 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -1218,7 +1218,7 @@ void __clocksource_update_freq_scale(struct clocksource *cs, u32 scale, u32 freq
 
 	clocksource_update_max_deferment(cs);
 
-	pr_info("%s: mask: 0x%llx max_cycles: 0x%llx, max_idle_ns: %lld ns\n",
+	pr_info("%s mask: 0x%llx max_cycles: 0x%llx, max_idle_ns: %lld ns\n",
 		cs->name, cs->mask, cs->max_cycles, cs->max_idle_ns);
 }
 EXPORT_SYMBOL_GPL(__clocksource_update_freq_scale);
-- 
2.39.5
Re: [PATCH] clocksource: delete unnecessary comments
Posted by Thomas Gleixner 3 weeks, 1 day ago
On Wed, Sep 10 2025 at 09:47, Enlin Mu wrote:
> From: Enlin Mu <enlin.mu@unisoc.com>
>
> The new format is as follows:
>   clocksource: jiffies mask:0xfff max_cycles:0xffff,max_idle_ns: 7645000 ns

What's the point of this exercise?

We are not changing stuff just because, there has to be a reason and a
justification for changes. See Documentation/process/ for further
information.

Also I don't see where this change deletes a comment in the code, which
is what the subject line claims to do.

Thanks,

        tglx