staging: rtl8723bs: Fix block comment coding style

[PATCH] staging: rtl8723bs: Fix block comment coding style

Posted by Zixuan Dong 2 days, 23 hours ago

Fix the following checkpatch warnings in os_intfs.c:

  WARNING: Block comments use * on subsequent lines
  WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Zixuan Dong <dbeidachazi@foxmail.com>
---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 6ca6dc548805..cd81d9e4a3d2 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
 	padapter->net_closed = true;
 	padapter->netif_up = false;
 
-/*if (!padapter->hw_init_completed)
-	{
-
-		padapter->bDriverStopped = true;
-
-		rtw_dev_unload(padapter);
-	}
-	else*/
+/*
+ * if (!padapter->hw_init_completed)
+ * {
+ *
+ *	padapter->bDriverStopped = true;
+ *
+ *	rtw_dev_unload(padapter);
+ * }
+ * else
+ */
 	if (pwrctl->rf_pwrstate == rf_on) {
 		/* s1. */
 		if (pnetdev) {
-- 
2.52.0

Re: [PATCH] staging: rtl8723bs: Fix block comment coding style

Posted by Dan Carpenter 2 days, 21 hours ago

On Mon, Dec 15, 2025 at 12:01:28PM +0800, Zixuan Dong wrote:
> Fix the following checkpatch warnings in os_intfs.c:
> 
>   WARNING: Block comments use * on subsequent lines
>   WARNING: Block comments use a trailing */ on a separate line
> 
> Signed-off-by: Zixuan Dong <dbeidachazi@foxmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 6ca6dc548805..cd81d9e4a3d2 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
>  	padapter->net_closed = true;
>  	padapter->netif_up = false;
>  
> -/*if (!padapter->hw_init_completed)
> -	{
> -
> -		padapter->bDriverStopped = true;
> -
> -		rtw_dev_unload(padapter);
> -	}
> -	else*/
> +/*
> + * if (!padapter->hw_init_completed)
> + * {
> + *
> + *	padapter->bDriverStopped = true;
> + *
> + *	rtw_dev_unload(padapter);
> + * }
> + * else
> + */

Just delete this dead code.

regards,
dan carpenter