[PATCH] rust: dma: remove incorrect safety documentation

Yilin Chen posted 1 patch 1 month, 2 weeks ago
There is a newer version of this series
rust/kernel/dma.rs | 2 --
1 file changed, 2 deletions(-)
[PATCH] rust: dma: remove incorrect safety documentation
Posted by Yilin Chen 1 month, 2 weeks ago
Removes a safety requirement that incorrectly states callers must
ensure the device does not access memory while the returned slice
is live, as this method doesn't return a slice.

Signed-off-by: Yilin <1479826151@qq.com>
---
 rust/kernel/dma.rs | 2 --
 1 file changed, 2 deletions(-)

diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs
index 84d3c67269e8..2ac107d8f7b7 100644
--- a/rust/kernel/dma.rs
+++ b/rust/kernel/dma.rs
@@ -532,8 +532,6 @@ pub unsafe fn as_slice_mut(&mut self, offset: usize, count: usize) -> Result<&mu
     ///
     /// # Safety
     ///
-    /// * Callers must ensure that the device does not read/write to/from memory while the returned
-    ///   slice is live.
     /// * Callers must ensure that this call does not race with a read or write to the same region
     ///   that overlaps with this write.
     ///
-- 
2.34.1
Re: [PATCH] rust: dma: remove incorrect safety documentation
Posted by Alice Ryhl 1 month, 1 week ago
On Sat, Dec 27, 2025 at 12:10:27AM +0800, Yilin Chen wrote:
> Removes a safety requirement that incorrectly states callers must
> ensure the device does not access memory while the returned slice
> is live, as this method doesn't return a slice.
> 
> Signed-off-by: Yilin <1479826151@qq.com>

This patch looks good to me, but the Signed-off-by does not match
your From: line. Please update this to:

Signed-off-by: Yilin Chen <1479826151@qq.com>

so that it matches the From: line.

Alice