arm: sunxi: fix f1c100s pinctrl function.

[PATCH] arm: sunxi: fix f1c100s pinctrl function.

Posted by IotaHydrae 4 years ago

1. change suniv f1c100s pinctrl,PD14 multiplexing function lvds1 to uart2

When the pin PD13 and PD14 is setting up to uart2 function in dts,
there's an error occurred:
1c20800.pinctrl: unsupported function uart2 on pin PD14

Because 'uart2' is not any one multiplexing option of PD14,
and pinctrl don't know how to configure it.

So change the pin PD14 lvds1 function to uart2.

Signed-off-by: IotaHydrae <writeforever@foxmail.com>
---
 drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
index 2801ca706273..68a5b627fb9b 100644
--- a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
+++ b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
@@ -204,7 +204,7 @@ static const struct sunxi_desc_pin suniv_f1c100s_pins[] = {
 		  SUNXI_FUNCTION(0x0, "gpio_in"),
 		  SUNXI_FUNCTION(0x1, "gpio_out"),
 		  SUNXI_FUNCTION(0x2, "lcd"),		/* D20 */
-		  SUNXI_FUNCTION(0x3, "lvds1"),		/* RX */
+		  SUNXI_FUNCTION(0x3, "uart2"),		/* RX */
 		  SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 14)),
 	SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 15),
 		  SUNXI_FUNCTION(0x0, "gpio_in"),
-- 
2.32.0

Re: [PATCH] arm: sunxi: fix f1c100s pinctrl function.

Posted by Linus Walleij 3 years, 12 months ago

On Wed, May 4, 2022 at 1:59 PM IotaHydrae <writeforever@foxmail.com> wrote:

> 1. change suniv f1c100s pinctrl,PD14 multiplexing function lvds1 to uart2
>
> When the pin PD13 and PD14 is setting up to uart2 function in dts,
> there's an error occurred:
> 1c20800.pinctrl: unsupported function uart2 on pin PD14
>
> Because 'uart2' is not any one multiplexing option of PD14,
> and pinctrl don't know how to configure it.
>
> So change the pin PD14 lvds1 function to uart2.
>
> Signed-off-by: IotaHydrae <writeforever@foxmail.com>

Thanks, fixed up the subject as indicated by Andre
and applied.

Yours,
Linus Walleij

Re: [PATCH] arm: sunxi: fix f1c100s pinctrl function.

Posted by Andre Przywara 4 years ago

On Wed,  4 May 2022 19:59:04 +0800
IotaHydrae <writeforever@foxmail.com> wrote:

Hi,

thanks for the patch!

I think the subject should start with: "pinctrl: sunxi:", also please
mention the UART in there.

> 1. change suniv f1c100s pinctrl,PD14 multiplexing function lvds1 to uart2
> 
> When the pin PD13 and PD14 is setting up to uart2 function in dts,
> there's an error occurred:
> 1c20800.pinctrl: unsupported function uart2 on pin PD14
> 
> Because 'uart2' is not any one multiplexing option of PD14,
> and pinctrl don't know how to configure it.
> 
> So change the pin PD14 lvds1 function to uart2.
> 
> Signed-off-by: IotaHydrae <writeforever@foxmail.com>

Compared against the manual, looks correct:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

P.S. I used to opportunity to check all other functions as well, apart
from one error in the comments they were correct. Will send a patch.

> ---
>  drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> index 2801ca706273..68a5b627fb9b 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> @@ -204,7 +204,7 @@ static const struct sunxi_desc_pin suniv_f1c100s_pins[] = {
>  		  SUNXI_FUNCTION(0x0, "gpio_in"),
>  		  SUNXI_FUNCTION(0x1, "gpio_out"),
>  		  SUNXI_FUNCTION(0x2, "lcd"),		/* D20 */
> -		  SUNXI_FUNCTION(0x3, "lvds1"),		/* RX */
> +		  SUNXI_FUNCTION(0x3, "uart2"),		/* RX */
>  		  SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 14)),
>  	SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 15),
>  		  SUNXI_FUNCTION(0x0, "gpio_in"),