Disabling options other than memory is currently
supported according to the cgroup_disable function.
So it can be removed.

Signed-off-by: Jianhui Zhou <jianhuizz@qq.com>
---
 Documentation/admin-guide/kernel-parameters.txt | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 3872bc6ec49d..3c562653016f 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -609,9 +609,6 @@
 			- if foo is an optional feature then the feature is
 			  disabled and corresponding cgroup files are not
 			  created
-			{Currently only "memory" controller deal with this and
-			cut the overhead, others just disable the usage. So
-			only cgroup_disable=memory is actually worthy}
 			Specifying "pressure" disables per-cgroup pressure
 			stall information accounting feature
 
-- 
2.25.1

It would have been good to include the cgroup maintainer here; adding
Tejun.

Looking at the code, it's far from clear to me that the other cgroups
pay attention to this parameter.  Can somebody convince me that this
change is correct?

Thanks,

jon

Jianhui Zhou <jianhuizz@qq.com> writes:

> Disabling options other than memory is currently
> supported according to the cgroup_disable function.
> So it can be removed.
>
> Signed-off-by: Jianhui Zhou <jianhuizz@qq.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 3872bc6ec49d..3c562653016f 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -609,9 +609,6 @@
>  			- if foo is an optional feature then the feature is
>  			  disabled and corresponding cgroup files are not
>  			  created
> -			{Currently only "memory" controller deal with this and
> -			cut the overhead, others just disable the usage. So
> -			only cgroup_disable=memory is actually worthy}
>  			Specifying "pressure" disables per-cgroup pressure
>  			stall information accounting feature
>  
> -- 
> 2.25.1

Hello,

On Thu, Jan 09, 2025 at 12:44:15PM -0700, Jonathan Corbet wrote:
> It would have been good to include the cgroup maintainer here; adding
> Tejun.
> 
> Looking at the code, it's far from clear to me that the other cgroups
> pay attention to this parameter.  Can somebody convince me that this
> change is correct?

I don't think the patch is correct. The extra comment does still hold.

Thanks.

-- 
tejun