mm/mempolicy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the review and suggestion. I agree that depending on indirect
includes isn't ideal. This patch followed your suggestion and now directly
includes pagemap.h in mempolicy.c
Signed-off-by: Junjie Fu <fujunjie1@qq.com>
---
mm/mempolicy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 88eef9776bb0..c3f25a7951e0 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -113,7 +113,7 @@
#include <asm/tlbflush.h>
#include <asm/tlb.h>
#include <linux/uaccess.h>
-
+#include <linux/pagemap.h>
#include "internal.h"
/* Internal flags */
--
2.34.1
On Sat, Dec 07, 2024 at 04:14:30PM +0800, Junjie Fu wrote: > @@ -113,7 +113,7 @@ > #include <asm/tlbflush.h> > #include <asm/tlb.h> > #include <linux/uaccess.h> > - > +#include <linux/pagemap.h> > #include "internal.h" This is in the wrong place. The linux/ includes go before the asm/ includes. I like to stick to alphabetical order within that divide, but other people have other preferences.
Thank you for your reminder. I have changed the place where the header
file was imported again.
Signed-off-by: Junjie Fu <fujunjie1@qq.com>
---
mm/mempolicy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 88eef9776bb0..9ee22263591d 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -109,6 +109,7 @@
#include <linux/mmu_notifier.h>
#include <linux/printk.h>
#include <linux/swapops.h>
+#include <linux/pagemap.h>
#include <asm/tlbflush.h>
#include <asm/tlb.h>
--
2.34.1
© 2016 - 2025 Red Hat, Inc.