1. Patchew
  2. linux
  3. View series

[PATCH v2] staging: greybus: audio_manager_module: make envp array static const

Chang Junzheng posted 1 patch 2 months, 3 weeks ago
There is a newer version of this series
drivers/staging/greybus/audio_manager_module.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
[PATCH v2] staging: greybus: audio_manager_module: make envp array static const
Posted by Chang Junzheng 2 months, 3 weeks ago 
From: Chang Junzheng <guagua210311@outlook.com>

Fix checkpatch.pl warning by changing envp array declaration to
static const char * const. This improves code safety and follows
kernel coding style recommendations.

Signed-off-by: Chang Junzheng <guagua210311@qq.com>
Changes in v2:
- Restored original indentation of array elements
- Only changed the array declaration as originally intended
---
 drivers/staging/greybus/audio_manager_module.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
index 4a4dfb42f50f..78013d59fc93 100644
--- a/drivers/staging/greybus/audio_manager_module.c
+++ b/drivers/staging/greybus/audio_manager_module.c
@@ -159,14 +159,14 @@ static void send_add_uevent(struct gb_audio_manager_module *module)
 	char ip_devices_string[64];
 	char op_devices_string[64];
 
-	char *envp[] = {
-		name_string,
-		vid_string,
-		pid_string,
-		intf_id_string,
-		ip_devices_string,
-		op_devices_string,
-		NULL
+	static const char * const envp[] = {
+	name_string,
+	vid_string,
+	pid_string,
+	intf_id_string,
+	ip_devices_string,
+	op_devices_string,
+	NULL
 	};
 
 	snprintf(name_string, 128, "NAME=%s", module->desc.name);
-- 
2.43.0
Re: [PATCH v2] staging: greybus: audio_manager_module: make envp array static const
Posted by kernel test robot 2 months, 3 weeks ago 
Hi Chang,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Chang-Junzheng/staging-greybus-audio_manager_module-make-envp-array-static-const/20251113-222509
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/tencent_3725607DD617A567779DEB1BEC7C3B335208%40qq.com
patch subject: [PATCH v2] staging: greybus: audio_manager_module: make envp array static const
config: arm-randconfig-001-20251114 (https://download.01.org/0day-ci/archive/20251114/202511140945.OPHTq1yc-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511140945.OPHTq1yc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511140945.OPHTq1yc-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/staging/greybus/audio_manager_module.c: In function 'send_add_uevent':
>> drivers/staging/greybus/audio_manager_module.c:163:9: error: initializer element is not constant
     163 |         name_string,
         |         ^~~~~~~~~~~
   drivers/staging/greybus/audio_manager_module.c:163:9: note: (near initialization for 'envp[0]')
   drivers/staging/greybus/audio_manager_module.c:164:9: error: initializer element is not constant
     164 |         vid_string,
         |         ^~~~~~~~~~
   drivers/staging/greybus/audio_manager_module.c:164:9: note: (near initialization for 'envp[1]')
   drivers/staging/greybus/audio_manager_module.c:165:9: error: initializer element is not constant
     165 |         pid_string,
         |         ^~~~~~~~~~
   drivers/staging/greybus/audio_manager_module.c:165:9: note: (near initialization for 'envp[2]')
   drivers/staging/greybus/audio_manager_module.c:166:9: error: initializer element is not constant
     166 |         intf_id_string,
         |         ^~~~~~~~~~~~~~
   drivers/staging/greybus/audio_manager_module.c:166:9: note: (near initialization for 'envp[3]')
   drivers/staging/greybus/audio_manager_module.c:167:9: error: initializer element is not constant
     167 |         ip_devices_string,
         |         ^~~~~~~~~~~~~~~~~
   drivers/staging/greybus/audio_manager_module.c:167:9: note: (near initialization for 'envp[4]')
   drivers/staging/greybus/audio_manager_module.c:168:9: error: initializer element is not constant
     168 |         op_devices_string,
         |         ^~~~~~~~~~~~~~~~~
   drivers/staging/greybus/audio_manager_module.c:168:9: note: (near initialization for 'envp[5]')
>> drivers/staging/greybus/audio_manager_module.c:181:53: error: passing argument 3 of 'kobject_uevent_env' from incompatible pointer type [-Wincompatible-pointer-types]
     181 |         kobject_uevent_env(&module->kobj, KOBJ_ADD, envp);
         |                                                     ^~~~
         |                                                     |
         |                                                     const char * const*
   In file included from drivers/staging/greybus/audio_manager.h:11,
                    from drivers/staging/greybus/audio_manager_module.c:10:
   include/linux/kobject.h:216:31: note: expected 'char **' but argument is of type 'const char * const*'
     216 |                         char *envp[]);
         |                         ~~~~~~^~~~~~


vim +163 drivers/staging/greybus/audio_manager_module.c

8db00736d365b7 Svetlin Ankov    2016-01-13  152  
8db00736d365b7 Svetlin Ankov    2016-01-13  153  static void send_add_uevent(struct gb_audio_manager_module *module)
8db00736d365b7 Svetlin Ankov    2016-01-13  154  {
8db00736d365b7 Svetlin Ankov    2016-01-13  155  	char name_string[128];
8db00736d365b7 Svetlin Ankov    2016-01-13  156  	char vid_string[64];
8db00736d365b7 Svetlin Ankov    2016-01-13  157  	char pid_string[64];
d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16  158  	char intf_id_string[64];
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  159  	char ip_devices_string[64];
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  160  	char op_devices_string[64];
8db00736d365b7 Svetlin Ankov    2016-01-13  161  
9af5fbe96477a4 Chang Junzheng   2025-11-13  162  	static const char * const envp[] = {
8db00736d365b7 Svetlin Ankov    2016-01-13 @163  	name_string,
8db00736d365b7 Svetlin Ankov    2016-01-13  164  	vid_string,
8db00736d365b7 Svetlin Ankov    2016-01-13  165  	pid_string,
d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16  166  	intf_id_string,
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  167  	ip_devices_string,
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  168  	op_devices_string,
8db00736d365b7 Svetlin Ankov    2016-01-13  169  	NULL
8db00736d365b7 Svetlin Ankov    2016-01-13  170  	};
8db00736d365b7 Svetlin Ankov    2016-01-13  171  
8db00736d365b7 Svetlin Ankov    2016-01-13  172  	snprintf(name_string, 128, "NAME=%s", module->desc.name);
8db00736d365b7 Svetlin Ankov    2016-01-13  173  	snprintf(vid_string, 64, "VID=%d", module->desc.vid);
8db00736d365b7 Svetlin Ankov    2016-01-13  174  	snprintf(pid_string, 64, "PID=%d", module->desc.pid);
d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16  175  	snprintf(intf_id_string, 64, "INTF_ID=%d", module->desc.intf_id);
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  176  	snprintf(ip_devices_string, 64, "I/P DEVICES=0x%X",
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  177  		 module->desc.ip_devices);
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  178  	snprintf(op_devices_string, 64, "O/P DEVICES=0x%X",
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  179  		 module->desc.op_devices);
8db00736d365b7 Svetlin Ankov    2016-01-13  180  
8db00736d365b7 Svetlin Ankov    2016-01-13 @181  	kobject_uevent_env(&module->kobj, KOBJ_ADD, envp);
8db00736d365b7 Svetlin Ankov    2016-01-13  182  }
8db00736d365b7 Svetlin Ankov    2016-01-13  183  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Re: [PATCH v2] staging: greybus: audio_manager_module: make envp array static const
Posted by Greg Kroah-Hartman 2 months, 3 weeks ago 
On Thu, Nov 13, 2025 at 10:12:00PM +0800, Chang Junzheng wrote:
> From: Chang Junzheng <guagua210311@outlook.com>
> 
> Fix checkpatch.pl warning by changing envp array declaration to
> static const char * const. This improves code safety and follows
> kernel coding style recommendations.
> 
> Signed-off-by: Chang Junzheng <guagua210311@qq.com>
> Changes in v2:
> - Restored original indentation of array elements
> - Only changed the array declaration as originally intended

The "Changes" goes below the --- line, as per the documentation.

thanks,

greg k-h

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.