[v1] media: rj54n1cb0c: Fix memleak in rj54n1_probe()

[PATCH] media: rj54n1cb0c: Fix memleak in rj54n1_probe()

Zhang Shurong posted 1 patch 3 months, 2 weeks ago

Diff against v2 v3 v4
Download mbox

There is a newer version of this series

drivers/media/i2c/rj54n1cb0c.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] media: rj54n1cb0c: Fix memleak in rj54n1_probe()

Posted by Zhang Shurong 3 months, 2 weeks ago

rj54n1_probe() won't clean all the allocated resources in fail
path, which may causes the memleaks. Add v4l2_ctrl_handler_free() to
prevent memleak.

Fixes: f187352dcd45 ("media: i2c: Copy rj54n1cb0c soc_camera sensor driver")
Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
---
 drivers/media/i2c/rj54n1cb0c.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/rj54n1cb0c.c b/drivers/media/i2c/rj54n1cb0c.c
index b7ca39f63dba..b788c7cec5f9 100644
--- a/drivers/media/i2c/rj54n1cb0c.c
+++ b/drivers/media/i2c/rj54n1cb0c.c
@@ -1331,6 +1331,7 @@ static int rj54n1_probe(struct i2c_client *client)
 			V4L2_CID_AUTO_WHITE_BALANCE, 0, 1, 1, 1);
 	rj54n1->subdev.ctrl_handler = &rj54n1->hdl;
 	if (rj54n1->hdl.error)
+		v4l2_ctrl_handler_free(&rj54n1->hdl);
 		return rj54n1->hdl.error;
 
 	rj54n1->clk_div		= clk_div;
-- 
2.30.2