usb: dwc3: gadget: remove not used field dwc3_request.sg

[PATCH] usb: dwc3: gadget: remove not used field dwc3_request.sg

Posted by Renjun Wang 12 months ago

Based on commit 61440628a4ff ("usb: dwc3: gadget: Cleanup SG handling"),
the field dwc3_request.sg is no longer needed and not used in any
other files, remove it.

Signed-off-by: Renjun Wang <renjunw0@foxmail.com>
---
 drivers/usb/dwc3/core.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index ee73789326bc..3be069c4520e 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -956,7 +956,6 @@ struct dwc3_request {
 	struct usb_request	request;
 	struct list_head	list;
 	struct dwc3_ep		*dep;
-	struct scatterlist	*sg;
 	struct scatterlist	*start_sg;
 
 	unsigned int		num_pending_sgs;
-- 
2.39.5

Re: [PATCH] usb: dwc3: gadget: remove not used field dwc3_request.sg

Posted by Selvarasu Ganesan 12 months ago

On 12/19/2024 8:42 PM, Renjun Wang wrote:
> Based on commit 61440628a4ff ("usb: dwc3: gadget: Cleanup SG handling"),
> the field dwc3_request.sg is no longer needed and not used in any
> other files, remove it.
>
> Signed-off-by: Renjun Wang <renjunw0@foxmail.com>
> ---
>   drivers/usb/dwc3/core.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index ee73789326bc..3be069c4520e 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -956,7 +956,6 @@ struct dwc3_request {
>   	struct usb_request	request;
>   	struct list_head	list;
>   	struct dwc3_ep		*dep;
> -	struct scatterlist	*sg;
>   	struct scatterlist	*start_sg;
>   
>   	unsigned int		num_pending_sgs;
The same change has already been incorporated as part of the following 
commit.
commit: 686d4a2c26b49 ("usb: dwc3: remove unused sg struct member")

Re: [PATCH] usb: dwc3: gadget: remove not used field dwc3_request.sg

Posted by Ahmad Fatoum 12 months ago

On 19.12.24 16:12, Renjun Wang wrote:
> Based on commit 61440628a4ff ("usb: dwc3: gadget: Cleanup SG handling"),
> the field dwc3_request.sg is no longer needed and not used in any
> other files, remove it.
> 
> Signed-off-by: Renjun Wang <renjunw0@foxmail.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  drivers/usb/dwc3/core.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index ee73789326bc..3be069c4520e 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -956,7 +956,6 @@ struct dwc3_request {
>  	struct usb_request	request;
>  	struct list_head	list;
>  	struct dwc3_ep		*dep;
> -	struct scatterlist	*sg;
>  	struct scatterlist	*start_sg;
>  
>  	unsigned int		num_pending_sgs;


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |