staging: rtl8723bs: select CONFIG_CRYPTO_LIB_AES

[PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_AES

Posted by Yeking@Red54.com 11 months, 2 weeks ago

From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>

This fixes the following issue:
ERROR: modpost: "aes_expandkey" [drivers/staging/rtl8723bs/r8723bs.ko]
undefined!
ERROR: modpost: "aes_encrypt" [drivers/staging/rtl8723bs/r8723bs.ko]
undefined!

Fixes: 7d40753d8820 ("staging: rtl8723bs: use in-kernel aes encryption in OMAC1 routines")
Fixes: 3d3a170f6d80 ("staging: rtl8723bs: use in-kernel aes encryption")
Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
---
 drivers/staging/rtl8723bs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig
index 8d48c61961a6..353e6ee2c145 100644
--- a/drivers/staging/rtl8723bs/Kconfig
+++ b/drivers/staging/rtl8723bs/Kconfig
@@ -4,6 +4,7 @@ config RTL8723BS
 	depends on WLAN && MMC && CFG80211
 	depends on m
 	select CRYPTO
+	select CRYPTO_LIB_AES
 	select CRYPTO_LIB_ARC4
 	help
 	This option enables support for RTL8723BS SDIO drivers, such as
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_AES

Posted by Hans de Goede 11 months, 2 weeks ago

Hi,

On 22-Feb-25 8:36 PM, Yeking@Red54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
> 
> This fixes the following issue:
> ERROR: modpost: "aes_expandkey" [drivers/staging/rtl8723bs/r8723bs.ko]
> undefined!
> ERROR: modpost: "aes_encrypt" [drivers/staging/rtl8723bs/r8723bs.ko]
> undefined!
> 
> Fixes: 7d40753d8820 ("staging: rtl8723bs: use in-kernel aes encryption in OMAC1 routines")
> Fixes: 3d3a170f6d80 ("staging: rtl8723bs: use in-kernel aes encryption")
> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>  drivers/staging/rtl8723bs/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig
> index 8d48c61961a6..353e6ee2c145 100644
> --- a/drivers/staging/rtl8723bs/Kconfig
> +++ b/drivers/staging/rtl8723bs/Kconfig
> @@ -4,6 +4,7 @@ config RTL8723BS
>  	depends on WLAN && MMC && CFG80211
>  	depends on m
>  	select CRYPTO
> +	select CRYPTO_LIB_AES
>  	select CRYPTO_LIB_ARC4
>  	help
>  	This option enables support for RTL8723BS SDIO drivers, such as