HID: hyperv: fix build breakage with certain configs

[PATCH] HID: hyperv: fix build breakage with certain configs

Posted by Jiri Kosina 1 month, 1 week ago

From: Jiri Kosina <jkosina@suse.com>

If CONFIG_HID_HYPERV is built-in (=y) while CONFIG_KUNIT is either 
disabled (=n) or built as a module (=m), the linker fails to resolve 
kunit_mem_assert_format when creating vmlinux.

Fix the dependencies in Kconfig.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202608190536.d9qCkWWc-lkp@intel.com/
Fixes: 83df7b5fa6735b5084ecd2 ("HID: hyperv: add KUnit coverage for device info bounds")
Signed-off-by: Jiri Kosina <jkosina@suse.com>
---
 drivers/hid/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index aa7fa11a0197..a81bf51cbcf1 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -1253,7 +1253,7 @@ config HID_HYPERV_MOUSE
 
 config HID_HYPERV_MOUSE_KUNIT_TEST
 	bool "KUnit tests for Hyper-V mouse driver" if !KUNIT_ALL_TESTS
-	depends on KUNIT && HID_HYPERV_MOUSE
+	depends on KUNIT && (HID_HYPERV_MOUSE = KUNIT || KUNIT = y)
 	default KUNIT_ALL_TESTS
 	help
 	  Builds unit tests for the Hyper-V synthetic HID driver.
-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] HID: hyperv: fix build breakage with certain configs

Posted by Benjamin Tissoires 1 month, 1 week ago

On Aug 21 2026, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.com>
> 
> If CONFIG_HID_HYPERV is built-in (=y) while CONFIG_KUNIT is either 
> disabled (=n) or built as a module (=m), the linker fails to resolve 
> kunit_mem_assert_format when creating vmlinux.

I believe the commit description is wrong here. If CONFIG_KUNIT=n,
because HID_HYPERV_MOUSE_KUNIT_TEST `depends on KUNIT`, there is no issue.

That being said, this is just the commit description which is wrong, the
code looks good to me. With that fixed:
Acked-by: Benjamin Tissoires <bentiss@kernel.org>

Cheers,
Benjamin

> 
> Fix the dependencies in Kconfig.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202608190536.d9qCkWWc-lkp@intel.com/
> Fixes: 83df7b5fa6735b5084ecd2 ("HID: hyperv: add KUnit coverage for device info bounds")
> Signed-off-by: Jiri Kosina <jkosina@suse.com>
> ---
>  drivers/hid/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index aa7fa11a0197..a81bf51cbcf1 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -1253,7 +1253,7 @@ config HID_HYPERV_MOUSE
>  
>  config HID_HYPERV_MOUSE_KUNIT_TEST
>  	bool "KUnit tests for Hyper-V mouse driver" if !KUNIT_ALL_TESTS
> -	depends on KUNIT && HID_HYPERV_MOUSE
> +	depends on KUNIT && (HID_HYPERV_MOUSE = KUNIT || KUNIT = y)
>  	default KUNIT_ALL_TESTS
>  	help
>  	  Builds unit tests for the Hyper-V synthetic HID driver.
> -- 
> Jiri Kosina
> SUSE Labs
> 
>

Re: [PATCH] HID: hyperv: fix build breakage with certain configs

Posted by Jiri Kosina 1 month, 1 week ago

On Fri, 21 Aug 2026, Benjamin Tissoires wrote:

> On Aug 21 2026, Jiri Kosina wrote:
> > From: Jiri Kosina <jkosina@suse.com>
> > 
> > If CONFIG_HID_HYPERV is built-in (=y) while CONFIG_KUNIT is either 
> > disabled (=n) or built as a module (=m), the linker fails to resolve 
> > kunit_mem_assert_format when creating vmlinux.
> 
> I believe the commit description is wrong here. If CONFIG_KUNIT=n,
> because HID_HYPERV_MOUSE_KUNIT_TEST `depends on KUNIT`, there is no issue.
> 
> That being said, this is just the commit description which is wrong, the
> code looks good to me. With that fixed:
> Acked-by: Benjamin Tissoires <bentiss@kernel.org>

Good catch, thanks. Fixed wording and applied.

-- 
Jiri Kosina
SUSE Labs