[PATCH] drivers/tty: Fix typos in comments

pangzizhen001@208suo.com posted 1 patch 2 years, 6 months ago
drivers/tty/n_gsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] drivers/tty: Fix typos in comments
Posted by pangzizhen001@208suo.com 2 years, 6 months ago
Delete duplicate word "the"

Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
---
  drivers/tty/n_gsm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index b411a26cc092..e8cd1e07eafe 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1148,7 +1148,7 @@ static void __gsm_data_queue(struct gsm_dlci 
*dlci, struct gsm_msg *msg)
   *
   *    Add data to the transmit queue and try and get stuff moving
   *    out of the mux tty if not already doing so. Take the
- *    the gsm tx lock and dlci lock.
+ *    gsm tx lock and dlci lock.
   */

  static void gsm_data_queue(struct gsm_dlci *dlci, struct gsm_msg *msg)
Re: [PATCH] drivers/tty: Fix typos in comments
Posted by Greg KH 2 years, 6 months ago
On Wed, Jul 19, 2023 at 12:22:25AM +0800, pangzizhen001@208suo.com wrote:
> Delete duplicate word "the"
> 
> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> ---
>  drivers/tty/n_gsm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index b411a26cc092..e8cd1e07eafe 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -1148,7 +1148,7 @@ static void __gsm_data_queue(struct gsm_dlci *dlci,
> struct gsm_msg *msg)
>   *
>   *    Add data to the transmit queue and try and get stuff moving
>   *    out of the mux tty if not already doing so. Take the
> - *    the gsm tx lock and dlci lock.
> + *    gsm tx lock and dlci lock.
>   */
> 
>  static void gsm_data_queue(struct gsm_dlci *dlci, struct gsm_msg *msg)

Please learn how to get involved in kernel development by working in
drivers/staging/* first, as the developers there are used to simple
errors like what you did here, and will work to help you out.

Otherwise, patches like this are just going to cause developers to get
grumpy when you have obvious errors.

good luck!

greg k-h
[PATCH] drivers/tty: Fix typos in comments
Posted by pangzizhen001@208suo.com 2 years, 6 months ago
Delete duplicate word "the"

Signed-off-by: Zizhen Pang <pangzizhen001@208suo.com>
---
  drivers/tty/n_gsm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index b411a26cc092..e8cd1e07eafe 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1148,7 +1148,7 @@ static void __gsm_data_queue(struct gsm_dlci 
*dlci, struct gsm_msg *msg)
   *
   *    Add data to the transmit queue and try and get stuff moving
   *    out of the mux tty if not already doing so. Take the
- *    the gsm tx lock and dlci lock.
+ *    gsm tx lock and dlci lock.
   */

  static void gsm_data_queue(struct gsm_dlci *dlci, struct gsm_msg *msg)