[PATCH] libbpf: zip: Remove unneeded semicolon from zip_archive_open()

baomingtong001@208suo.com posted 1 patch 2 years, 7 months ago
tools/lib/bpf/zip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] libbpf: zip: Remove unneeded semicolon from zip_archive_open()
Posted by baomingtong001@208suo.com 2 years, 7 months ago
./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon

Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
  tools/lib/bpf/zip.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/bpf/zip.c b/tools/lib/bpf/zip.c
index 3f26d629b2b4..88c376a8348d 100644
--- a/tools/lib/bpf/zip.c
+++ b/tools/lib/bpf/zip.c
@@ -223,7 +223,7 @@ struct zip_archive *zip_archive_open(const char 
*path)
      if (!archive) {
          munmap(data, size);
          return ERR_PTR(-ENOMEM);
-    };
+    }

      archive->data = data;
      archive->size = size;
Re: [PATCH] libbpf: zip: Remove unneeded semicolon from zip_archive_open()
Posted by Andrii Nakryiko 2 years, 7 months ago
On Wed, Jun 14, 2023 at 1:29 AM <baomingtong001@208suo.com> wrote:
>
> ./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon

This is not a very human-readable commit message. Something like

Drop unnecessary semicolon, which triggers (presumable coccicheck?) warning:

./tools/lib/bpf/zip.c:226:2-3: Unneeded semicolon


But also this doesn't apply cleanly to bpf-next tree. Please rebase
and resend. Also make sure to have [PATCH bpf-next] prefix in email
subject. Thanks.

>
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
>   tools/lib/bpf/zip.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/zip.c b/tools/lib/bpf/zip.c
> index 3f26d629b2b4..88c376a8348d 100644
> --- a/tools/lib/bpf/zip.c
> +++ b/tools/lib/bpf/zip.c
> @@ -223,7 +223,7 @@ struct zip_archive *zip_archive_open(const char
> *path)
>       if (!archive) {
>           munmap(data, size);
>           return ERR_PTR(-ENOMEM);
> -    };
> +    }
>
>       archive->data = data;
>       archive->size = size;