[PATCH] clocksource: Fix warnings in mshyperv.h

huzhi001@208suo.com posted 1 patch 2 years, 6 months ago
arch/x86/include/asm/mshyperv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] clocksource: Fix warnings in mshyperv.h
Posted by huzhi001@208suo.com 2 years, 6 months ago
The following checkpatch warnings are removed:
WARNING: Use #include <linux/io.h> instead of <asm/io.h>

Signed-off-by: ZhiHu <huzhi001@208suo.com>
---
  arch/x86/include/asm/mshyperv.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/mshyperv.h 
b/arch/x86/include/asm/mshyperv.h
index 88d9ef98e087..fa83d88e4c99 100644
--- a/arch/x86/include/asm/mshyperv.h
+++ b/arch/x86/include/asm/mshyperv.h
@@ -5,7 +5,7 @@
  #include <linux/types.h>
  #include <linux/nmi.h>
  #include <linux/msi.h>
-#include <asm/io.h>
+#include <linux/io.h>
  #include <asm/hyperv-tlfs.h>
  #include <asm/nospec-branch.h>
  #include <asm/paravirt.h>
RE: [PATCH] clocksource: Fix warnings in mshyperv.h
Posted by Michael Kelley (LINUX) 2 years, 6 months ago
From: huzhi001@208suo.com <huzhi001@208suo.com> Sent: Wednesday, July 12, 2023 4:23 AM
> 
> The following checkpatch warnings are removed:
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>

The "Subject:" of the patch should probably start with "x86/hyperv",
not "clocksource".  Usually I look back at the commit history of a
particular file and try to be consistent with the Subject: prefix that
has been used in the past.  "x86/hyperv" is typical for this
include file.

Other than that,

Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> 
> Signed-off-by: ZhiHu <huzhi001@208suo.com>
> ---
>   arch/x86/include/asm/mshyperv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/mshyperv.h
> b/arch/x86/include/asm/mshyperv.h
> index 88d9ef98e087..fa83d88e4c99 100644
> --- a/arch/x86/include/asm/mshyperv.h
> +++ b/arch/x86/include/asm/mshyperv.h
> @@ -5,7 +5,7 @@
>   #include <linux/types.h>
>   #include <linux/nmi.h>
>   #include <linux/msi.h>
> -#include <asm/io.h>
> +#include <linux/io.h>
>   #include <asm/hyperv-tlfs.h>
>   #include <asm/nospec-branch.h>
>   #include <asm/paravirt.h>
Re: [PATCH] clocksource: Fix warnings in mshyperv.h
Posted by Wei Liu 2 years, 6 months ago
On Wed, Jul 12, 2023 at 09:06:30PM +0000, Michael Kelley (LINUX) wrote:
> From: huzhi001@208suo.com <huzhi001@208suo.com> Sent: Wednesday, July 12, 2023 4:23 AM
> > 
> > The following checkpatch warnings are removed:
> > WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> 
> The "Subject:" of the patch should probably start with "x86/hyperv",
> not "clocksource".  Usually I look back at the commit history of a
> particular file and try to be consistent with the Subject: prefix that
> has been used in the past.  "x86/hyperv" is typical for this
> include file.
> 
> Other than that,
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

There is only one warning fixed.

I changed the subject line and commit message.

Applied to hyperv-fixes. Thanks.

> > 
> > Signed-off-by: ZhiHu <huzhi001@208suo.com>
> > ---
> >   arch/x86/include/asm/mshyperv.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/include/asm/mshyperv.h
> > b/arch/x86/include/asm/mshyperv.h
> > index 88d9ef98e087..fa83d88e4c99 100644
> > --- a/arch/x86/include/asm/mshyperv.h
> > +++ b/arch/x86/include/asm/mshyperv.h
> > @@ -5,7 +5,7 @@
> >   #include <linux/types.h>
> >   #include <linux/nmi.h>
> >   #include <linux/msi.h>
> > -#include <asm/io.h>
> > +#include <linux/io.h>
> >   #include <asm/hyperv-tlfs.h>
> >   #include <asm/nospec-branch.h>
> >   #include <asm/paravirt.h>