drivers/edac/ie31200_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Sparse reports:
drivers/edac/ie31200_edac.c:709:19: warning: symbol 'rpl_s_cfg' was not
declared. Should it be static?
rpl_s_cfg is only used within this file, so mark it static to fix the
warning
Signed-off-by: Marilene Andrade Garcia <marilene.agarcia@gmail.com>
---
Hello maintainers,
After running Sparse in the linux-next branch, I noticed the above warning.
I would was wondering if you agree with this proposed fix.
Thank you for your time.
Best regards,
Marilene Andrade Garcia
drivers/edac/ie31200_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/ie31200_edac.c b/drivers/edac/ie31200_edac.c
index eaab6af143e1..a5dc4b88097f 100644
--- a/drivers/edac/ie31200_edac.c
+++ b/drivers/edac/ie31200_edac.c
@@ -706,7 +706,7 @@ static struct res_config skl_cfg = {
.reg_mad_dimm_width_mask[1] = GENMASK(25, 24),
};
-struct res_config rpl_s_cfg = {
+static struct res_config rpl_s_cfg = {
.mtype = MEM_DDR5,
.cmci = true,
.imc_num = 2,
base-commit: e77a5a5cfe43b4c25bd44a3818e487033287517f
--
2.34.1
On Fri, Mar 27, 2026 at 11:55:57AM -0300, Marilene Andrade Garcia wrote:
> Sparse reports:
> drivers/edac/ie31200_edac.c:709:19: warning: symbol 'rpl_s_cfg' was not
> declared. Should it be static?
>
> rpl_s_cfg is only used within this file, so mark it static to fix the
> warning
>
> Signed-off-by: Marilene Andrade Garcia <marilene.agarcia@gmail.com>
> ---
>
> Hello maintainers,
>
> After running Sparse in the linux-next branch, I noticed the above warning.
> I would was wondering if you agree with this proposed fix.
>
> Thank you for your time.
>
> Best regards,
> Marilene Andrade Garcia
>
> drivers/edac/ie31200_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/ie31200_edac.c b/drivers/edac/ie31200_edac.c
> index eaab6af143e1..a5dc4b88097f 100644
> --- a/drivers/edac/ie31200_edac.c
> +++ b/drivers/edac/ie31200_edac.c
> @@ -706,7 +706,7 @@ static struct res_config skl_cfg = {
> .reg_mad_dimm_width_mask[1] = GENMASK(25, 24),
> };
>
> -struct res_config rpl_s_cfg = {
> +static struct res_config rpl_s_cfg = {
> .mtype = MEM_DDR5,
> .cmci = true,
> .imc_num = 2,
>
> base-commit: e77a5a5cfe43b4c25bd44a3818e487033287517f
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
© 2016 - 2026 Red Hat, Inc.