MIPS: Alchemy: Fix an out-of-bound access in db1200_dev_setup()

[PATCH] MIPS: Alchemy: Fix an out-of-bound access in db1200_dev_setup()

Posted by Christophe JAILLET 1 year, 11 months ago

When calling spi_register_board_info(), we should pass the number of
elements in 'db1200_spi_devs', not 'db1200_i2c_devs'.

Fixes: 63323ec54a7e ("MIPS: Alchemy: Extended DB1200 board support.")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only
---
 arch/mips/alchemy/devboards/db1200.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/alchemy/devboards/db1200.c b/arch/mips/alchemy/devboards/db1200.c
index f521874ebb07..67f067706af2 100644
--- a/arch/mips/alchemy/devboards/db1200.c
+++ b/arch/mips/alchemy/devboards/db1200.c
@@ -847,7 +847,7 @@ int __init db1200_dev_setup(void)
 	i2c_register_board_info(0, db1200_i2c_devs,
 				ARRAY_SIZE(db1200_i2c_devs));
 	spi_register_board_info(db1200_spi_devs,
-				ARRAY_SIZE(db1200_i2c_devs));
+				ARRAY_SIZE(db1200_spi_devs));
 
 	/* SWITCHES:	S6.8 I2C/SPI selector  (OFF=I2C	 ON=SPI)
 	 *		S6.7 AC97/I2S selector (OFF=AC97 ON=I2S)
-- 
2.34.1

Re: [PATCH] MIPS: Alchemy: Fix an out-of-bound access in db1200_dev_setup()

Posted by Thomas Bogendoerfer 1 year, 11 months ago

On Wed, Jan 10, 2024 at 07:07:36PM +0100, Christophe JAILLET wrote:
> When calling spi_register_board_info(), we should pass the number of
> elements in 'db1200_spi_devs', not 'db1200_i2c_devs'.
> 
> Fixes: 63323ec54a7e ("MIPS: Alchemy: Extended DB1200 board support.")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only
> ---
>  arch/mips/alchemy/devboards/db1200.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/alchemy/devboards/db1200.c b/arch/mips/alchemy/devboards/db1200.c
> index f521874ebb07..67f067706af2 100644
> --- a/arch/mips/alchemy/devboards/db1200.c
> +++ b/arch/mips/alchemy/devboards/db1200.c
> @@ -847,7 +847,7 @@ int __init db1200_dev_setup(void)
>  	i2c_register_board_info(0, db1200_i2c_devs,
>  				ARRAY_SIZE(db1200_i2c_devs));
>  	spi_register_board_info(db1200_spi_devs,
> -				ARRAY_SIZE(db1200_i2c_devs));
> +				ARRAY_SIZE(db1200_spi_devs));
>  
>  	/* SWITCHES:	S6.8 I2C/SPI selector  (OFF=I2C	 ON=SPI)
>  	 *		S6.7 AC97/I2S selector (OFF=AC97 ON=I2S)
> -- 
> 2.34.1

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]