[PATCH] ALSA: hda: use swap() to make code cleaner

davidcomponentone@gmail.com posted 1 patch 4 years, 6 months ago
sound/pci/hda/hda_auto_parser.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
[PATCH] ALSA: hda: use swap() to make code cleaner
Posted by davidcomponentone@gmail.com 4 years, 6 months ago
From: Yang Guang <yang.guang5@zte.com.cn>

Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: David Yang <davidcomponentone@gmail.com>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
---
 sound/pci/hda/hda_auto_parser.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c
index 4a854475a0e6..82c492b05667 100644
--- a/sound/pci/hda/hda_auto_parser.c
+++ b/sound/pci/hda/hda_auto_parser.c
@@ -92,14 +92,10 @@ static int compare_input_type(const void *ap, const void *bp)
  */
 static void reorder_outputs(unsigned int nums, hda_nid_t *pins)
 {
-	hda_nid_t nid;
-
 	switch (nums) {
 	case 3:
 	case 4:
-		nid = pins[1];
-		pins[1] = pins[2];
-		pins[2] = nid;
+		swap(pins[1], pins[2]);
 		break;
 	}
 }
-- 
2.30.2

Re: [PATCH] ALSA: hda: use swap() to make code cleaner
Posted by Takashi Iwai 4 years, 6 months ago
On Sat, 18 Dec 2021 02:54:16 +0100,
davidcomponentone@gmail.com wrote:
> 
> From: Yang Guang <yang.guang5@zte.com.cn>
> 
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: David Yang <davidcomponentone@gmail.com>
> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>

Applied now.  Thanks.


Takashi