drivers/pmdomain/amlogic/meson-secure-pwrc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
'struct meson_secure_pwrc_domain_data' are not modified in these drivers.
Constifying these structures moves some data to a read-only section, so
increases overall security.
On a x86_64, with allmodconfig:
Before:
======
text data bss dec hex filename
9248 408 0 9656 25b8 drivers/pmdomain/amlogic/meson-secure-pwrc.o
After:
=====
text data bss dec hex filename
9344 304 0 9648 25b0 drivers/pmdomain/amlogic/meson-secure-pwrc.o
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only
---
drivers/pmdomain/amlogic/meson-secure-pwrc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pmdomain/amlogic/meson-secure-pwrc.c b/drivers/pmdomain/amlogic/meson-secure-pwrc.c
index ff76ea36835e..e8bda60078c4 100644
--- a/drivers/pmdomain/amlogic/meson-secure-pwrc.c
+++ b/drivers/pmdomain/amlogic/meson-secure-pwrc.c
@@ -342,32 +342,32 @@ static int meson_secure_pwrc_probe(struct platform_device *pdev)
return of_genpd_add_provider_onecell(pdev->dev.of_node, &pwrc->xlate);
}
-static struct meson_secure_pwrc_domain_data meson_secure_a1_pwrc_data = {
+static const struct meson_secure_pwrc_domain_data meson_secure_a1_pwrc_data = {
.domains = a1_pwrc_domains,
.count = ARRAY_SIZE(a1_pwrc_domains),
};
-static struct meson_secure_pwrc_domain_data amlogic_secure_a4_pwrc_data = {
+static const struct meson_secure_pwrc_domain_data amlogic_secure_a4_pwrc_data = {
.domains = a4_pwrc_domains,
.count = ARRAY_SIZE(a4_pwrc_domains),
};
-static struct meson_secure_pwrc_domain_data amlogic_secure_a5_pwrc_data = {
+static const struct meson_secure_pwrc_domain_data amlogic_secure_a5_pwrc_data = {
.domains = a5_pwrc_domains,
.count = ARRAY_SIZE(a5_pwrc_domains),
};
-static struct meson_secure_pwrc_domain_data amlogic_secure_c3_pwrc_data = {
+static const struct meson_secure_pwrc_domain_data amlogic_secure_c3_pwrc_data = {
.domains = c3_pwrc_domains,
.count = ARRAY_SIZE(c3_pwrc_domains),
};
-static struct meson_secure_pwrc_domain_data meson_secure_s4_pwrc_data = {
+static const struct meson_secure_pwrc_domain_data meson_secure_s4_pwrc_data = {
.domains = s4_pwrc_domains,
.count = ARRAY_SIZE(s4_pwrc_domains),
};
-static struct meson_secure_pwrc_domain_data amlogic_secure_t7_pwrc_data = {
+static const struct meson_secure_pwrc_domain_data amlogic_secure_t7_pwrc_data = {
.domains = t7_pwrc_domains,
.count = ARRAY_SIZE(t7_pwrc_domains),
};
--
2.50.0
On Sun, 6 Jul 2025 at 17:45, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > 'struct meson_secure_pwrc_domain_data' are not modified in these drivers. > > Constifying these structures moves some data to a read-only section, so > increases overall security. > > On a x86_64, with allmodconfig: > Before: > ====== > text data bss dec hex filename > 9248 408 0 9656 25b8 drivers/pmdomain/amlogic/meson-secure-pwrc.o > > After: > ===== > text data bss dec hex filename > 9344 304 0 9648 25b0 drivers/pmdomain/amlogic/meson-secure-pwrc.o > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied for next, thanks! Kind regards Uffe > --- > Compile tested only > --- > drivers/pmdomain/amlogic/meson-secure-pwrc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/pmdomain/amlogic/meson-secure-pwrc.c b/drivers/pmdomain/amlogic/meson-secure-pwrc.c > index ff76ea36835e..e8bda60078c4 100644 > --- a/drivers/pmdomain/amlogic/meson-secure-pwrc.c > +++ b/drivers/pmdomain/amlogic/meson-secure-pwrc.c > @@ -342,32 +342,32 @@ static int meson_secure_pwrc_probe(struct platform_device *pdev) > return of_genpd_add_provider_onecell(pdev->dev.of_node, &pwrc->xlate); > } > > -static struct meson_secure_pwrc_domain_data meson_secure_a1_pwrc_data = { > +static const struct meson_secure_pwrc_domain_data meson_secure_a1_pwrc_data = { > .domains = a1_pwrc_domains, > .count = ARRAY_SIZE(a1_pwrc_domains), > }; > > -static struct meson_secure_pwrc_domain_data amlogic_secure_a4_pwrc_data = { > +static const struct meson_secure_pwrc_domain_data amlogic_secure_a4_pwrc_data = { > .domains = a4_pwrc_domains, > .count = ARRAY_SIZE(a4_pwrc_domains), > }; > > -static struct meson_secure_pwrc_domain_data amlogic_secure_a5_pwrc_data = { > +static const struct meson_secure_pwrc_domain_data amlogic_secure_a5_pwrc_data = { > .domains = a5_pwrc_domains, > .count = ARRAY_SIZE(a5_pwrc_domains), > }; > > -static struct meson_secure_pwrc_domain_data amlogic_secure_c3_pwrc_data = { > +static const struct meson_secure_pwrc_domain_data amlogic_secure_c3_pwrc_data = { > .domains = c3_pwrc_domains, > .count = ARRAY_SIZE(c3_pwrc_domains), > }; > > -static struct meson_secure_pwrc_domain_data meson_secure_s4_pwrc_data = { > +static const struct meson_secure_pwrc_domain_data meson_secure_s4_pwrc_data = { > .domains = s4_pwrc_domains, > .count = ARRAY_SIZE(s4_pwrc_domains), > }; > > -static struct meson_secure_pwrc_domain_data amlogic_secure_t7_pwrc_data = { > +static const struct meson_secure_pwrc_domain_data amlogic_secure_t7_pwrc_data = { > .domains = t7_pwrc_domains, > .count = ARRAY_SIZE(t7_pwrc_domains), > }; > -- > 2.50.0 >
© 2016 - 2025 Red Hat, Inc.