gpio: sim: Use correct order for the parameters of devm_kcalloc()

[PATCH] gpio: sim: Use correct order for the parameters of devm_kcalloc()

Posted by Christophe JAILLET 3 years, 11 months ago

We should have 'n', then 'size', not the opposite.
This is harmless because the 2 values are just multiplied, but having
the correct order silence a (unpublished yet) smatch warning.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpio/gpio-sim.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index 41c31b10ae84..98109839102f 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -314,8 +314,8 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)
 
 	for (i = 0; i < num_lines; i++) {
 		attr_group = devm_kzalloc(dev, sizeof(*attr_group), GFP_KERNEL);
-		attrs = devm_kcalloc(dev, sizeof(*attrs),
-				     GPIO_SIM_NUM_ATTRS, GFP_KERNEL);
+		attrs = devm_kcalloc(dev, GPIO_SIM_NUM_ATTRS, sizeof(*attrs),
+				     GFP_KERNEL);
 		val_attr = devm_kzalloc(dev, sizeof(*val_attr), GFP_KERNEL);
 		pull_attr = devm_kzalloc(dev, sizeof(*pull_attr), GFP_KERNEL);
 		if (!attr_group || !attrs || !val_attr || !pull_attr)
-- 
2.34.1

Re: [PATCH] gpio: sim: Use correct order for the parameters of devm_kcalloc()

Posted by Bartosz Golaszewski 3 years, 11 months ago

On Fri, May 20, 2022 at 9:21 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> We should have 'n', then 'size', not the opposite.
> This is harmless because the 2 values are just multiplied, but having
> the correct order silence a (unpublished yet) smatch warning.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/gpio/gpio-sim.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index 41c31b10ae84..98109839102f 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -314,8 +314,8 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)
>
>         for (i = 0; i < num_lines; i++) {
>                 attr_group = devm_kzalloc(dev, sizeof(*attr_group), GFP_KERNEL);
> -               attrs = devm_kcalloc(dev, sizeof(*attrs),
> -                                    GPIO_SIM_NUM_ATTRS, GFP_KERNEL);
> +               attrs = devm_kcalloc(dev, GPIO_SIM_NUM_ATTRS, sizeof(*attrs),
> +                                    GFP_KERNEL);
>                 val_attr = devm_kzalloc(dev, sizeof(*val_attr), GFP_KERNEL);
>                 pull_attr = devm_kzalloc(dev, sizeof(*pull_attr), GFP_KERNEL);
>                 if (!attr_group || !attrs || !val_attr || !pull_attr)
> --
> 2.34.1
>

Applied with an added Fixes tag.

Bart