[PATCH 2/3] mm,thp: fix nodeN/meminfo output alignment

Hugh Dickins posted 3 patches 2 years, 4 months ago
[PATCH 2/3] mm,thp: fix nodeN/meminfo output alignment
Posted by Hugh Dickins 2 years, 4 months ago
Add one more space to FileHugePages and FilePmdMapped, so the output
is aligned with other rows in /sys/devices/system/node/nodeN/meminfo.

Signed-off-by: Hugh Dickins <hughd@google.com>
---
 drivers/base/node.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index 9de524e56307..8e871ba9162f 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -446,8 +446,8 @@ static ssize_t node_read_meminfo(struct device *dev,
 			     "Node %d AnonHugePages:  %8lu kB\n"
 			     "Node %d ShmemHugePages: %8lu kB\n"
 			     "Node %d ShmemPmdMapped: %8lu kB\n"
-			     "Node %d FileHugePages: %8lu kB\n"
-			     "Node %d FilePmdMapped: %8lu kB\n"
+			     "Node %d FileHugePages:  %8lu kB\n"
+			     "Node %d FilePmdMapped:  %8lu kB\n"
 #endif
 #ifdef CONFIG_UNACCEPTED_MEMORY
 			     "Node %d Unaccepted:     %8lu kB\n"
-- 
2.35.3
Re: [PATCH 2/3] mm,thp: fix nodeN/meminfo output alignment
Posted by David Hildenbrand 2 years, 4 months ago
On 14.08.23 22:01, Hugh Dickins wrote:
> Add one more space to FileHugePages and FilePmdMapped, so the output
> is aligned with other rows in /sys/devices/system/node/nodeN/meminfo.
> 
> Signed-off-by: Hugh Dickins <hughd@google.com>
> ---
>   drivers/base/node.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index 9de524e56307..8e871ba9162f 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -446,8 +446,8 @@ static ssize_t node_read_meminfo(struct device *dev,
>   			     "Node %d AnonHugePages:  %8lu kB\n"
>   			     "Node %d ShmemHugePages: %8lu kB\n"
>   			     "Node %d ShmemPmdMapped: %8lu kB\n"
> -			     "Node %d FileHugePages: %8lu kB\n"
> -			     "Node %d FilePmdMapped: %8lu kB\n"
> +			     "Node %d FileHugePages:  %8lu kB\n"
> +			     "Node %d FilePmdMapped:  %8lu kB\n"
>   #endif
>   #ifdef CONFIG_UNACCEPTED_MEMORY
>   			     "Node %d Unaccepted:     %8lu kB\n"

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb