[PATCH mm-new] mm: optimize lru_note_cost() by adding lru_note_cost_unlock_irq() fix

Hugh Dickins posted 1 patch 2 months, 3 weeks ago
mm/swap.c | 7 -------
1 file changed, 7 deletions(-)
[PATCH mm-new] mm: optimize lru_note_cost() by adding lru_note_cost_unlock_irq() fix
Posted by Hugh Dickins 2 months, 3 weeks ago
Delete the comment from above the deleted spin_lock_irq(): it was all to
justify the first iteration's spin_lock_irq(), none suitable for moving
down to where the parent's spin_lock_irq() is now done.

Signed-off-by: Hugh Dickins <hughd@google.com>
---
Thank you all for the warm reception! Sorry, I missed this deletion.

 mm/swap.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/mm/swap.c b/mm/swap.c
index 37053f222a6e..3632dd061beb 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -259,13 +259,6 @@ void lru_note_cost_unlock_irq(struct lruvec *lruvec, bool file,
 	for (;;) {
 		unsigned long lrusize;
 
-		/*
-		 * Hold lruvec->lru_lock is safe here, since
-		 * 1) The pinned lruvec in reclaim, or
-		 * 2) From a pre-LRU page during refault (which also holds the
-		 *    rcu lock, so would be safe even if the page was on the LRU
-		 *    and could move simultaneously to a new lruvec).
-		 */
 		/* Record cost event */
 		if (file)
 			lruvec->file_cost += cost;
-- 
2.43.0