[v2] gpio: GPIO_GRGPIO should depend on OF

[PATCH v2 resend] gpio: GPIO_GRGPIO should depend on OF

Posted by Geert Uytterhoeven 10 months, 1 week ago

While the Aeroflex Gaisler GRGPIO driver has no build-time dependency on
gpiolib-of, it supports only DT-based configuration, and is used only on
DT systems.  Hence add a dependency on OF, to prevent asking the user
about this driver when configuring a kernel without DT support.

Fixes: bc40668def384256 ("gpio: grgpio: drop Kconfig dependency on OF_GPIO")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andreas Larsson <andreas@gaisler.com>
---
v2:
  - Add Reviewed-by,
  - Depend on OF instead of OF_GPIO.
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 68c5e69342571495..285a93061daee717 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -338,6 +338,7 @@ config GPIO_GRANITERAPIDS
 
 config GPIO_GRGPIO
 	tristate "Aeroflex Gaisler GRGPIO support"
+	depends on OF || COMPILE_TEST
 	select GPIO_GENERIC
 	select IRQ_DOMAIN
 	help
-- 
2.43.0

Re: [PATCH v2 resend] gpio: GPIO_GRGPIO should depend on OF

Posted by Bartosz Golaszewski 10 months, 1 week ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 05 Feb 2025 14:05:03 +0100, Geert Uytterhoeven wrote:
> While the Aeroflex Gaisler GRGPIO driver has no build-time dependency on
> gpiolib-of, it supports only DT-based configuration, and is used only on
> DT systems.  Hence add a dependency on OF, to prevent asking the user
> about this driver when configuring a kernel without DT support.
> 
> 

Applied, thanks!

[1/1] gpio: GPIO_GRGPIO should depend on OF
      commit: 5393f40a640b8c4f716bf87e7b0d4328bf1f22b2

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>