[PATCH 0/7] Implement SNP live firmware update support

Pratik R. Sampat posted 7 patches 2 weeks ago
There is a newer version of this series
.../driver-api/firmware/fw_upload.rst         |   2 +-
drivers/base/firmware_loader/sysfs_upload.c   |  50 +-
drivers/base/firmware_loader/sysfs_upload.h   |   1 -
drivers/crypto/ccp/sev-dev.c                  | 446 ++++++++++++++++--
drivers/crypto/ccp/sev-dev.h                  |   4 +
drivers/cxl/core/memdev.c                     |   4 +-
drivers/firmware/microchip/mpfs-auto-update.c |   2 +-
drivers/fpga/intel-m10-bmc-sec-update.c       |   4 +-
drivers/greybus/gb-beagleplay.c               |   2 +-
drivers/media/i2c/thp7312.c                   |   2 +-
drivers/net/pse-pd/pd692x0.c                  |   4 +-
drivers/virt/coco/tdx-host/tdx-host.c         |   4 +-
include/linux/firmware.h                      |  15 +-
include/linux/psp-sev.h                       |  19 +
lib/test_firmware.c                           |   3 +-
15 files changed, 474 insertions(+), 88 deletions(-)
[PATCH 0/7] Implement SNP live firmware update support
Posted by Pratik R. Sampat 2 weeks ago
Introducing support for live update on AMD SEV-SNP platforms via
DOWNLOAD_FIRMWARE_EX.

This patchset is an extension of the RFC patchset from Tycho
Andersen[1].

This series also fronts firmware_loader patches from Dan Williams[2]
which majorly cleans up refcount issues so that registering the upload
interface no longer pins the module. Without which having live firmware
update will cause failure to reload the ccp module as well as break
kexec.

Patches based on cryptodev-2.6

RFC..v1:
 * firmware-loader patches are rebased as-is and only incorporates
   fixes for minor build issues
 * Dropped crypto/ccp: Hoist kernel part of SNP_PLATFORM_STATUS as that
   patch has been merged since
 * Dropped crypto/ccp: Reclaim command buffer when the PSP dies and
   subsequent handling since firmware quirk is now resolved and need not be
   handled in the OS
 * Use guard(mutex) for the locked region, which the split makes
   possible since sev_get_api_version() acquires sev_cmd_mutex - Maxwell
 * Added a patch factoring out the TMR and INIT_EX teardown, so the update
   path and __sev_firmware_shutdown() share it - Shantanu
 * Skip the re-init when the PSP is dead, not just when a rollback is
   outstanding - Shantanu
 * Re-initialize the platform before refreshing the cached status -
   Shantanu
 * Split the monolithic .write into a locked update helper, an error
   translation helper, and a thin .write that refreshes the cached status
   once the lock is dropped and clean up various allocations
 * Convert rollback required and reinit required globals to reside in
   sev_dev struct to avoid carrying over states if manually reloaded

[1]: https://lore.kernel.org/all/20260430160716.1120553-1-tycho@kernel.org/
[2]: https://lore.kernel.org/lkml/20260331214726.903274-2-dan.j.williams@intel.com/

Dan Williams (3):
  firmware_loader: Stop pinning modules on registration
  firmware_loader: Stop pinning parent device per workqueue invocation
  treewide: firmware_loader: Drop the unused @module argument

Pratik R. Sampat (4):
  crypto: ccp - Factor out the release of the SEV firmware buffers
  crypto: ccp - Allow SNP platform data to be queried after SNP INIT
  crypto/ccp: Register with fw_uploader and always fail
  crypto/ccp: Implement SNP Download Firmware EX

 .../driver-api/firmware/fw_upload.rst         |   2 +-
 drivers/base/firmware_loader/sysfs_upload.c   |  50 +-
 drivers/base/firmware_loader/sysfs_upload.h   |   1 -
 drivers/crypto/ccp/sev-dev.c                  | 446 ++++++++++++++++--
 drivers/crypto/ccp/sev-dev.h                  |   4 +
 drivers/cxl/core/memdev.c                     |   4 +-
 drivers/firmware/microchip/mpfs-auto-update.c |   2 +-
 drivers/fpga/intel-m10-bmc-sec-update.c       |   4 +-
 drivers/greybus/gb-beagleplay.c               |   2 +-
 drivers/media/i2c/thp7312.c                   |   2 +-
 drivers/net/pse-pd/pd692x0.c                  |   4 +-
 drivers/virt/coco/tdx-host/tdx-host.c         |   4 +-
 include/linux/firmware.h                      |  15 +-
 include/linux/psp-sev.h                       |  19 +
 lib/test_firmware.c                           |   3 +-
 15 files changed, 474 insertions(+), 88 deletions(-)

-- 
2.43.0
Re: [PATCH 0/7] Implement SNP live firmware update support
Posted by Herbert Xu 1 week ago
On Thu, Sep 10, 2026 at 05:01:55PM +0000, Pratik R. Sampat wrote:
> Introducing support for live update on AMD SEV-SNP platforms via
> DOWNLOAD_FIRMWARE_EX.
> 
> This patchset is an extension of the RFC patchset from Tycho
> Andersen[1].
> 
> This series also fronts firmware_loader patches from Dan Williams[2]
> which majorly cleans up refcount issues so that registering the upload
> interface no longer pins the module. Without which having live firmware
> update will cause failure to reload the ccp module as well as break
> kexec.
> 
> Patches based on cryptodev-2.6

Please check the Sashiko comments:

https://sashiko.dev/#/patchset/cover.1789059391.git.prsampat%40amd.com

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [PATCH 0/7] Implement SNP live firmware update support
Posted by Pratik R. Sampat 1 week ago

On 9/18/26 5:05 AM, Herbert Xu wrote:
> On Thu, Sep 10, 2026 at 05:01:55PM +0000, Pratik R. Sampat wrote:
>> Introducing support for live update on AMD SEV-SNP platforms via
>> DOWNLOAD_FIRMWARE_EX.
>>
>> This patchset is an extension of the RFC patchset from Tycho
>> Andersen[1].
>>
>> This series also fronts firmware_loader patches from Dan Williams[2]
>> which majorly cleans up refcount issues so that registering the upload
>> interface no longer pins the module. Without which having live firmware
>> update will cause failure to reload the ccp module as well as break
>> kexec.
>>
>> Patches based on cryptodev-2.6
> 
> Please check the Sashiko comments:
> 
> https://sashiko.dev/#/patchset/cover.1789059391.git.prsampat%40amd.com
> 

Thanks for pointing me to these comments. I'll address the relevant ones in the
next iteration.

--Pratik