Hi,

This series adds the Cherry Trail machine driver and machine-table entry
needed by the Lenovo Yoga Book YB1-X91F/L with its RT5677 codec and
TS3A227E headset detector.

Only the SOF path is enabled. Legacy SST is deliberately not advertised
because it has not been validated on this hardware.

Changes in v6:
- Return clock-disable errors to DAPM callers.
- Propagate all headphone, speaker and ASRC GPIO/setup errors. Roll back
  the first speaker GPIO when the second update fails.
- Restore the mode-3 enable pulse and settling delay required by the
  external speaker boost amplifier, while checking every GPIO operation.
- Compact the SND_SOC_DAILINK_DEF() declarations and remove the redundant
  card comment.
- Restrict the driver and machine entry to SOF; remove the legacy SST
  firmware, board fields and conditional card naming.
- Remove snd_soc_fixup_dai_links_platform_name(). The card registers and
  all tested endpoints work without it.

Validation:
- W=1 build of cht_rt5677.o and soc-acpi-intel-cht-match.o.
- W=1 build and temporary load of snd-soc-sst-cht-rt5677.ko on the Yoga
  Book with Linux 7.2.0.
- PCM0 playback and capture.
- PCM1 deep-buffer playback.
- Manual GNOME Settings tests of both built-in speakers and microphone.
- No new kernel errors during the successful final hardware test.

The v6 series is sent as a fresh thread and Yauhen Kharuzhy is copied as
co-developer.

Maurizio Casciano (2):
  ASoC: Intel: Add Cherry Trail RT5677 machine driver
  ASoC: Intel: cht: Add Yoga Book RT5677 machine entry

 sound/soc/intel/boards/Kconfig                |  14 +
 sound/soc/intel/boards/Makefile               |   2 +
 sound/soc/intel/boards/cht_rt5677.c           | 636 ++++++++++++++++++
 .../intel/common/soc-acpi-intel-cht-match.c   |   6 +
 4 files changed, 658 insertions(+)
 create mode 100644 sound/soc/intel/boards/cht_rt5677.c

With Best Regards,
Maurizio Casciano

-- 
2.53.0

On 9/1/2026 9:04 PM, Maurizio Casciano wrote:
> Hi,
> 
> This series adds the Cherry Trail machine driver and machine-table entry
> needed by the Lenovo Yoga Book YB1-X91F/L with its RT5677 codec and
> TS3A227E headset detector.
> 
> Only the SOF path is enabled. Legacy SST is deliberately not advertised
> because it has not been validated on this hardware.
Before I move on to the review, this is contrary to what Yauhen claimed
in v2 [1].  So, are we just rolling the dice here?  If you have tested
both, it's OK to have both supported.  Changing in the middle of review
does not increase credibility.

[1]: https://lore.kernel.org/all/aaYRd2Irw8bOpDL0@jekhomev/

Hi Cezary,

You are right.  The statement in the cover letter is inaccurate: I
conflated "not revalidated by me against this revision" with "not
validated on this hardware", overlooking Yauhen's v2 report.

My testing covers the SOF path on a YB1-X91L, including PCM0
playback/capture and PCM1 deep-buffer playback.  Yauhen reported testing
the legacy SST path.  Those are separate test results, but together they
provide a basis for advertising both mutually exclusive firmware paths.

Narrowing v6 to SOF only was therefore an overcorrection, and the wording
made it appear as though the support decision was based on guesswork.  I
will restore the dual SST/SOF selection in the next revision and document
the validation of each path separately.  Yauhen, please correct me if I
have misstated the scope of the SST testing.

Sorry for the unnecessary churn.

With Best Regards,
Maurizio Casciano