selftests: Skip SUD tests when unsupported

[PATCH 0/3] selftests: Skip SUD tests when unsupported

Posted by Christian Loehle 1 month, 1 week ago

Syscall User Dispatch (SUD) is unavailable on architectures without
generic syscall entry. Such architectures return -EINVAL for otherwise
valid SUD prctl and ptrace requests, which the SUD selftests currently
report as failures.

Probe SUD with a valid disabled configuration and skip the affected tests
when that probe returns EINVAL. Unexpected errors remain failures, and the
existing coverage is unchanged on kernels that support SUD.

Christian Loehle (3):
  selftests/ptrace: Skip get_set_sud if SUD is unsupported
  selftests/syscall_user_dispatch: Skip tests if SUD is unsupported
  selftests/syscall_user_dispatch: Skip benchmark if SUD is unsupported

 tools/testing/selftests/ptrace/get_set_sud.c  |  8 +++++
 .../syscall_user_dispatch/sud_benchmark.c     |  9 +++++
 .../syscall_user_dispatch/sud_test.c          | 36 +++++++++++++++++++
 3 files changed, 53 insertions(+)


base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
-- 
2.34.1

Re: [PATCH 0/3] selftests: Skip SUD tests when unsupported

Posted by Gabriel Krisman Bertazi 3 weeks, 3 days ago

Christian Loehle <christian.loehle@arm.com> writes:

> Syscall User Dispatch (SUD) is unavailable on architectures without
> generic syscall entry. Such architectures return -EINVAL for otherwise
> valid SUD prctl and ptrace requests, which the SUD selftests currently
> report as failures.
>
> Probe SUD with a valid disabled configuration and skip the affected tests
> when that probe returns EINVAL. Unexpected errors remain failures, and the
> existing coverage is unchanged on kernels that support SUD.

Reviewed-by: Gabriel Krisman Bertazi <krisman@suse.de>

-- 
Gabriel Krisman Bertazi

Re: [PATCH 0/3] selftests: Skip SUD tests when unsupported

Posted by Christian Loehle 1 month ago

On 8/17/26 12:16, Christian Loehle wrote:
> Syscall User Dispatch (SUD) is unavailable on architectures without
> generic syscall entry. Such architectures return -EINVAL for otherwise
> valid SUD prctl and ptrace requests, which the SUD selftests currently
> report as failures.
> 
> Probe SUD with a valid disabled configuration and skip the affected tests
> when that probe returns EINVAL. Unexpected errors remain failures, and the
> existing coverage is unchanged on kernels that support SUD.
> 
> Christian Loehle (3):
>   selftests/ptrace: Skip get_set_sud if SUD is unsupported
>   selftests/syscall_user_dispatch: Skip tests if SUD is unsupported
>   selftests/syscall_user_dispatch: Skip benchmark if SUD is unsupported
> 
>  tools/testing/selftests/ptrace/get_set_sud.c  |  8 +++++
>  .../syscall_user_dispatch/sud_benchmark.c     |  9 +++++
>  .../syscall_user_dispatch/sud_test.c          | 36 +++++++++++++++++++
>  3 files changed, 53 insertions(+)
> 
> 
> base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f

Gentle ping on this

Re: [PATCH 0/3] selftests: Skip SUD tests when unsupported

Posted by Christian Loehle 2 weeks, 1 day ago

On 8/26/26 15:56, Christian Loehle wrote:
> On 8/17/26 12:16, Christian Loehle wrote:
>> Syscall User Dispatch (SUD) is unavailable on architectures without
>> generic syscall entry. Such architectures return -EINVAL for otherwise
>> valid SUD prctl and ptrace requests, which the SUD selftests currently
>> report as failures.
>>
>> Probe SUD with a valid disabled configuration and skip the affected tests
>> when that probe returns EINVAL. Unexpected errors remain failures, and the
>> existing coverage is unchanged on kernels that support SUD.
>>
>> Christian Loehle (3):
>>   selftests/ptrace: Skip get_set_sud if SUD is unsupported
>>   selftests/syscall_user_dispatch: Skip tests if SUD is unsupported
>>   selftests/syscall_user_dispatch: Skip benchmark if SUD is unsupported
>>
>>  tools/testing/selftests/ptrace/get_set_sud.c  |  8 +++++
>>  .../syscall_user_dispatch/sud_benchmark.c     |  9 +++++
>>  .../syscall_user_dispatch/sud_test.c          | 36 +++++++++++++++++++
>>  3 files changed, 53 insertions(+)
>>
>>
>> base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
> 
> Gentle ping on this

Another gentle ping, this should have all the reviews to land, right?

Re: [PATCH 0/3] selftests: Skip SUD tests when unsupported

Posted by Christian Loehle 1 week ago

On 9/13/26 11:24, Christian Loehle wrote:
> On 8/26/26 15:56, Christian Loehle wrote:
>> On 8/17/26 12:16, Christian Loehle wrote:
>>> Syscall User Dispatch (SUD) is unavailable on architectures without
>>> generic syscall entry. Such architectures return -EINVAL for otherwise
>>> valid SUD prctl and ptrace requests, which the SUD selftests currently
>>> report as failures.
>>>
>>> Probe SUD with a valid disabled configuration and skip the affected tests
>>> when that probe returns EINVAL. Unexpected errors remain failures, and the
>>> existing coverage is unchanged on kernels that support SUD.
>>>
>>> Christian Loehle (3):
>>>   selftests/ptrace: Skip get_set_sud if SUD is unsupported
>>>   selftests/syscall_user_dispatch: Skip tests if SUD is unsupported
>>>   selftests/syscall_user_dispatch: Skip benchmark if SUD is unsupported
>>>
>>>  tools/testing/selftests/ptrace/get_set_sud.c  |  8 +++++
>>>  .../syscall_user_dispatch/sud_benchmark.c     |  9 +++++
>>>  .../syscall_user_dispatch/sud_test.c          | 36 +++++++++++++++++++
>>>  3 files changed, 53 insertions(+)
>>>
>>>
>>> base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
>>
>> Gentle ping on this
> 
> Another gentle ping, this should have all the reviews to land, right?

Shuah, Thomas,
Either of you mind picking this up in either kselftest or core/entry?

Thanks!
Christian