ROHM bd71828 power-supply fixes

[PATCH 0/5] ROHM bd71828 power-supply fixes

Posted by Matti Vaittinen 1 month, 2 weeks ago

Fix a few issues from PSU drivers for ROHM components.

I hired couple of gnomes to work for me. :) (Ran AI reviews).
Unsurprizingly some bugs were spotted. Time to try fix mess (mostly) I
have (originally) authored.

Bugs were found by AI review but fixes are made by hand. Hence no
AI-tooling tags are added. Please, let me know if one is needed.

---

NOTE: Only _very_ shallow testing is done. Some of the fixes are not
tested in the hardware at all. All reviewing and testing is appreciated
as usual.

Matti Vaittinen (5):
  power: supply: bd71815: Fix temperature reading
  power: supply: bd71828: Fix current direction
  power: supply: bd71828: Drop duplicate power-supply property
  power: supply: bd71828: Do not hide errors
  power: supply: bd99954: Drop bad register fields

 drivers/power/supply/bd71828-power.c   | 20 ++++++++++++--------
 drivers/power/supply/bd99954-charger.h | 23 +----------------------
 2 files changed, 13 insertions(+), 30 deletions(-)


base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
-- 
2.55.0

Re: [PATCH 0/5] ROHM bd71828 power-supply fixes

Posted by Kalle Niemi 1 month, 2 weeks ago

On 8/10/26 13:08, Matti Vaittinen wrote:
> Fix a few issues from PSU drivers for ROHM components.
> 
> I hired couple of gnomes to work for me. :) (Ran AI reviews).
> Unsurprizingly some bugs were spotted. Time to try fix mess (mostly) I
> have (originally) authored.
> 
> Bugs were found by AI review but fixes are made by hand. Hence no
> AI-tooling tags are added. Please, let me know if one is needed.
> 
> ---
> 
> NOTE: Only _very_ shallow testing is done. Some of the fixes are not
> tested in the hardware at all. All reviewing and testing is appreciated
> as usual.

Hello,

This series is tested with a setup that has BD71815 and BD71828 installed.

Tested-by: Kalle Niemi <kaleposti@gmail.com>

Re: [PATCH 0/5] ROHM bd71828 power-supply fixes

Posted by Sebastian Reichel 1 month, 2 weeks ago

On Mon, 10 Aug 2026 13:08:09 +0300, Matti Vaittinen wrote:
> Fix a few issues from PSU drivers for ROHM components.
> 
> I hired couple of gnomes to work for me. :) (Ran AI reviews).
> Unsurprizingly some bugs were spotted. Time to try fix mess (mostly) I
> have (originally) authored.
> 
> Bugs were found by AI review but fixes are made by hand. Hence no
> AI-tooling tags are added. Please, let me know if one is needed.
> 
> [...]

Applied, thanks!

[1/5] power: supply: bd71815: Fix temperature reading
      commit: c15f0eabec5a051cb8190fa2bff3b211730f4acb
[2/5] power: supply: bd71828: Fix current direction
      commit: d012fab12fed2053e0dca4c8cd4e2b2053afabfb
[3/5] power: supply: bd71828: Drop duplicate power-supply property
      commit: 6605209ceb53eaa25582d1f4726217bd09eff392
[4/5] power: supply: bd71828: Do not hide errors
      commit: a3c841e420e124783a805919ab072551543e477b
[5/5] power: supply: bd99954: Drop bad register fields
      commit: 177299384a224377b4152242d875e752e5958c02

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>